[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

gbalats added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:142 +Every four 4-bytes aligned application bytes share a 4-byte origin value. A +4-byte origin contains a 4-bit depth and a 28-bit hash ID of a chain. + What is a chain? It's not

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

gbalats accepted this revision. gbalats added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/DataFlowSanitizer.rst:153 +If the flag is true, the label of ``v`` is the union of the label of ``p`` and +the label of ``*p``. If the flag is

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827708 , @gbalats wrote: > In D104494#2827639 , @vitalybuka > wrote: > >> https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this >> patch > > Looking

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827639 , @vitalybuka wrote: > https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this > patch Looking into this. I missed (due to the "\\" in the expression) updating this:

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats marked an inline comment as done. gbalats added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm);

[PATCH] D103745: [dfsan] Add full fast8 support

gbalats added inline comments. Comment at: llvm/test/Instrumentation/DataFlowSanitizer/external_mask.ll:6 define i32 @test(i32 %a, i32* nocapture readonly %b) #0 { -; CHECK: @"dfs$test" -; CHECK: %[[RV:.*]] load{{.*}}__dfsan_shadow_ptr_mask -; CHECK: ptrtoint i32* {{.*}} to i64

[PATCH] D103745: [dfsan] Add full fast8 support

gbalats marked an inline comment as done. gbalats added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:172-178 assert(ij_label == 3); // Verifies all of the above +// Or, equivalently: +assert(dfsan_has_label(ij_label, i_label)); +