[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/90370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

igorkudrin wrote: > I think out of tree builds of clang-tidy (back in the svn days, when people > did partial checkouts of individual projects) probably needed this to be able > to correctly correctly find the right headers. Maybe standalone builds aren't > permitted anymore? I think I

[clang-tools-extra] [clang-tidy] Enable plugin tests with LLVM_INSTALL_TOOLCHAIN_ONLY (PR #90370)

https://github.com/igorkudrin created https://github.com/llvm/llvm-project/pull/90370 The only reason for the removed condition was that there was a dependency for `CTTestTidyModule` on the `clang-tidy-headers` target, which was only created under the same `NOT LLVM_INSTALL_TOOLCHAIN_ONLY`

[clang-tools-extra] [llvm] [clang] [compiler-rt] [flang] [lldb] [lld] [libcxx] [YAMLParser] Unfold multi-line scalar values (PR #70898)

https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/70898 >From 113c03bbf773c71d329ab2afd063753365e4ac68 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 26 Oct 2023 13:19:08 -0700 Subject: [PATCH] [YAMLParser] Unfold multi-line scalar values Long scalar

[lld] [lldb] [flang] [libcxx] [compiler-rt] [clang-tools-extra] [llvm] [clang] [YAMLParser] Unfold multi-line scalar values (PR #70898)

https://github.com/igorkudrin updated https://github.com/llvm/llvm-project/pull/70898 >From 113c03bbf773c71d329ab2afd063753365e4ac68 Mon Sep 17 00:00:00 2001 From: Igor Kudrin Date: Thu, 26 Oct 2023 13:19:08 -0700 Subject: [PATCH] [YAMLParser] Unfold multi-line scalar values Long scalar

[clang] 43c307f - [CMake] Add llvm-lib to Clang bootstrap dependency for LTO builds on Windows

Author: Igor Kudrin Date: 2023-04-20T17:02:17-07:00 New Revision: 43c307fd690ffa97877f371ff18530fcd0bddd82 URL: https://github.com/llvm/llvm-project/commit/43c307fd690ffa97877f371ff18530fcd0bddd82 DIFF: https://github.com/llvm/llvm-project/commit/43c307fd690ffa97877f371ff18530fcd0bddd82.diff

[clang] 7352f42 - [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

Author: Igor Kudrin Date: 2021-11-10T10:08:06+07:00 New Revision: 7352f42cdc3c44038408edcdc4eb9890546020eb URL: https://github.com/llvm/llvm-project/commit/7352f42cdc3c44038408edcdc4eb9890546020eb DIFF: https://github.com/llvm/llvm-project/commit/7352f42cdc3c44038408edcdc4eb9890546020eb.diff

[clang] 5b7ea8e - [clang-tblgen] Fix non-determinism in generating AttributeReference.rst

Author: Igor Kudrin Date: 2021-11-10T10:08:07+07:00 New Revision: 5b7ea8e62921e53fdea73d948eb0d48c071d4b73 URL: https://github.com/llvm/llvm-project/commit/5b7ea8e62921e53fdea73d948eb0d48c071d4b73 DIFF: https://github.com/llvm/llvm-project/commit/5b7ea8e62921e53fdea73d948eb0d48c071d4b73.diff

[clang] a0c9ec1 - [Driver] Honor "-gdwarf-N" at any position for assembler sources

Author: Igor Kudrin Date: 2021-02-18T10:36:42+07:00 New Revision: a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab URL: https://github.com/llvm/llvm-project/commit/a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab DIFF: https://github.com/llvm/llvm-project/commit/a0c9ec1f5e70e8f15da170667b2a8e63d024f3ab.diff

[clang] 72eee60 - [Driver] Support -gdwarf64 for assembly files

Author: Igor Kudrin Date: 2021-02-17T17:03:34+07:00 New Revision: 72eee60b2451e8627e492d42bf1d43247685bef9 URL: https://github.com/llvm/llvm-project/commit/72eee60b2451e8627e492d42bf1d43247685bef9 DIFF: https://github.com/llvm/llvm-project/commit/72eee60b2451e8627e492d42bf1d43247685bef9.diff

[clang] aa84289 - [DebugInfo] Keep the DWARF64 flag in the module metadata

Author: Igor Kudrin Date: 2021-02-17T17:03:34+07:00 New Revision: aa842896299b014dc1837f1a01dfccbd94242c84 URL: https://github.com/llvm/llvm-project/commit/aa842896299b014dc1837f1a01dfccbd94242c84 DIFF: https://github.com/llvm/llvm-project/commit/aa842896299b014dc1837f1a01dfccbd94242c84.diff

[clang] 474d527 - [clang] Fix a misleading variable name. NFC.

Author: Igor Kudrin Date: 2020-09-21T22:59:34+07:00 New Revision: 474d527c28f4e88ffda7b82e93e351aec2602380 URL: https://github.com/llvm/llvm-project/commit/474d527c28f4e88ffda7b82e93e351aec2602380 DIFF: https://github.com/llvm/llvm-project/commit/474d527c28f4e88ffda7b82e93e351aec2602380.diff

r361598 - Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

Author: ikudrin Date: Thu May 23 21:46:22 2019 New Revision: 361598 URL: http://llvm.org/viewvc/llvm-project?rev=361598=rev Log: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows. If the source file path contains directory junctions, and we resolve them when

r335445 - [CodeGen] Provide source locations for UBSan type checks when emitting constructor calls.

Author: ikudrin Date: Sun Jun 24 22:48:04 2018 New Revision: 335445 URL: http://llvm.org/viewvc/llvm-project?rev=335445=rev Log: [CodeGen] Provide source locations for UBSan type checks when emitting constructor calls. Differential Revision: https://reviews.llvm.org/D48531 Added:

r326164 - [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

Author: ikudrin Date: Mon Feb 26 18:51:30 2018 New Revision: 326164 URL: http://llvm.org/viewvc/llvm-project?rev=326164=rev Log: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows. clang used to require adding an ".exe" suffix when targeting ELF systems on

[libcxxabi] r286337 - [libc++abi] Remove the test for checking using of fallback malloc in case of dynamic memory exhaustion.

Author: ikudrin Date: Tue Nov 8 22:14:31 2016 New Revision: 286337 URL: http://llvm.org/viewvc/llvm-project?rev=286337=rev Log: [libc++abi] Remove the test for checking using of fallback malloc in case of dynamic memory exhaustion. This test is too fragile and doesn't add significant value.

[PATCH] D26150: [libc++abi] Fix test_exception_storage_nodynmem on MacOS

ikudrin added a comment. The test is too implementation-specific, and trying to override a function like `calloc` makes it fragile. Unfortunately, I didn't find a better way to test the library's behavior in case of memory exhaustion, but now I believe that this test doesn't add any

[PATCH] D25608: [libclang] Make tests for python bindings pass on Windows.

ikudrin added a comment. Ping. https://reviews.llvm.org/D25608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25608: [libclang] Make tests for python bindings pass on Windows.

ikudrin added a comment. Ping. https://reviews.llvm.org/D25608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r284464 - [libclang] Add missing cursor kinds to python bindings.

Author: ikudrin Date: Tue Oct 18 04:42:03 2016 New Revision: 284464 URL: http://llvm.org/viewvc/llvm-project?rev=284464=rev Log: [libclang] Add missing cursor kinds to python bindings. Differential Revision: https://reviews.llvm.org/D25673 Modified: cfe/trunk/bindings/python/clang/cindex.py

[PATCH] D25673: [libclang] Add missing cursor kinds to python bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284464: [libclang] Add missing cursor kinds to python bindings. (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D25673?vs=74834=74960#toc Repository: rL LLVM

[PATCH] D25470: [libclang] Fix a failure in a test for python bindings on CursorKind.OVERLOAD_CANDIDATE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL284463: [libclang] Fix a failure in a test for python bindings on CursorKind. (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D25470?vs=74237=74959#toc Repository: rL LLVM

r284463 - [libclang] Fix a failure in a test for python bindings on CursorKind.OVERLOAD_CANDIDATE.

Author: ikudrin Date: Tue Oct 18 04:30:33 2016 New Revision: 284463 URL: http://llvm.org/viewvc/llvm-project?rev=284463=rev Log: [libclang] Fix a failure in a test for python bindings on CursorKind.OVERLOAD_CANDIDATE. The test fails because the value does not lay in any existing group.

[PATCH] D25673: [libclang] Add missing cursor kinds to python bindings.

ikudrin created this revision. ikudrin added reviewers: compnerd, ABataev, erik.pilkington, ogoffart. ikudrin added a subscriber: cfe-commits. https://reviews.llvm.org/D25673 Files: bindings/python/clang/cindex.py Index: bindings/python/clang/cindex.py

[PATCH] D25572: [Coverage] Support for C++17 if initializers

ikudrin accepted this revision. ikudrin added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25539: [Coverage] Support for C++17 switch initializers

ikudrin accepted this revision. ikudrin added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25608: [libclang] Make tests for python bindings pass on Windows.

ikudrin created this revision. ikudrin added reviewers: hansonw, compnerd, indygreg, eliben. ikudrin added a subscriber: cfe-commits. Please note that this patch fixes only Windows-related issues. https://reviews.llvm.org/D25470 is required to pass all the tests.

[PATCH] D25470: [libclang] Fix a failure in a test for python bindings on CursorKind.OVERLOAD_CANDIDATE.

ikudrin created this revision. ikudrin added reviewers: hansonw, compnerd. ikudrin added a subscriber: cfe-commits. The test fails because the value does not lay in any existing group. The value was added in r268167. https://reviews.llvm.org/D25470 Files:

[PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283531: Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D17815?vs=72951=73893#toc Repository:

[libcxxabi] r283531 - Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

Author: ikudrin Date: Fri Oct 7 03:48:28 2016 New Revision: 283531 URL: http://llvm.org/viewvc/llvm-project?rev=283531=rev Log: Recommit r282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion. Throwing an exception for the first time may lead

[PATCH] [Reopened] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin reopened this revision. ikudrin added a comment. This revision is now accepted and ready to land. @rmaprath: There are some issues in the test which upset build bots and I need some time to fix them. You don't need to wait for me, I'll put my patch on the top of yours when my fix is

[libcxxabi] r282703 - Revert r282692: Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

Author: ikudrin Date: Thu Sep 29 03:11:57 2016 New Revision: 282703 URL: http://llvm.org/viewvc/llvm-project?rev=282703=rev Log: Revert r282692: Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion. The test breaks build bots. Added:

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282692: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D17815?vs=54189=72951#toc Repository: rL

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

Hi Eric, Ping... On 19-Sep-16 13:57, Eric Fiselier wrote: I'll look at these first thing next week. If you remember please ping me. (It's Cppcon this week) Sorry I haven't reviewed this already. Thank you for working on this. On Sep 18, 2016 11:55 PM, "Igor Kudrin"

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Hi, Ping. The patch is under review for a long time and the described problem is still here. As we've seen the issue in practice, I'm sure that others may also run into it, and I do believe it should be fixed, one way or another. @EricWF, can I improve the patch

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... https://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280199 - [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

Author: ikudrin Date: Wed Aug 31 02:04:16 2016 New Revision: 280199 URL: http://llvm.org/viewvc/llvm-project?rev=280199=rev Log: [Coverage] Suppress creating a code region if the same area is covered by an expansion region. In most cases these code regions are just redundant, but sometimes they

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280199: [Coverage] Suppress creating a code region if the same area is covered by an… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D23987?vs=69709=69799#toc Repository:

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin updated this revision to Diff 69709. ikudrin added a comment. - Removed a default value in `emitSourceRegions()`, added the corresponding argument to its call in `EmptyCoverageMappingBuilder::write()`. - Removed an additional sorting step in `CounterCoverageMappingBuilder::write()`, the

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin added inline comments. Comment at: lib/CodeGen/CoverageMappingGen.cpp:261 @@ -253,2 +260,3 @@ + void emitSourceRegions(const SourceRegionFilter ) { for (const auto : SourceRegions) { assert(Region.hasEndLoc() && "incomplete region"); Well,

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279962: [Coverage] Prevent creating a redundant counter if a nested body ends with a… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D23160?vs=66790=69556#toc Repository:

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

ikudrin added a comment. This patch fixes the following issue: $ cat > test.cpp << EOF void dummy() {} #define MACRO_1 dummy() #define MACRO_2 MACRO_1 int main() { int i = 0; if (i > 5) MACRO_2; } EOF $ clang++ -fprofile-instr-generate -fcoverage-mapping

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. I figured out that the last issue is an independent one, so I prepared a separate fix for it: https://reviews.llvm.org/D23987. https://reviews.llvm.org/D23160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Hi, Ping. The issue in the current implementation of the libc++abi library looks like a time bomb. Even though its probability could be considered as very low, in fact, it depends on the type of an application. At least, we ran into it in our environment. I'd guess

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. I've reduced the last sample to the following: 0|1|void dummy() {} |2| 0|3|#define MACRO_1 dummy() |4| 1|5|#define MACRO_2 MACRO_1 |6| 1|7|int main() { 1|8| int i = 0; 1|9| if

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. In https://reviews.llvm.org/D23160#506061, @vsk wrote: > I guess it never makes sense to have two regions with the exact same > start/end loc, and different counters. Do you think we should add assertions > in llvm (either in llvm-cov, or in the coverage reader) which

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. The motivation sample: $ cat > test.cpp << EOF void dummy() {} #define MACRO dummy() int main() { int i = 0; while (i++ < 10) if (i < 5) MACRO; return 0; } EOF $ clang++ -fprofile-instr-generate -fcoverage-mapping dummy.cpp

[PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin created this revision. ikudrin added reviewers: vsk, davidxl, bogner. ikudrin added a subscriber: cfe-commits. If there were several nested statements arranged in a way that all of them end up with the same macro, then the expansion of this macro was assigned with all the corresponding

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... This patch is under review for more than two months, and I believe I've addressed all the comments. Could someone take a look at it, please? http://reviews.llvm.org/D17815 ___ cfe-commits mailing list

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271995 - Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

Author: ikudrin Date: Tue Jun 7 05:07:51 2016 New Revision: 271995 URL: http://llvm.org/viewvc/llvm-project?rev=271995=rev Log: Reapply [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. We have an assertion failure if, for example, the definition

r271976 - Revert [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

Author: ikudrin Date: Mon Jun 6 23:11:51 2016 New Revision: 271976 URL: http://llvm.org/viewvc/llvm-project?rev=271976=rev Log: Revert [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. r271969 The test case fails on Windows. Removed:

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271969: [Coverage] Fix an assertion failure if the definition of an unused function… (authored by ikudrin). Changed prior to commit: http://reviews.llvm.org/D20997?vs=59806=59818#toc Repository: rL

r271969 - [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

Author: ikudrin Date: Mon Jun 6 21:17:03 2016 New Revision: 271969 URL: http://llvm.org/viewvc/llvm-project?rev=271969=rev Log: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files. We have an assertion failure if, for example, the definition of an

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

ikudrin added a comment. I agree that it'd be expensive to put a new counter after each function call. Even if there is no `throw` statement within a TU, called functions still may raise exceptions. Anyway, if we come across a `try` statement, we can guess that some exceptions are expected and

Re: [PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

ikudrin updated the summary for this revision. ikudrin removed rL LLVM as the repository for this revision. ikudrin updated this revision to Diff 59806. ikudrin added a comment. - Use `StartFileID` and `EndFileID` variables to eliminate redundant calls to `SM.getFileID()`. - Add comment strings

[PATCH] D20997: [Coverage] Fix an assertion failure if the definition of an unused function spans multiple files.

ikudrin created this revision. ikudrin added reviewers: vsk, bogner, davidxl. ikudrin added a subscriber: cfe-commits. ikudrin set the repository for this revision to rL LLVM. We had an assertion failure if, for example, the definition of an unused inline function starts in one macro and ends in

Re: [PATCH] D20878: [Coverage] Do not push a new region after a CXXTryStmt

ikudrin added a comment. So, our tool isn't accurate in the case of throwing an exception. Is there a case where this patch makes things better than they were before? Is it possible to improve handling of exceptions instead? http://reviews.llvm.org/D20878

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin abandoned this revision. ikudrin added a comment. This change is not needed anymore because the whole issue was fixed in http://reviews.llvm.org/D20286. http://reviews.llvm.org/D20287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin added a comment. Does anyone known, why we need dummy coverage mapping records for unused functions? How are they used? Isn't it better to remove these dummy records to prevent confusion with the real ones? http://reviews.llvm.org/D20287

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin added a comment. The motivation sample (using llvm-cov with http://reviews.llvm.org/D20286 applied): $ cat > sample.h << EOF inline int sample_func(int A) { return A; } EOF $ cat > dummy.cpp << EOF #include "sample.h" EOF $ cat > sample.cpp << EOF #include

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping?.. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268511: [Coverage] Fix an issue where a coverage region might not be created for a… (authored by ikudrin). Changed prior to commit: http://reviews.llvm.org/D19725?vs=55602=56159#toc Repository: rL

r268511 - [Coverage] Fix an issue where a coverage region might not be created for a macro containing a loop statement.

Author: ikudrin Date: Wed May 4 10:38:26 2016 New Revision: 268511 URL: http://llvm.org/viewvc/llvm-project?rev=268511=rev Log: [Coverage] Fix an issue where a coverage region might not be created for a macro containing a loop statement. The issue happened when a macro contained a full for or

Re: [PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

Thank you! On 02.05.2016 06:40, Justin Bogner wrote: Igor Kudrin writes: + /// \brief Check whether a region with bounds \c StartLoc and \c EndLoc + /// is already added to \c SourceRegions. + bool isRegionAlreadyAdded(SourceLocation StartLoc, SourceLocation

[PATCH] D19725: [Coverage] Fix an issue where a coverage region might not be created for a macro containing for or while statements.

ikudrin created this revision. ikudrin added reviewers: bogner, davidxl, vsk. ikudrin added a subscriber: cfe-commits. The situation happened when a macro contained a full loop statement, which body ended at the end of the macro. http://reviews.llvm.org/D19725 Files:

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin updated this revision to Diff 54189. ikudrin added a comment. - Moved the content of `fallback_malloc.ipp` into `falback_malloc.cpp`. - Removed `fallback_malloc.ipp`. - Added `pragma GCC visibility push(hidden)` for the function's definitions. - Added a check that the overwritten `calloc`

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin updated this revision to Diff 54151. ikudrin added a comment. Regenerated the patch against project's root. http://reviews.llvm.org/D17815 Files: src/CMakeLists.txt src/cxa_exception.cpp src/cxa_exception_storage.cpp src/fallback_malloc.cpp src/fallback_malloc.h

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping! Could anyone check this patch, please? http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping... http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin updated the summary for this revision. ikudrin updated this revision to Diff 51782. ikudrin added a comment. Make cxa_exception.cpp and cxa_exception_storage.cpp to use the same emergency memory pool. http://reviews.llvm.org/D17815 Files: libcxxabi/trunk/src/CMakeLists.txt

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Thanks! I'll see what I can do about it. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping?.. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin added a comment. Ping. http://reviews.llvm.org/D17815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

ikudrin created this revision. ikudrin added reviewers: mclow.lists, howard.hinnant, EricWF. ikudrin added a subscriber: cfe-commits. Throwing an exception for the first time may lead to calling calloc to allocate memory for __cxa_eh_globals. If the memory pool at that moment is exhausted, it

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin updated this revision to Diff 35585. ikudrin added a comment. - Rebased to the top of history - Made pathes local to clang subtree http://reviews.llvm.org/D12832 Files: lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h Index: lib/Driver/ToolChains.h

r248463 - [Driver] Add support for Windows 10 SDK

Author: ikudrin Date: Thu Sep 24 00:16:36 2015 New Revision: 248463 URL: http://llvm.org/viewvc/llvm-project?rev=248463=rev Log: [Driver] Add support for Windows 10 SDK Summary: With Windows 10 SDK, Include and Lib directories now contain an additional subfolder with the name that corresponds

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin marked 2 inline comments as done. ikudrin added a comment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12832: [Driver] Added support for Windows 10 SDK

ikudrin updated this revision to Diff 34965. ikudrin added a comment. - reworked the conditional statement - formatting http://reviews.llvm.org/D12832 Files: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h Index: cfe/trunk/lib/Driver/ToolChains.h

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin added a comment. I found a new problem, after install WDK. I'll submit a new version in a moment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin marked an inline comment as done. ikudrin added a comment. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

ikudrin updated this revision to Diff 35013. ikudrin added a comment. Skip directories like C:\Program Files (x86)\Windows Kits\10\Include\wdf, which come from WDK installation, when looking for SDK version. Now, we detect directories even better than vsvars32.bat in that situation.

Re: [PATCH] D12832: [Driver] Added support for Windows 10 SDK

ikudrin added a comment. Ping? http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12832: [Driver] Added support for Windows 10 SDK

ikudrin created this revision. ikudrin added reviewers: ruiu, rnk. ikudrin added a subscriber: cfe-commits. With Windows 10 SDK, Include and Lib directories now contain an additional subfolder with the name that corresponds to the full version of the SDK, for example: - C:\Program Files

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

Please, can you show the output of the following commands: 1) set include 2) set lib 3) clang-cl.exe -### -fms-compatibility-version=19 foo.cpp On 11.09.2015 17:44, İsmail Dönmez wrote: This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin added a comment. In http://reviews.llvm.org/D12695#243552, @rnk wrote: > There's a bunch of whitespace issues that clang-format can resolve. Thanks! I'll reformat it. > We also have the convention that variables are StudlyCaps, which isn't > followed in a few places. I've tried to

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin marked an inline comment as done. ikudrin added a comment. In http://reviews.llvm.org/D12695#243320, @rnk wrote: > FYI @ruiu is moving this code to LLVM in http://reviews.llvm.org/D12604. Thanks. I think I'll move my changes to the new place when he's finished.

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin updated this revision to Diff 34475. ikudrin added a comment. - Fixed formatting issues. - Normalized VariableNames. - Reworked the useUniversalCRT method to receive a path of Visual Studio. http://reviews.llvm.org/D12695 Files: lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h

[PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

ikudrin created this revision. ikudrin added a subscriber: cfe-commits. With Visual Studio 2015 release, a part of runtime library was extracted and now comes with Windows Kits. This patch enables clang to use Universal CRT library if %INCLUDE or %LIB environment varaibles are not specified.