[PATCH] D148422: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG790c9ac529c9: [ClangFE] Handle statement expressions properly with CheckAtomicAlignment(). (authored by jonpa). Herald added a project: clang.

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa accepted this revision. jonpa added a comment. This revision is now accepted and ready to land. In D143813#4269073 , @efriedma wrote: > Please don't upload reviews for followup patches on top of the original > patch; it confuses the history of

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa updated this revision to Diff 513573. jonpa added a comment. > Should be straightforward to fix, though; just make CheckAtomicAlignment > return the computed pointer. Something like this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143813/new/ https://reviews.llvm.org/D143813

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa added a comment. In D143813#4258744 , @ahatanak wrote: > In D143813#4257943 , @jonpa wrote: > >> I don't understand the first argument - I thought it was supposed to be just >> an address... > > It's a

[PATCH] D78644: [LSan] Enable for SystemZ

jonpa added a comment. Update clang/docs/LeakSanitizer.rst (Supported Platforms). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 ___ cfe-commits mailing list

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa added a comment. In D143813#4256969 , @ahatanak wrote: > I think this patch is causing the assertion in > `CodeGenFunction::setAddrOfLocalVar` to fail when the following code is > compiled: > > void foo(unsigned long long t) { >

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7501e53b8d6d: [Clang] Give warning for an underaligned 128-bit __sync library call. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D141409: [SystemZ] Fix handling of vectors and their exposure of the vector ABI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0eff46f87f16: [SystemZ] Fix handling of vectors and their exposure of the vector ABI. (authored by jonpa). Herald added a project: clang. Herald

[PATCH] D105067: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jonpa marked an inline comment as done. Closed by commit rG481bb44baab5: [SystemZ] Emit a .gnu_attribute for an externally visible vector abi. (authored by jonpa).

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

jonpa added a comment. In D137044#3943829 , @Fznamznon wrote: > In D137044#3943680 , @jonpa wrote: > >> In D137044#3942990 , @pcwang-thead >> wrote: >> >>> The test

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

jonpa added a comment. In D137044#3942990 , @pcwang-thead wrote: > The test `clang/test/Driver/pic.c` failed when we compiled Clang/LLVM with > `-DCLANG_DEFAULT_PIE_ON_LINUX=False`. Ah... I suppose that must be because -mno-pic-data-is-text-relative

[PATCH] D137044: [ClangFE] Add support for option -mno-pic-data-is-text-relative

This revision was automatically updated to reflect the committed changes. Closed by commit rG858f347c1758: [Clang, SystemZ] Add support for option -mno-pic-data-is-text-relative. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D131158: [SystemZ] Improve handling of vector alignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde0e3117d40a: [SystemZ] Improve handling of vector alignments. (authored by jonpa). Herald added a project: clang. Herald added a subscriber:

[PATCH] D130900: [SystemZ] Make 128 bit integers be aligned to 8 bytes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84831bdfedba: [SystemZ] Make 128 bit integers be aligned to 8 bytes. (authored by jonpa). Herald added a project: clang. Herald added a subscriber:

[PATCH] D122388: [SystemZ] Fix C++ ABI for passing args of structs containing zero width bitfield.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b38e2efa0f0: [SystemZ] Fix C++ ABI for passing args of structs containing zero width… (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D110267: [InlineAsm, SystemZ] Handle inline assembly address operands.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa5dc15f086: [SystemZ] Handle SystemZ specific inline assembly address operands. (authored by jonpa). Herald added a project: clang. Herald added a

[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

jonpa added a comment. -no-opaque-pointers added to SystemZ clang test, per 532dc62 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10/new/ https://reviews.llvm.org/D10

[PATCH] D122220: [InlineAsm] Add support for address operands ("p").

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46f83caebc8f: [InlineAsm] Add support for address operands (p). (authored by jonpa). Herald added a project: clang. Herald added a subscriber:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. Sorry for the delay. > This change seems like it's done in the wrong layer -- why do we add a > special-case in Clang to emit "={r11},{r11}", instead of fixing LLVM to not > break when given the previously-output "={r11},0"? We were starting out with a test case that

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2832781 , @thopre wrote: > In D96568#2569296 , @jonpa wrote: > >>> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >>> single hook will make the patch

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfd301ec8b5: [SystemZ] Test for isinf and isfinite in testFPKind(). (authored by jonpa). Herald added a project: clang. Repository: rG LLVM

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa updated this revision to Diff 330753. jonpa added a comment. > This "invert" logic doesn't look correct. "isfinite" and "isinf" both need to > return false on NaNs. I think you should just drop the invert logic and use a > TDC mask of 0xFC0 (zero, normal, or subnormal) to implement

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; What are these variants all about...? CHANGES SINCE LAST ACTION

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa created this revision. jonpa added reviewers: uweigand, thopre. jonpa requested review of this revision. Recognize __builtin_isinf and BI__builtin_isfinite (and a few other builtin opcodes for finite checks) in testFPKind(). TDC can check for infinity, and for finite with an inversion of

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

jonpa added a comment. In D97125#2578853 , @kpn wrote: > System/Z's TEST DATA CLASS instruction covers most (all?) of the possible FP > value states. You might want to subscribe, or add as a reviewer, jonpa just > to make sure everyone stays in sync.

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe57bd1ff4fb6: [CFE, SystemZ] New target hook testFPKind() for checks of FP values. (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2569710 , @thopre wrote: > In D96568#2569296 , @jonpa wrote: > >>> Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a >>> single hook will make the patch

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa updated this revision to Diff 324376. jonpa added a comment. > Sounds good to me. Hopefully I'll get round to __builtin_isinf soon and a > single hook will make the patch slightly smaller. Patch updated to call the new hook testFPKind() and make it take a BuiltinID as argument (that

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

jonpa added a comment. In D96568#2559476 , @thopre wrote: > In D96568#2559475 , @uweigand wrote: > >> In D96568#2559336 , @thopre wrote: >> >>> That's interesting. I presume

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

jonpa added a comment. Committed after changed to use __builtin_memcpy() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96471/new/ https://reviews.llvm.org/D96471 ___ cfe-commits mailing list

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb3ac5b84cdd4: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst. (authored by jonpa). Herald added

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

jonpa added inline comments. Comment at: llvm/lib/Transforms/Scalar/LoopDeletion.cpp:132 /// A loop is considered dead if it does not impact the observable behavior of /// the program other than finite running time. This never removes a loop that /// might be infinite (unless

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42a82862b625: Reapply [clang] Improve handling of physical registers in inline (authored by jonpa). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 298819. jonpa added a comment. Sorry, here's the test case included as well... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen/aarch64-inline-asm.c

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 298624. jonpa added a comment. That makes sense... Patch updated to keep the tying of operands for this case of earlyclobber. @nickdesaulniers : Can you see if this patch now passes your builds? CHANGES SINCE LAST ACTION

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. The problem seems to be with a tied earlyclobber operand: asm("" : "+"(a)); Per the comment in InlineAsm::ConstraintInfo::Parse(), only output can be earlyclobber. I am not sure if the earlyclobber ('&') should with this patch be removed from the added use of the

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa reopened this revision. jonpa added a comment. This revision is now accepted and ready to land. Patch temporarily reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc78da037783b: [clang] Improve handling of physical registers in inline assembly operands. (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 297136. jonpa marked an inline comment as done. jonpa added a comment. Updated message string per review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 296901. jonpa marked an inline comment as done. jonpa added a comment. Updated per review to use SmallSet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2090 +CGM.Error(S.getAsmLoc(), "Multiple outputs to hard register: " + GCCReg); + PhysRegOutputs.insert(GCCReg); +} craig.topper wrote: > Can we get rid of the count call

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 296618. jonpa marked an inline comment as done. jonpa added a comment. Updated per review by eliminating the call to 'count'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added reviewers: RKSimon, jyu2, t.p.northover, echristo, dylanmckay, aaron.ballman. jonpa added a comment. Herald added a subscriber: pengfei. Ping! Last chance for anyone to speak up about any objections to committing this... CHANGES SINCE LAST ACTION

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78717: [SystemZ] Implement -fstack-clash-protection

This revision was automatically updated to reflect the committed changes. jonpa marked an inline comment as done. Closed by commit rG515bfc66eace (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D74506: [SystemZ] Support the kernel backchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG82879c2913da: [SystemZ] Support the kernel back chain. (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D72189: [SystemZ] Support -msoft-float

jonpa added a comment. In D72189#1857098 , @thakis wrote: > Hello, this breaks tests on all platforms (e.g.: > http://45.33.8.238/mac/7170/step_11.txt) Please revert immediately and please > run tests locally before committing next time. I have added

[PATCH] D72189: [SystemZ] Support -msoft-float

This revision was automatically updated to reflect the committed changes. Closed by commit rG563e84790f41: [SystemZ] Support -msoft-float (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

jonpa closed this revision. jonpa added a comment. ca52059 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71669/new/ https://reviews.llvm.org/D71669 ___ cfe-commits

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

jonpa created this revision. jonpa added a reviewer: uweigand. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Let the "mnop-mcount" function attribute simply be present or non-present. Update SystemZ backend as well to use hasFnAttribute() instead.

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa closed this revision. jonpa added a comment. committed as 9376714 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a reviewer: bkramer. jonpa added a comment. @Benjamin: I see that you removed the option that I am now putting back, so perhaps you could take a look and see if this patch looks ok? Thanks. /Jonas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/ https://reviews.llvm.org/D67763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits