[clang] [llvm] [clang] Reland Add tanf16 builtin and support for tan constrained intrinsic (PR #94559)

@@ -2923,6 +2923,18 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, SetSqrtFPAccuracy(Call); return RValue::get(Call); } + +case Builtin::BItan: bob80905 wrote: What is the difference between `BItanf`

[clang] [llvm] [clang] Reland Add tanf16 builtin and support for tan constrained intrinsic (PR #94559)

bob80905 wrote: Should a test be added when the return type is a different float type than the first arg type? https://github.com/llvm/llvm-project/pull/94559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [HLSL][CMake] Add clangd and distribution settings (PR #92011)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/92011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/90809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/13] implement binding type error for t/cbuffers and

[clang] [llvm] [DirectX][DXIL] Set DXIL Version in DXIL target triple based on shader model version (PR #90809)

@@ -115,6 +115,30 @@ StringRef Triple::getArchName(ArchType Kind, SubArchType SubArch) { if (SubArch == AArch64SubArch_arm64e) return "arm64e"; break; + case Triple::dxil: +switch (SubArch) { +case Triple::NoSubArch: +case Triple::DXILSubArch_v1_0:

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/12] implement binding type error for t/cbuffers and

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -44,7 +44,7 @@ void foo2() { // expected-warning@+1 {{'register' attribute only applies to cbuffer/tbuffer and external global variables}} extern RWBuffer U2 : register(u5); } -// FIXME: expect-error once fix https://github.com/llvm/llvm-project/issues/57886. +//

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -44,7 +44,7 @@ void foo2() { // expected-warning@+1 {{'register' attribute only applies to cbuffer/tbuffer and external global variables}} extern RWBuffer U2 : register(u5); } -// FIXME: expect-error once fix https://github.com/llvm/llvm-project/issues/57886. +//

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/11] implement binding type error for t/cbuffers and

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/10] implement binding type error for t/cbuffers and

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -12154,6 +12154,8 @@ def err_hlsl_missing_semantic_annotation : Error< def err_hlsl_init_priority_unsupported : Error< "initializer priorities are not supported in HLSL">; +def err_hlsl_mismatching_register_resource_type_and_name: Error<"invalid register name prefix

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -0,0 +1,74 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// the below will cause an llvm unreachable, because RWBuffers don't have resource attributes yet +// NOT YET IMPLEMENTED : {{invalid register name prefix 'b'

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/9] implement binding type error for t/cbuffers and rwbuffers

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -0,0 +1,74 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// the below will cause an llvm unreachable, because RWBuffers don't have resource attributes yet +// NOT YET IMPLEMENTED : {{invalid register name prefix 'b'

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -0,0 +1,74 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// the below will cause an llvm unreachable, because RWBuffers don't have resource attributes yet +// NOT YET IMPLEMENTED : {{invalid register name prefix 'b'

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -0,0 +1,74 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o - -fsyntax-only %s -verify + +// the below will cause an llvm unreachable, because RWBuffers don't have resource attributes yet +// NOT YET IMPLEMENTED : {{invalid register name prefix 'b'

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/8] implement binding type error for t/cbuffers and rwbuffers

[clang] [NFC] Rename hlsl semantics to hlsl annotations (PR #89309)

https://github.com/bob80905 edited https://github.com/llvm/llvm-project/pull/89309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 converted_to_draft https://github.com/llvm/llvm-project/pull/86175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/7] implement binding type error for t/cbuffers and rwbuffers

[clang] [NFC] Rename hlsl semantics to hlsl annotations (PR #89309)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/89309 >From 58f7f1c7f99f29fea39b5bd83bb74d3770a6f985 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 18 Apr 2024 13:38:51 -0700 Subject: [PATCH 1/2] rename hlsl semantics to hlsl annotations ---

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/6] implement binding type error for t/cbuffers and rwbuffers

[clang] [NFC] Rename hlsl semantics to hlsl annotations (PR #89309)

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/89309 The attribute name "HLSLSemantics" is confusing, because semantics aren't always the annotation that are applied to specific variables. The name for this attribute needs to be less specific. This PR changes

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/5] implement binding type error for t/cbuffers and rwbuffers

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/5] implement binding type error for t/cbuffers and rwbuffers

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -482,15 +484,18 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema , bool IsROV) { return BuiltinTypeDeclBuilder(Decl) .addHandleMember() - .addDefaultHandleConstructor(S, RC) -

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/4] implement binding type error for t/cbuffers and rwbuffers

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

@@ -119,8 +119,10 @@ struct BuiltinTypeDeclBuilder { ResourceKind RK, bool IsROV) { if (Record->isCompleteDefinition()) return *this; -Record->addAttr(HLSLResourceAttr::CreateImplicit(Record->getASTContext(), -

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/3] implement binding type error for t/cbuffers and rwbuffers

[clang] Implement resource binding type prefix mismatch errors (PR #87578)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 1/2] implement binding type error for t/cbuffers and rwbuffers

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

@@ -0,0 +1,258 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/86175 >From 5e10b1e42a20a39c9a3d5ff332591713511832c8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 20 Mar 2024 13:24:07 -0700 Subject: [PATCH 1/8] make elemnetwise alias an alias of builtin alias ---

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 closed https://github.com/llvm/llvm-project/pull/85340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/21] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -4284,11 +4284,31 @@ bool CompilerInvocation::ParseLangArgs(LangOptions , ArgList , Diags.Report(diag::err_drv_hlsl_bad_shader_unsupported) << ShaderModel << T.getOSName() << T.str(); } +// Validate that if fnative-half-type is

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/20] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/19] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] enforce unsigned types for reversebits (PR #86720)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/86720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/18] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error< "HLSL code generation is unsupported for target '%0'">; def err_drv_hlsl_bad_shader_required_in_target : Error< "%select{shader model|Vulkan environment|shader stage}0 is required as

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -0,0 +1,20 @@ +// RUN: not %clang_dxc -enable-16bit-types -T cs_6_0 -HV 2016 %s 2>&1 | FileCheck -check-prefix=both_invalid %s +// RUN: not %clang_dxc -enable-16bit-types -T lib_6_4 -HV 2017 %s 2>&1 | FileCheck -check-prefix=HV_invalid %s +// RUN: not %clang_dxc

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/86175 >From 5e10b1e42a20a39c9a3d5ff332591713511832c8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 20 Mar 2024 13:24:07 -0700 Subject: [PATCH 1/7] make elemnetwise alias an alias of builtin alias ---

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/17] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/16] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/15] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3ba14cb55a85bf8bd0ed0cae43af657c6946acb8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 01/15] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] prevent generation of double intrinsics via the builtins (PR #86555)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/86555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/9] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [CMake][HLSL] Add SPIRV to target list for build (PR #86323)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/86323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/8] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions , ArgList , } else { llvm_unreachable("expected DXIL or SPIR-V target"); } + // validate that if fnative-half-type is given, that + // the language standard is at least

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions , ArgList , } else { llvm_unreachable("expected DXIL or SPIR-V target"); } + // validate that if fnative-half-type is given, that + // the language standard is at least

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/7] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/86175 >From 5e10b1e42a20a39c9a3d5ff332591713511832c8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 20 Mar 2024 13:24:07 -0700 Subject: [PATCH 1/6] make elemnetwise alias an alias of builtin alias ---

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/86175 >From 5e10b1e42a20a39c9a3d5ff332591713511832c8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 20 Mar 2024 13:24:07 -0700 Subject: [PATCH 1/5] make elemnetwise alias an alias of builtin alias ---

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/86175 >From 5e10b1e42a20a39c9a3d5ff332591713511832c8 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 20 Mar 2024 13:24:07 -0700 Subject: [PATCH 1/4] make elemnetwise alias an alias of builtin alias ---

[clang] Add clang_elementwise_builtin_alias (PR #86175)

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/86175 RFC: https://discourse.llvm.org/t/rfc-elementwise-attribute-in-clang-front-end/76342/9 The above RFC gives the motivation for this PR. In summary, this PR adds an attribute that will simplify / obliviate the

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/6] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/5] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/4] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/3] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/85340 >From 3cdcfa4e63550b9677c8ffe2f33eab85899b2c45 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 14 Mar 2024 17:04:12 -0700 Subject: [PATCH 1/2] add test --- .../clang/Basic/DiagnosticDriverKinds.td

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/85340 Previously, the clang compiler with the dxc driver would accept the -enable-16bit-types flag without checking to see if the required conditions are met for proper processing of the flag. Specifically,

[clang] [HLSL] Add diagnostic for enabling 16 bit types (PR #84537)

https://github.com/bob80905 closed https://github.com/llvm/llvm-project/pull/84537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 closed https://github.com/llvm/llvm-project/pull/83938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 01/14] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 01/13] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 01/12] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 01/11] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 01/10] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV",

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/7] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/8] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/7] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV",

[clang] [HLSL] Add diagnostic for enabling 16 bit types (PR #84537)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/84537 >From 55395c5c8a5b92e200aa2f1bf06774d20ac4afd9 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 8 Mar 2024 11:03:37 -0800 Subject: [PATCH 1/3] add check for enable 16 bit types ---

[clang] [HLSL] Add diagnostic for enabling 16 bit types (PR #84537)

@@ -243,6 +243,20 @@ HLSLToolChain::TranslateArgs(const DerivedArgList , StringRef BoundArch, // FIXME: add validation for enable_16bit_types should be after HLSL 2018 and bob80905 wrote: Yes, I'll remove the comment.

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList , StringRef BoundArch, A->claim(); continue; } +if (A->getOption().getID() == options::OPT_dxc_hlsl_version) { + // Translate -HV into -std for llvm + // depending on the

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/6] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [HLSL] Add diagnostic for enabling 16 bit types (PR #84537)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/84537 >From 8205c6894a4c1deeeb28c2520d16a56c3fcf21ea Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 8 Mar 2024 11:03:37 -0800 Subject: [PATCH] add check for enable 16 bit types ---

[clang] [HLSL] Add diagnostic for enabling 16 bit types (PR #84537)

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/84537 The -enable-16bit-types option was previously added without checking for a couple essential conditions. First, the target shader model must be greater than 6.2, and secondly, the hlsl version must be after

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList , StringRef BoundArch, A->claim(); continue; } +if (A->getOption().getID() == options::OPT_dxc_hlsl_version) { + // Translate -HV into -std for llvm + // depending on the

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV",

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV",

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/5] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -226,6 +226,28 @@ HLSLToolChain::TranslateArgs(const DerivedArgList , StringRef BoundArch, A->claim(); continue; } +if (A->getOption().getID() == options::OPT_dxc_hlsl_version) { + // Translate -HV into -std for llvm + // depending on the

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/83938 >From 7453ffdea39c624221c9696394bbd47be7eec662 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Mon, 4 Mar 2024 13:42:02 -0800 Subject: [PATCH 1/4] first try --- clang/include/clang/Driver/Options.td | 4

[clang] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/bob80905 created https://github.com/llvm/llvm-project/pull/83938 Previously, clang-dxc.exe would not recognize -HV as a valid argument to DXC, and would be unable to translate the argument to a legal clang argument. This PR implements a translation of the HV option and its

[clang] [llvm] [HLSL] implement the any intrinsic (PR #83903)

bob80905 wrote: @bogner or @llvm-beanz can you confirm? > I mention it because when I added the elementwise builtins (pow, abs, log, > etc), I had to add a release note for each one. I had made changes to > Builtins.def, so that could be the reason. It is possible that we also want > an

[clang] [llvm] [HLSL] implement the any intrinsic (PR #83903)

bob80905 wrote: I mention it because when I added the elementwise builtins (pow, abs, log, etc), I had to add a release note for each one. https://github.com/llvm/llvm-project/pull/83903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [HLSL] implement the any intrinsic (PR #83903)

bob80905 wrote: For these intrinsic addition changes, do we need to add a note to "clang\docs\ReleaseNotes.rst"? https://github.com/llvm/llvm-project/pull/83903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [HLSL] Expose `half` types and intrinsics always (PR #81782)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/81782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Add API documentation and annotations (PR #78635)

@@ -570,7 +716,13 @@ double4 sin(double4); //===--===// // sqrt builtins //===--===// + +/// \fn T sqrt(T Val) +/// \brief Returns the

[clang] [NFC] Add API documentation and annotations (PR #78635)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/78635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Add API documentation and annotations (PR #78635)

https://github.com/bob80905 edited https://github.com/llvm/llvm-project/pull/78635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Cleanup and sort hlsl_intrinsics.h (PR #72414)

https://github.com/bob80905 approved this pull request. https://github.com/llvm/llvm-project/pull/72414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] df5137e - [HLSL] add pow library function

Author: Joshua Batista Date: 2023-08-08T13:07:36-07:00 New Revision: df5137e984a607248cd31ed67aa3822e8ac2a083 URL: https://github.com/llvm/llvm-project/commit/df5137e984a607248cd31ed67aa3822e8ac2a083 DIFF:

[clang] e545392 - [HLSL] Add reversebits library function

Author: Joshua Batista Date: 2023-08-02T20:50:40-07:00 New Revision: e545392b1de304d3bf2776f671cb7327e335b90b URL: https://github.com/llvm/llvm-project/commit/e545392b1de304d3bf2776f671cb7327e335b90b DIFF:

[clang] 57f879c - clang: Add elementwise bitreverse builtin

Author: Joshua Batista Date: 2023-07-31T10:59:13-07:00 New Revision: 57f879cdd4c63189c569bdc1ce4e87e7342eea46 URL: https://github.com/llvm/llvm-project/commit/57f879cdd4c63189c569bdc1ce4e87e7342eea46 DIFF:

  1   2   >