[clang] [flang] [lld] [flang] Generate main only when a Fortran program statement is present (PR #89938)

kkwli wrote: This change will also break backward compatibility that the old object file that contain `main` can no longer use the new compiler to link with other objects. I think we can put a warning in the release note or something like that to warn users.

[clang] [flang] [lld] [flang] Generate main only when a Fortran program statement is present (PR #89938)

@@ -24,6 +24,7 @@ add_flang_library(FIRBuilder Runtime/Inquiry.cpp Runtime/Intrinsics.cpp Runtime/Numeric.cpp + Runtime/Main.cpp kkwli wrote: I think this list is in alphabetical order? https://github.com/llvm/llvm-project/pull/89938

[clang] [flang] [lld] [flang] Generate main only when a Fortran program statement is present (PR #89938)

https://github.com/kkwli approved this pull request. LG https://github.com/llvm/llvm-project/pull/89938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [lld] [flang] Generate main only when a Fortran program statement is present (PR #89938)

https://github.com/kkwli edited https://github.com/llvm/llvm-project/pull/89938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Frontend] Implement printing defined macros via -dM (PR #87627)

kkwli wrote: @kparzysz Is it supposed to also print the predefined macros? Or only the user-defined macros? https://github.com/llvm/llvm-project/pull/87627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[flang] [clang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

https://github.com/kkwli approved this pull request. LG. Thanks https://github.com/llvm/llvm-project/pull/79016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Allow explicit specification of -lFortran_main (PR #78152)

kkwli wrote: > > How would `flang-new -fno-fortran-main t.f -lFortran_main` work? > > This works because I only remove `-lFortran_main` when it is going to be > added implicitly. `-fno-fortran-main` ensures that we never reach this > branch. I've added a test to verify this. I don't know

[clang] [flang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

kkwli wrote: > My plan is the following: > > * Try to fix isysroot.f90 test by making DEFAULT_SYSROOT a LIT "feature". > > * Keep using -isysroot on Flang's tests, on Darwin, as it seems to be the > recommended way to select an SDK. > > * Add support for -sysroot. > > > Does

[flang] [clang] [flang][driver] Allow explicit specification of -lFortran_main (PR #78152)

kkwli wrote: > > How would `flang-new -fno-fortran-main t.f -lFortran_main` work? > > Good question. This won't work with this patch but currently should work. > I'll have to fix this. > > Do you agree that `flang-new -lFortran_main` is something we want to make > work? In my opinion, we

[clang] [flang] [flang][driver] Allow explicit specification of -lFortran_main (PR #78152)

kkwli wrote: How would `flang-new -fno-fortran-main t.f -lFortran_main` work? https://github.com/llvm/llvm-project/pull/78152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] Add support for -isysroot in the frontend (PR #77365)

kkwli wrote: If the compiler is built with `DEFAULT_SYSROOT`, the `-isysroot` option is ignored. Is that the expected behavior? My local MacOS build (with `-DDEFAULT_SYSROOT="$(xcrun --show-sdk-path)"`) has `isysroot.f90` failed. https://github.com/llvm/llvm-project/pull/77365

[clang-tools-extra] [flang] [llvm] [Flang] make ppc unsupported for x86_64 test case (NFC) (PR #73903)

https://github.com/kkwli approved this pull request. LG. Thanks https://github.com/llvm/llvm-project/pull/73903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [llvm] [Flang] make ppc unsupported for x86_64 test case (NFC) (PR #73903)

@@ -7,7 +7,7 @@ ! ! This test is for x86_64, where exponent-letter 'q' is for ! 10-byte extended precision -! UNSUPPORTED: system-windows +! UNSUPPORTED: system-windows, system-aix kkwli wrote: Ok https://github.com/llvm/llvm-project/pull/73903

[llvm] [clang-tools-extra] [flang] [Flang] make ppc unsupported for x86_64 test case (NFC) (PR #73903)

@@ -7,7 +7,7 @@ ! ! This test is for x86_64, where exponent-letter 'q' is for ! 10-byte extended precision -! UNSUPPORTED: system-windows +! UNSUPPORTED: system-windows, system-aix kkwli wrote: Why not `target=powerpc{{.*}}` as PPC is non-x86_64 regardless of

[clang] 00769d6 - [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types

Author: Kelvin Li Date: 2023-08-04T17:11:30-04:00 New Revision: 00769d69fbaa39ecdcbbaf826a35ad999bdc951e URL: https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e DIFF: https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e.diff

[clang] 8ea4aed - [OpenMP] Add search path for llvm-strip

Author: Kelvin Li Date: 2022-02-04T22:15:14-05:00 New Revision: 8ea4aed50a9f84d9617219ccc936c005c5f31c24 URL: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24 DIFF: https://github.com/llvm/llvm-project/commit/8ea4aed50a9f84d9617219ccc936c005c5f31c24.diff

[clang] ac43033 - [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

Author: Kelvin Li Date: 2020-02-03T18:30:36-05:00 New Revision: ac430336318a1abe6e4726e8df49ee0e6b779691 URL: https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691 DIFF: https://github.com/llvm/llvm-project/commit/ac430336318a1abe6e4726e8df49ee0e6b779691.diff

[clang] 427ffa2 - [OpenMP] diagnose zero-length array section in the depend clause

Author: Kelvin Li Date: 2020-01-03T11:55:37-05:00 New Revision: 427ffa2cdbbc7337d903ba71823a7830fa92568d URL: https://github.com/llvm/llvm-project/commit/427ffa2cdbbc7337d903ba71823a7830fa92568d DIFF: https://github.com/llvm/llvm-project/commit/427ffa2cdbbc7337d903ba71823a7830fa92568d.diff

[clang] 0c7a1c0 - [OPENMP] [DOCS] correct status for use_device_addr clause

Author: Kelvin Li Date: 2019-11-22T15:32:40-05:00 New Revision: 0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 URL: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 DIFF: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384.diff

[clang] 9f10cc2 - [OPENMP] [DOCS] fix section formatting issues [NFC]

Author: Kelvin Li Date: 2019-11-06T22:03:09-05:00 New Revision: 9f10cc2d124c275f2e7a6764e168f6b75527e78f URL: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f DIFF: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f.diff

r353186 - [OPENMP] issue error messages for multiple teams contructs in a target construct

Author: kli Date: Tue Feb 5 08:43:00 2019 New Revision: 353186 URL: http://llvm.org/viewvc/llvm-project?rev=353186=rev Log: [OPENMP] issue error messages for multiple teams contructs in a target construct The fix is to issue error messages if there are more than one teams construct inside a

r351580 - [OPENMP][DOCS] Release notes/OpenMP support updates, NFC.

Author: kli Date: Fri Jan 18 11:57:37 2019 New Revision: 351580 URL: http://llvm.org/viewvc/llvm-project?rev=351580=rev Log: [OPENMP][DOCS] Release notes/OpenMP support updates, NFC. Differential Revision: https://reviews.llvm.org/D56733 Modified: cfe/trunk/docs/OpenMPSupport.rst

r349551 - [OPENMP] parsing and sema support for 'close' map-type-modifier

Author: kli Date: Tue Dec 18 14:18:41 2018 New Revision: 349551 URL: http://llvm.org/viewvc/llvm-project?rev=349551=rev Log: [OPENMP] parsing and sema support for 'close' map-type-modifier A map clause with the close map-type-modifier is a hint to prefer that the variables are mapped using a

r347723 - [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp (NFC)

Author: kli Date: Tue Nov 27 16:51:08 2018 New Revision: 347723 URL: http://llvm.org/viewvc/llvm-project?rev=347723=rev Log: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp (NFC) The flag ColonExpected is not changed after being initialized to false at declaration. Patch by

r347411 - [OPENMP] Refactor code for parsing omp declare target directive and its clauses (NFC)

Author: kli Date: Wed Nov 21 12:15:57 2018 New Revision: 347411 URL: http://llvm.org/viewvc/llvm-project?rev=347411=rev Log: [OPENMP] Refactor code for parsing omp declare target directive and its clauses (NFC) This patch refactor the code for parsing omp declare target directive and its

r347408 - [OPENMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC)

Author: kli Date: Wed Nov 21 11:38:53 2018 New Revision: 347408 URL: http://llvm.org/viewvc/llvm-project?rev=347408=rev Log: [OPENMP] remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp (NFC) Whether the map type modifier is specified or not, the flag MapTypeModifierSpecified

r347405 - [OPENMP] Support relational-op != (not-equal) as one of the canonical

Author: kli Date: Wed Nov 21 11:10:48 2018 New Revision: 347405 URL: http://llvm.org/viewvc/llvm-project?rev=347405=rev Log: [OPENMP] Support relational-op != (not-equal) as one of the canonical forms of random access iterator In OpenMP 4.5, only 4 relational operators are supported: <, <=,

r343063 - [OPENMP] Add support for OMP5 requires directive + unified_address clause

Author: kli Date: Tue Sep 25 21:28:39 2018 New Revision: 343063 URL: http://llvm.org/viewvc/llvm-project?rev=343063=rev Log: [OPENMP] Add support for OMP5 requires directive + unified_address clause Add support for OMP5.0 requires directive and unified_address clause. Patches to follow will

r342322 - [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer (NFC)

Author: kli Date: Sat Sep 15 06:54:15 2018 New Revision: 342322 URL: http://llvm.org/viewvc/llvm-project?rev=342322=rev Log: [OPENMP] Move OMPClauseReader/Writer classes to ASTReader/Writer (NFC) Move declarations for OMPClauseReader, OMPClauseWriter to ASTReader.h and ASTWriter.h and move

r341766 - [OpenMP] Add support for nested 'declare target' directives

Author: kli Date: Sun Sep 9 19:07:09 2018 New Revision: 341766 URL: http://llvm.org/viewvc/llvm-project?rev=341766=rev Log: [OpenMP] Add support for nested 'declare target' directives Add the capability to nest multiple declare target directives - including header files within a declare target

r320521 - [OpenMP] Diagnose function name on the link clause

Author: kli Date: Tue Dec 12 12:08:12 2017 New Revision: 320521 URL: http://llvm.org/viewvc/llvm-project?rev=320521=rev Log: [OpenMP] Diagnose function name on the link clause This patch is to add diagnose when a function name is specified on the link clause. According to the OpenMP spec, only

r320506 - Add --cuda-path to mock a CUDA Toolkit installation to avoid

Author: kli Date: Tue Dec 12 10:33:39 2017 New Revision: 320506 URL: http://llvm.org/viewvc/llvm-project?rev=320506=rev Log: Add --cuda-path to mock a CUDA Toolkit installation to avoid unexpected error messages for incompatibility between the default SM level and the support in the installed

r319458 - [OpenMP] Diagnose undeclared variables on declare target clause

Author: kli Date: Thu Nov 30 10:52:06 2017 New Revision: 319458 URL: http://llvm.org/viewvc/llvm-project?rev=319458=rev Log: [OpenMP] Diagnose undeclared variables on declare target clause Clang asserts on undeclared variables on the to or link clause in the declare target directive. The patch

r291583 - [OpenMP] Remove outdated comments. NFC.

Author: kli Date: Tue Jan 10 12:57:07 2017 New Revision: 291583 URL: http://llvm.org/viewvc/llvm-project?rev=291583=rev Log: [OpenMP] Remove outdated comments. NFC. Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def URL:

r291260 - [OpenMP] fix typo - the standalone 'distribute' pragma should be 'teams distribute' pragma

Author: kli Date: Fri Jan 6 12:49:49 2017 New Revision: 291260 URL: http://llvm.org/viewvc/llvm-project?rev=291260=rev Log: [OpenMP] fix typo - the standalone 'distribute' pragma should be 'teams distribute' pragma Modified: cfe/trunk/test/OpenMP/teams_distribute_collapse_messages.cpp

r290813 - [OpenMP] Add test cases for the proc_bind and schedule clauses with 'teams distribute parallel for' pragma.

Author: kli Date: Mon Jan 2 10:42:11 2017 New Revision: 290813 URL: http://llvm.org/viewvc/llvm-project?rev=290813=rev Log: [OpenMP] Add test cases for the proc_bind and schedule clauses with 'teams distribute parallel for' pragma. https://reviews.llvm.org/D28205 Added:

r290795 - Fix typo in test case. NFC

Author: kli Date: Sat Dec 31 17:36:47 2016 New Revision: 290795 URL: http://llvm.org/viewvc/llvm-project?rev=290795=rev Log: Fix typo in test case. NFC Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_collapse_messages.cpp Modified:

r290673 - Fix format. NFC

Author: kli Date: Wed Dec 28 11:57:07 2016 New Revision: 290673 URL: http://llvm.org/viewvc/llvm-project?rev=290673=rev Log: Fix format. NFC Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp URL:

r289989 - [OpenMP] support the 'is_device_ptr' clause with 'target parallel' pragma

Author: kli Date: Fri Dec 16 14:50:46 2016 New Revision: 289989 URL: http://llvm.org/viewvc/llvm-project?rev=289989=rev Log: [OpenMP] support the 'is_device_ptr' clause with 'target parallel' pragma This patch is to add support of the 'is_device_ptr' clause in the 'target parallel' pragma.

r289897 - Fix typo in error messages. NFC.

Author: kli Date: Thu Dec 15 18:15:54 2016 New Revision: 289897 URL: http://llvm.org/viewvc/llvm-project?rev=289897=rev Log: Fix typo in error messages. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_loop_messages.cpp Modified:

r289836 - Fix typo in comment. NFC.

Author: kli Date: Thu Dec 15 11:55:32 2016 New Revision: 289836 URL: http://llvm.org/viewvc/llvm-project?rev=289836=rev Log: Fix typo in comment. NFC. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp URL:

r289657 - Fix assert message. NFC.

Author: kli Date: Wed Dec 14 09:39:58 2016 New Revision: 289657 URL: http://llvm.org/viewvc/llvm-project?rev=289657=rev Log: Fix assert message. NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

r288862 - [OpenMP] Fix typo in the run command in the test case. NFC.

Author: kli Date: Tue Dec 6 17:18:06 2016 New Revision: 288862 URL: http://llvm.org/viewvc/llvm-project?rev=288862=rev Log: [OpenMP] Fix typo in the run command in the test case. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_ast_print.cpp Modified:

r288838 - [OpenMP] Fix typo in the test case. NFC.

Author: kli Date: Tue Dec 6 12:50:20 2016 New Revision: 288838 URL: http://llvm.org/viewvc/llvm-project?rev=288838=rev Log: [OpenMP] Fix typo in the test case. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_if_messages.cpp Modified:

Re: [PATCH] D23528: [OpenMP] Sema and parsing for 'teams distribute simd' pragma

The failure cannot be reproduced. I re-apply r279045. Committed revision 285066. Thanks, Kelvin On Thu, Aug 18, 2016 at 5:46 AM, Diana Picus wrote: > Hi, > > I had to revert this (r279045) because it breaks some of our buildbots > (e.g. > clang-cmake-aarch64-quick,

[PATCH] D24615: [OpenMP] clang doesnt diagnose if there is a lexical block around a for stmt for OpenMP loops. It is technically not allowed in the OpenMP standard

kkwli0 added a comment. Should we issue a warning message in this case? https://reviews.llvm.org/D24615 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma

kkwli0 added a comment. Thanks. I will update it when I commit the patch. https://reviews.llvm.org/D23189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r276726 - [OpenMP] diagnose orphaned teams construct

Author: kli Date: Mon Jul 25 23:32:50 2016 New Revision: 276726 URL: http://llvm.org/viewvc/llvm-project?rev=276726=rev Log: [OpenMP] diagnose orphaned teams construct The OpenMP spec mandates that 'a teams construct must be contained within a target construct'. Currently, this scenario is not

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

kkwli0 added a comment. Will add the braces. Thanks. https://reviews.llvm.org/D22785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22785: [OpenMP] diagnose orphaned teams construct

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. The spec mandates that 'a teams construct must be contained within a target construct'. Currently, this scenario is not diagnosed. This patch

r276167 - [OpenMP] Ignore parens in atomic capture

Author: kli Date: Wed Jul 20 14:41:17 2016 New Revision: 276167 URL: http://llvm.org/viewvc/llvm-project?rev=276167=rev Log: [OpenMP] Ignore parens in atomic capture Clang misdiagnoses atomic captures cases that contains parens. i.e. int v, int *p; #pragma omp atomic capture { v = (*p);

r275926 - [OpenMP] Fix incorrect diagnostics in map clause

Author: kli Date: Mon Jul 18 17:49:16 2016 New Revision: 275926 URL: http://llvm.org/viewvc/llvm-project?rev=275926=rev Log: [OpenMP] Fix incorrect diagnostics in map clause Having the following code pattern will result in incorrect diagnostic int main() { int arr[10]; #pragma omp target data

r275805 - [OpenMP] update test cases for -std=c++11 compile

Author: kli Date: Mon Jul 18 11:09:53 2016 New Revision: 275805 URL: http://llvm.org/viewvc/llvm-project?rev=275805=rev Log: [OpenMP] update test cases for -std=c++11 compile target_parallel_for_simd_collapse_messages.cpp and target_parallel_for_simd_ordered_messages.cpp give different

Re: [PATCH] D22417: [OpenMP] update test cases for -std=c++11 compile

kkwli0 added a subscriber: cfe-commits. kkwli0 added a comment. Add cfe-commits https://reviews.llvm.org/D22417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

kkwli0 added a comment. I update the test cases in https://reviews.llvm.org/D22417. Repository: rL LLVM https://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

I will take a look and put up a patch for it. Kelvin On Fri, Jul 15, 2016 at 2:46 AM, Alexey Bataev wrote: > Kelvin, > Please look at these messages and fix the tests. Or tell me and I will > fix them > > Best regards, > Alexey Bataev > = > Software Engineer >

[PATCH] D22384: [OpenMP] add check for both simdlen and safelen clauses specified

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. This patch adds the check for specifying both simdlen and safelen clauses on the 'distribute simd' or 'distribute parallel for simd' constructs.

r275323 - [OpenMP] remove duplicate code in ActOnOpenMPRegionStart

Author: kli Date: Wed Jul 13 16:51:49 2016 New Revision: 275323 URL: http://llvm.org/viewvc/llvm-project?rev=275323=rev Log: [OpenMP] remove duplicate code in ActOnOpenMPRegionStart This patch is to remove duplicate code in ActOnOpenMPRegionStart. (NFC) Differential Revision:

r275315 - [OpenMP] add more tests for 'distribute parallel for simd' pragma

Author: kli Date: Wed Jul 13 15:40:32 2016 New Revision: 275315 URL: http://llvm.org/viewvc/llvm-project?rev=275315=rev Log: [OpenMP] add more tests for 'distribute parallel for simd' pragma This patch is to add two additional tests for testing 'distribute parallel for simd' pragma with

r275306 - [OpenMP] add more tests for 'distribute simd' pragma

Author: kli Date: Wed Jul 13 14:16:56 2016 New Revision: 275306 URL: http://llvm.org/viewvc/llvm-project?rev=275306=rev Log: [OpenMP] add more tests for 'distribute simd' pragma This patch is to add two additional tests for testing 'distribute simd' pragma with disallowed clauses and loops.

[PATCH] D22176: [OpenMP] add more tests for 'distribute simd' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, hfinkel, arpith-jacob. kkwli0 added a subscriber: cfe-commits. This patch is to add two additional tests for testing 'distribute simd' pragma with disallowed clauses and loops. http://reviews.llvm.org/D22176

[PATCH] D22169: [OpenMP] add more tests for 'distribute parallel for simd' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. This patch is to add two additional tests for testing 'distribute parallel for simd' pragma with disallowed clauses and loops.

r274577 - [OpenMP] remove outdated comment (NFC)

Author: kli Date: Tue Jul 5 16:38:53 2016 New Revision: 274577 URL: http://llvm.org/viewvc/llvm-project?rev=274577=rev Log: [OpenMP] remove outdated comment (NFC) Modified: cfe/trunk/lib/Basic/OpenMPKinds.cpp Modified: cfe/trunk/lib/Basic/OpenMPKinds.cpp URL:

r274352 - [OpenMP] Issue warning if a simd construct nested inside another simd

Author: kli Date: Fri Jul 1 09:30:25 2016 New Revision: 274352 URL: http://llvm.org/viewvc/llvm-project?rev=274352=rev Log: [OpenMP] Issue warning if a simd construct nested inside another simd construct Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:11377 @@ +11376,3 @@ +// item should be a pointer or array +if (!Type.getNonReferenceType()->isPointerType()) { + Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer) sfantao wrote: >

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

kkwli0 closed this revision. kkwli0 added a comment. At revision: 273908 http://reviews.llvm.org/D21617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273908 - [OpenMP] Diagnose missing cases of statements between target and teams directives

Author: kli Date: Mon Jun 27 14:15:43 2016 New Revision: 273908 URL: http://llvm.org/viewvc/llvm-project?rev=273908=rev Log: [OpenMP] Diagnose missing cases of statements between target and teams directives Clang fails to diagnose cases such as #pragma omp target while(0) { #pragma omp

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

kkwli0 added a comment. The changes look fine to me. Thanks. http://reviews.llvm.org/D21617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273369 - [OpenMP] Add the depend clause to target update construct (sema and parsing)

Author: kli Date: Tue Jun 21 22:10:32 2016 New Revision: 273369 URL: http://llvm.org/viewvc/llvm-project?rev=273369=rev Log: [OpenMP] Add the depend clause to target update construct (sema and parsing) Differential Revision: http://reviews.llvm.org/D21532 Added:

r273190 - [OpenMP] Add the nowait clause to target update construct.

Author: kli Date: Mon Jun 20 14:16:34 2016 New Revision: 273190 URL: http://llvm.org/viewvc/llvm-project?rev=273190=rev Log: [OpenMP] Add the nowait clause to target update construct. Differential Revision: http://reviews.llvm.org/D21477 Added:

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 added a comment. Patch for the to and from clauses is in http://reviews.llvm.org/D18488. http://reviews.llvm.org/D15944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 added a comment. Thanks for the review. As request, I will split this patch into two: 1. to and from clause (without test cases) 2. target update directive (with test cases) I will use this review for the target update directive. http://reviews.llvm.org/D15944

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 updated this revision to Diff 50774. kkwli0 marked 5 inline comments as done. kkwli0 added a comment. Addressed the comments from the last review: added assert calls and outline the common code in ActOnOpenMPToClause, ActOnOpenMPFromClause and ActOnOpenMPMapClause to a static function.

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 updated this revision to Diff 50024. kkwli0 marked 2 inline comments as done. kkwli0 added a comment. I rebase the patch to the latest trunk and make use of the infrastructure form parsing and sema. http://reviews.llvm.org/D15944 Files: include/clang-c/Index.h

Re: [PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 marked 3 inline comments as done. Comment at: include/clang/AST/OpenMPClause.h:3196 @@ -3195,1 +3195,3 @@ +/// \brief This represents clause 'from' in the '#pragma omp ...' +/// directives. ABataev wrote: > New clauses must be added in separate patches

[PATCH] D15944: [OpenMP] Parsing and sema support for target update directive

kkwli0 created this revision. kkwli0 added reviewers: ABataev, rsmith, fraggamuffin, sfantao, hfinkel, carlo.bertolli. kkwli0 added a subscriber: cfe-commits. This patch is to add parsing and sema support for target update directive. It also includes the to and from clause as it is required to

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

kkwli0 added inline comments. Comment at: include/clang/AST/OpenMPClause.h:708 @@ -707,3 +707,3 @@ public: - /// \brief Build 'schedule' clause with schedule kind \a Kind and chunk size - /// expression \a ChunkSize. + /// \brief Build 'dist_schedule' clause with schedule

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

kkwli0 closed this revision. kkwli0 added a comment. Committed revision 254207. http://reviews.llvm.org/D15029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254207 - [OpenMP] Parsing and sema support for thread_limit clause.

Author: kli Date: Fri Nov 27 12:47:36 2015 New Revision: 254207 URL: http://llvm.org/viewvc/llvm-project?rev=254207=rev Log: [OpenMP] Parsing and sema support for thread_limit clause. http://reviews.llvm.org/D15029 Added: cfe/trunk/test/OpenMP/teams_thread_limit_messages.cpp Modified:

[PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

kkwli0 created this revision. kkwli0 added reviewers: ABataev, hfinkel, sfantao, fraggamuffin, rsmith. kkwli0 added a subscriber: cfe-commits. This patch is to add parsing and sema support for thread_limit clause. http://reviews.llvm.org/D15029 Files: include/clang/AST/OpenMPClause.h

Re: [PATCH] D15029: [OpenMP] Parsing and sema support for thread_limit clause

kkwli0 added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5220-5242 @@ -5216,2 +5219,25 @@ +static bool IsNonNegativeIntegerValue(Expr *, Sema , + OpenMPClauseKind CKind) { + if (!ValExpr->isTypeDependent() &&

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 closed this revision. kkwli0 added a comment. Committed revision 253849. Committed revision 253850. http://reviews.llvm.org/D14134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r253849 - [OpenMP] Parsing and sema support for map clause

Author: kli Date: Sun Nov 22 23:32:03 2015 New Revision: 253849 URL: http://llvm.org/viewvc/llvm-project?rev=253849=rev Log: [OpenMP] Parsing and sema support for map clause http://reviews.llvm.org/D14134 Modified: cfe/trunk/include/clang/AST/DataRecursiveASTVisitor.h

r253850 - [OpenMP] Parsing and sema support for map clause - add test case

Author: kli Date: Sun Nov 22 23:36:37 2015 New Revision: 253850 URL: http://llvm.org/viewvc/llvm-project?rev=253850=rev Log: [OpenMP] Parsing and sema support for map clause - add test case http://reviews.llvm.org/D14134 Added: cfe/trunk/test/OpenMP/target_map_messages.cpp Added:

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 marked 6 inline comments as done. kkwli0 added a comment. Address the comments and will post an updated patch. http://reviews.llvm.org/D14134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 updated this revision to Diff 40537. kkwli0 added a comment. Updated patch with the 2nd review comments addressed. http://reviews.llvm.org/D14134 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h

Re: [PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 added a comment. Ping http://reviews.llvm.org/D14134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14134: [OpenMP] Parsing and sema support for map clause

kkwli0 created this revision. kkwli0 added reviewers: ABataev, rsmith, hfinkel, sfantao, fraggamuffin. kkwli0 added a subscriber: cfe-commits. This patch is to add parsing and sema support for map clause. This includes the new map types and the map type modifier added in OpenMP 4.5.

r247503 - Test commit.

Author: kli Date: Sat Sep 12 08:35:31 2015 New Revision: 247503 URL: http://llvm.org/viewvc/llvm-project?rev=247503=rev Log: Test commit. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL: