https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/91689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/91689
>From 3b0967e0a8f564d761ea10858854776ede396bdf Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 9 May 2024 21:21:22 -0400
Subject: [PATCH 1/2] [clang][Driver] Fix enabling strict alising by default
when the
https://github.com/MaxEW707 approved this pull request.
LGTM!
@xbjfk Let us know if you require one of us to commit on your behalf due to not
having commit access.
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/91689
>From b43a6302009b9a11ef672f3bd01e10342102de44 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 9 May 2024 21:21:22 -0400
Subject: [PATCH 1/2] [clang][Driver] Fix enabling strict alising by default
when the
MaxEW707 wrote:
@huangqinjin Try rebasing you changes on top of latest main. Looks like Windows
CI is passing there including flang commits which are the source files that are
causing msvc to run out of heap space.
https://github.com/llvm/llvm-project/pull/89772
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/91689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8065,6 +8069,9 @@ void Clang::AddClangCLArgs(const ArgList , types::ID
InputType,
CmdArgs.push_back("-fno-wchar");
}
+ if (!types::isCXX(InputType) && Args.hasArg(options::OPT_fms_define_stdc))
+ CmdArgs.push_back("-fms-define-stdc");
MaxEW707
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2934,6 +2934,10 @@ def fms_compatibility : Flag<["-"],
"fms-compatibility">, Group,
Visibility<[ClangOption, CC1Option, CLOption]>,
HelpText<"Enable full Microsoft Visual C++ compatibility">,
MarshallingInfoFlag>;
+def fms_define_stdc : Flag<["-"],
@@ -291,6 +291,7 @@ LANGOPT(HIPStdParInterposeAlloc, 1, 0, "Replace allocations
/ deallocations with
LANGOPT(OpenACC , 1, 0, "OpenACC Enabled")
+LANGOPT(MSVCEnableStdcMacro , 1, 0, "Define __STDC__ with
'-fms-compatability'")
MaxEW707 wrote:
MaxEW707 wrote:
@huangqinjin The error is "fatal error C1060: compiler is out of heap space"
which is unrelated.
I haven't figured out how to resend the event to trigger a build retry without
pushing an empty commit.
I usually just do `git commit -m "rebuild" --allow-empty` and then push that
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/92477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/92477
>From 139c51074b43623ea7b206080056823e216fedac Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 16 May 2024 21:03:46 -0400
Subject: [PATCH 1/2] [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling
---
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/92477
>From 7b73c2b907b09ec87197e9613c4abc27ff52083b Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Thu, 16 May 2024 21:03:46 -0400
Subject: [PATCH 1/2] [clang-cl][AST] Fix auto NTTP MSVC 1920+ mangling
---
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/92477
https://godbolt.org/z/G1K8Wszn9 for reference.
Starting with MSVC 1920+, VS2019, C++17 auto NTTP now adds `M ` to the
mangled name to avoid name collisions with different deduced types.
This PR fixes pointers.
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/91689
I noticed this when changing some of my local projects to use my preferred
driver mode, GCC, instead of the CL driver mode.
>From looking at the rest of code and from my own understanding the driver mode
>is
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/90547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/6] [clang][CodeGen] Fix MS ABI for classes with non static
data
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/5] [clang][CodeGen] Fix MS ABI for classes with non static
data
@@ -1131,13 +1132,18 @@ static bool isTrivialForMSVC(const CXXRecordDecl *RD,
QualType Ty,
return false;
if (RD->hasNonTrivialCopyAssignment())
return false;
+ if (RD->needsImplicitCopyAssignment() && !RD->hasSimpleCopyAssignment())
MaxEW707 wrote:
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/90547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1131,13 +1132,18 @@ static bool isTrivialForMSVC(const CXXRecordDecl *RD,
QualType Ty,
return false;
if (RD->hasNonTrivialCopyAssignment())
return false;
+ if (RD->needsImplicitCopyAssignment() && !RD->hasSimpleCopyAssignment())
MaxEW707 wrote:
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/90547
>From f404db44d3770cdb8ac5123c16c0b04314eda698 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Mon, 29 Apr 2024 22:09:52 -0400
Subject: [PATCH 1/4] [clang][CodeGen] Fix MS ABI for classes with non static
data
MaxEW707 wrote:
> Maybe we should just be testing if the copy-assignment operator is deleted?
> For reference, MSVC also returns the following indirectly:
>
> ```
> struct Test
> {
> int x;
> Test& operator=(const Test&) = delete;
> };
> Test foo();
> Test test(Test x)
> {
> return
@@ -1144,11 +1167,13 @@ bool MicrosoftCXXABI::classifyReturnType(CGFunctionInfo
) const {
if (!RD)
return false;
- bool isTrivialForABI = RD->canPassInRegisters() &&
- isTrivialForMSVC(RD, FI.getReturnType(), CGM);
-
// MSVC always returns
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/90547
https://godbolt.org/z/verKj4cnj for reference.
https://godbolt.org/z/z3W9v7o4n for reference.
For global functions and static methods the MSVC ABI returns structs/classes
with a reference type non static data
MaxEW707 wrote:
> Thank you for polishing this corner of the driver interface! It's interesting
> that they have an alternative separate spelling. I always felt like the
> /Fopath.cpp pattern was a bit unreadable.
Thanks for the review. I will need you to commit on my behalf. I think its
https://github.com/MaxEW707 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/88101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
CC @rnk
https://github.com/llvm/llvm-project/pull/88216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/88216
Tested locally against msvc 1939.
MSVC supports the colon form of various options that take a path even though
that isn't documented for all options on MSDN.
I added the colon form for all supported msvc
https://github.com/MaxEW707 approved this pull request.
https://github.com/llvm/llvm-project/pull/87725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
LGTM.
>From memory, its been a while since I've had to ship on ARM64EC, all instances
>of `__vectorcall` are supposed to be rejected by msvc. That also aligns with
>the `__vectorcall` docs on MSDN.
I am not sure what clang's policy is with potentially allowing code that
https://github.com/MaxEW707 approved this pull request.
https://github.com/llvm/llvm-project/pull/87717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
I didn't realize ARM64EC was supported by clang.
You are missing one `#if defined(__x86_64__) && !defined(__arm64ec__)` check
here,
https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/intrin0.h#L47.
Doesn't appear to be anyway to comment on lines that aren't in
@@ -413,6 +413,7 @@ static __inline__ void __DEFAULT_FN_ATTRS
__writecr3(unsigned __INTPTR_TYPE__ __cr3_val) {
__asm__ ("mov {%0, %%cr3|cr3, %0}" : : "r"(__cr3_val) : "memory");
}
+#endif
MaxEW707 wrote:
Nice catch. We should probably also ifdef these
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/84651
>From 28cbaad3c16e985306c7b977cb7d9e8e89c39a07 Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Sat, 9 Mar 2024 15:40:52 -0500
Subject: [PATCH 1/2] Fix
@@ -1,4 +1,5 @@
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin10 -emit-llvm -o - |
FileCheck %s
+// RUN: %clang_cc1 %s -triple=x86_64-pc-linux-gnu -emit-llvm -o - | FileCheck
%s
MaxEW707 wrote:
Fair point since they are both Itanium ABI. I'll remove the
MaxEW707 wrote:
@rnk for review.
LGTM!
>From experience with msvc the docs are very much outdated. For example almost
>all path options accept the `:` form.
For example `/Fd:` is valid even though the msdn docs do not state that.
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/84651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
@AaronBallman @efriedma-quic
Pinging you two for a review. Looking through the history of `CGClass.cpp` you
guys appear to be the common reviewers and the CodeOwners file didn't have any
information for who owns `CodeGen`.
Feel free to add anyone who may be a better fit.
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/84651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/84651
Hit this when trying upgrade an old project of mine. I couldn't find a
corresponding existing issue for this when spelunking the open issues here on
github.
Thankfully I can work-around it today with the
MaxEW707 wrote:
Friendly reminder that I require someone to commit on my behalf since I do not
have write access :).
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
Thanks all for the review :).
I will need one of you to commit on my behalf since I do not have write access.
https://github.com/llvm/llvm-project/pull/76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/76646
>From a081f8266f24405523e6d283318bd898fd2d376a Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Sat, 30 Dec 2023 22:00:38 -0500
Subject: [PATCH 1/4] Warn on self move
MaxEW707 wrote:
Just want to say thanks for everyone taking the time to review the PR and
providing feedback :).
Looking forward to using this in the next release of clang-cl.
> I'm a bit worried that we don't have any test coverage for this file to begin
> with, so it's a bit hard to
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,26 @@
+/* === vadefs.h ---===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier:
MaxEW707 wrote:
I will need someone to commit on my behalf since I do not have write access.
> lgtm, and good to land provided you do a quick re-check to confirm that this
> doesn't tank compile times now with that part included. Thanks!
The include times below are done with the following
MaxEW707 wrote:
Ping
Wondering if there is anything else required of me to progress this PR forward.
Let me know :).
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
Ping
https://github.com/llvm/llvm-project/pull/76646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
> It's not ready, but I have a draft for a much more general attribute: #78071
I was playing around with your draft PR and I do prefer your solution over mine.
It will even help to cleanup my custom `xmmintrin.h` header that we have to
reduce include times from SSE headers.
MaxEW707 wrote:
> #include
>
>clang-cl 16 frontend took ~190ms to parse those 3 headers. intrin.h took ~32ms
>to parse.
>
>clang-cl built with this PR frontend took ~1368ms to parse. intrin.h took
>~969ms to parse. Most of that time is from as expected.
>intrin0.h took ~2ms to parse.
Did
MaxEW707 wrote:
> Users (Chromium included) use recent versions of Clang that are not vendored
> by Microsoft. Users can also use the LLVM OSS releases. I think most users
> probably won't notice the compile time regression, and it will silently go
> away the next time the update MSVC, but if
MaxEW707 wrote:
> I would like some measurements so we can compare build times on Windows.
I took some benchmarks with `-ftime-trace` on the parse times with and without
this change.
Pretty much all the big hitters, string/vector/map/algorithm, includes
`` which includes `` which includes ``.
MaxEW707 wrote:
I appreciate the discussions. I know I have a tendency to get ranty in my
writing so I just want to be clear that I mean no malice.
I can further explain my side.
> Include times
> Modules should ease that pain
I don't know how else to make it clear that we will never be
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/76646
>From a081f8266f24405523e6d283318bd898fd2d376a Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Sat, 30 Dec 2023 22:00:38 -0500
Subject: [PATCH 1/2] Warn on self move
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/76646
There are code bases that inline `std::move` manually via `static_cast`.
Treat a static cast to an xvalue as an inlined `std::move` call and warn on a
self move.
>From a081f8266f24405523e6d283318bd898fd2d376a
MaxEW707 wrote:
> I don't know whether all of these things should be handled with the same
> attribute, or whether they should be handled at all, but they should
> definitely be considered when designing this attribute.
For this I am more concerned with language level features such as move,
MaxEW707 wrote:
> (@MaxEW707 I think having a chat about this informally would be nice.)
Sounds good. Let me know the best way to contact you.
> While I disagree with the reasoning for not just using std
I'll try to give more context here. The main reason is include times and not
wanting to
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/76596
>From ff2c4b9310950c56a4e2a2b7752f3c3c442a6805 Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Fri, 29 Dec 2023 04:02:10 -0500
Subject: [PATCH 1/3] Add
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/76596
Background
https://godbolt.org/z/hv53svTrq for reference on all of the below.
In games debug performance is critical as much as optimized performance.
We mainly accomplish this by reducing the
https://github.com/MaxEW707 closed
https://github.com/llvm/llvm-project/pull/76346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
Closing this out. Looks like someone beat me to it :).
https://github.com/llvm/llvm-project/commit/81ae2a8bb01d38162e0269fc6819584af6d60b03
https://github.com/llvm/llvm-project/pull/76346
___
cfe-commits mailing list
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/76346
None
>From e95623f3e0b89d2499ffe19a4d36eabef9ffa2d4 Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Sun, 24 Dec 2023 20:53:19 -0500
Subject: [PATCH] Fix unused var
MaxEW707 wrote:
> Thanks @MaxEW707 ! I don't have other comments now. Do you need help to merge
> it for you?
Thanks for the review :). I don't have commit access so we need someone to
commit the PR for me.
https://github.com/llvm/llvm-project/pull/75992
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/5] Move Intel ADC
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
MaxEW707 wrote:
Confirmed that Intel ADX
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/4] Move Intel ADC
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
MaxEW707 wrote:
> add comment for
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/3] Move Intel ADC
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/2] Move Intel ADC
MaxEW707 wrote:
> @MaxEW707 If you pull out the adcintrin.h change into a separate PR we can
> fast track it as it should be done anyhow
Done :). Here is the link since I can't add reviewers
https://github.com/llvm/llvm-project/pull/75992.
https://github.com/llvm/llvm-project/pull/75711
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/75992
See https://github.com/llvm/llvm-project/pull/75711 for discussion.
As a summary from the PR above, `` includes adc intrinsics and adx
intrinsics.
To support MSVC STL we need to expose the adc intrinsics
MaxEW707 wrote:
MSVC STL requires the x64 adc intel intrinsics. I moved those to a separate
file `adcintrin.h` that can be included from `immintrin.h` and `intrin0.h` for
x64.
I also made a table [here
](https://gist.github.com/MaxEW707/2f4bf26801bc1b6b088aa7a2fadba526) of all the
MaxEW707 wrote:
> Is intrin0.h a header that ships with MSVC's compiler, or with MS's STL? If
> the latter, shouldn't everything just work already?
It ships with MSVC.
`intrin0.h` from MSVC doesn't work currently due to some declarations not
matching declarations in clang's own `intrin.h`.
90 matches
Mail list logo