[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

p4vook wrote: Looking for someone with knowledge of Clang AST, because I can't figure out the correct context to insert the statement into. Current implementation breaks "for" loop. https://github.com/llvm/llvm-project/pull/75547 ___ cfe-commits

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

p4vook wrote: I converted the PR to draft, as this seems to be a part of a bigger problem with inserting statements into wrong nodes of the syntax tree (this seems to only show up when namespaces are present). I believe it shouldn't be fixed just by a simple check for `nullptr`.

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook converted_to_draft https://github.com/llvm/llvm-project/pull/75629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

@@ -0,0 +1,10 @@ +// RUN: clang-repl "int x = 10;" "{ int t; a::b(t); }" "int y = 10;" p4vook wrote: Yep, we can, I'll try to do it this evening. I couldn't figure out why this test failed though, I probably need to fix it somehow.

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75547 >From 97c3ed6c8a007dbca32416ebb31cf4c3bd52b264 Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 03:07:06 +0300 Subject: [PATCH 1/3] [clang-repl] fix top-level statement declaration context

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75547 >From 97c3ed6c8a007dbca32416ebb31cf4c3bd52b264 Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 03:07:06 +0300 Subject: [PATCH 1/2] [clang-repl] fix top-level statement declaration context

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

@@ -0,0 +1,10 @@ +// RUN: clang-repl "int x = 10;" "{ int t; a::b(t); }" "int y = 10;" p4vook wrote: I don't quite understand, the `code-undo.cpp` doesn't seem to have anything that produces an error, but this test does. If we define a::b(t), clang-repl stops

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75629 >From 2c4ab0990b55be21ca820d84eebb46b1814bb0aa Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 15:05:45 +0300 Subject: [PATCH 1/3] [clang-repl] fix segfault in CleanUpPTU() Check if the last

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75629 >From 2c4ab0990b55be21ca820d84eebb46b1814bb0aa Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 15:05:45 +0300 Subject: [PATCH 1/2] [clang-repl] fix segfault in CleanUpPTU() Check if the last

[clang] [clang-repl] fix segfault in CleanUpPTU() (PR #75629)

https://github.com/p4vook created https://github.com/llvm/llvm-project/pull/75629 Check if the last translation unit or its first declaration are actually empty and do not nead cleanup. Previously this caused segmentation fault on empty PTUs. Add a regression test. Fixes: #72980 >From

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

p4vook wrote: Apparently, we should clean up only parts of the PTU that have changed. Dear reviewers, do you have any idea how that could be implemented? https://github.com/llvm/llvm-project/pull/75547 ___ cfe-commits mailing list

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75547 >From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 03:07:06 +0300 Subject: [PATCH 1/4] clang-repl: fix top-level statement declaration context

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75547 >From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 03:07:06 +0300 Subject: [PATCH 1/3] clang-repl: fix top-level statement declaration context

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

p4vook wrote: I should probably add a test to fix this behavior, but I haven't figured out how to run the tests locally yet. https://github.com/llvm/llvm-project/pull/75547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-repl] fix top-level statement declaration context (PR #75547)

https://github.com/p4vook edited https://github.com/llvm/llvm-project/pull/75547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang-repl: fix top-level statement declaration context (PR #75547)

https://github.com/p4vook updated https://github.com/llvm/llvm-project/pull/75547 >From bf1bd0d9618d05ce718a9d834727ff25c3e92a18 Mon Sep 17 00:00:00 2001 From: Pavel Kalugin Date: Fri, 15 Dec 2023 03:07:06 +0300 Subject: [PATCH] clang-repl: fix top-level statement declaration context Change

[clang] clang-repl: fix top-level statement declaration context (PR #75547)

https://github.com/p4vook created https://github.com/llvm/llvm-project/pull/75547 Change the declaration context where we insert top-level statements to CurrentContext. Previously, top-level statement declarations were inserted directly into the translation unit. This is incorrect, as it

[clang] Add Documentation for Execution Results Handling in Clang-Repl (PR #65650)

@@ -213,6 +213,411 @@ concept helps support advanced use cases such as template instantiations on dema automatic language interoperability. It also helps static languages such as C/C++ become apt for data science. +Execution Results Handling in Clang-Repl