[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

klausler added inline comments. Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1 +#ifndef FORTRAN_EVALUATE_TESTING_H_ +#define FORTRAN_EVALUATE_TESTING_H_ Why was this file (and testing.cpp) added instead of being moved, like other files were? Why

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

klausler added inline comments. Comment at: flang/runtime/CMakeLists.txt:251 - INSTALL_WITH_TOOLCHAIN -) +if (DEFINED LLVM_ENABLE_RUNTIMES AND "flang-rt" IN_LIST LLVM_ENABLE_RUNTIMES) + add_flang_library(FortranRuntime STATIC pscoro wrote: > efriedma wrote:

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler accepted this revision. klausler added a comment. The runtime parts look good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler added a comment. I can't speak to the lowering or driver bits, but the runtime part looks pretty good to me. Comment at: flang/runtime/environment-default-list.h:1 +//===-- Runtime/environment-default-list.h ===// +//

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler added inline comments. Comment at: flang/runtime/main.cpp:51 + if (Fortran::runtime::executionEnvironment.conversion != + Fortran::runtime::Convert::Unknown) +return; We always use braces on if/for/while/ constructs in the runtime.

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler added a comment. Instead of adding new custom APIs that let command-line options control behavior is a way that is redundant with the runtime environment, I suggest that you try a more general runtime library API by which the main program can specify a default environment variable

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. In D122008#3462550 , @awarzynski wrote: > Btw, if there are no new comments, I would like to merge this in the coming > days. New comments or not, this step remains premature from my perspective. Repository: rG LLVM

[PATCH] D123113: [Flang] Add `INTENT` for non-dummy arguments extension

klausler added a comment. What is going on here? I don't understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123113/new/ https://reviews.llvm.org/D123113 ___ cfe-commits mailing list

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. There's 128037 lines of code and documentation outside of lowering and drivers in flang/, and "git blame" tells me that I wrote 63% of them, including most of the Fortran semantics and nearly all of the Fortran parsing and runtime. Based on my knowledge of the code

[PATCH] D114209: [flang] Add -fno-automatic, refine IsSaved()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG996ef895cd3d: [flang] Add -fno-automatic, refine IsSaved() (authored by klausler). Herald added a project: clang. Herald added a subscriber:

[PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3338ef93b028: [flang] Produce proper preprocessor output for -E option (authored by klausler). Herald added a project: clang. Herald added a

[PATCH] D103612: [flang][driver] Add `-fno-analyzed-objects-for-unparse`

klausler added a comment. This patch may have broken the shared library buildbots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 ___ cfe-commits mailing list

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

klausler added a comment. In D103612#2830111 , @awarzynski wrote: > In D103612#2827468 , @klausler > wrote: > >> Kind suffixes are described in subclause 7.4.3 of Fortran 2018, e.g. R708 on >> p. 58. > > Many

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

klausler added a comment. In D103612#2827458 , @awarzynski wrote: > In D103612#2827444 , @klausler > wrote: > >>> The default behaviour is to always decorate unparsed typed expression with >>> e.g. their KIND.

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

klausler added a comment. > The default behaviour is to always decorate unparsed typed expression with > e.g. their KIND. The new flag can be used to turn this off, so that the > generated output uses valid Fortran syntax and can be fed to another Fortran > compiler. The output of

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

klausler added a comment. No; I'm hitting this problem with an in-tree static build of llvm-project/main. Weird. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104305/new/ https://reviews.llvm.org/D104305

[PATCH] D104305: [flang][driver] Add `-fdebug-dump-all`

klausler added a comment. The non-shared-library build of the current llvm-project/main tree fails on this new test; it looks as if gfortran is being invoked and passed an option that it does not recognize. The shared library build passes all tests. Repository: rG LLVM Github Monorepo

[PATCH] D88613: [flang] Semantic analysis for FINAL subroutines

klausler updated this revision to Diff 295423. klausler added a comment. Previous update to this review had inadvertent changes to other files because I neglected to rebase after updating master; now fixed. Sorry for the scare! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION