[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGbab39816085d: [libunwind] Add an interface for dynamic .eh_frame registration (authored by housel). Repository: rG

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel updated this revision to Diff 382884. housel added a comment. Added additional comments to `CFI_Parser::decodeFDE`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111863/new/ https://reviews.llvm.org/D111863 Files:

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. To be clear, this new code parses exactly as much of each FDE as the existing `__register_frame`/`__unw_add_dynamic_fde` does, including doing the same work to compute the record length. Neither needs to parse the instructions at registration time. Repository: rG

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3072829 , @joerg wrote: > Are you mixing up of `__register_frame` and `__register_frame_info`? No? FreeBSD doesn't patch `__register_frame_info`, and so (like base libunwind) it does nothing in the code I linked.

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. It's also worth noting that FreeBSD's version of libgcc exception handling is actually based on the libunwind code, with a local patch that implements compatibility with

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3069279 , @lhames wrote: > I think the ORC runtime provides a much more natural way to test this. Did > you manage to come up with some ORC-runtime based tests in the end? My current plan is to automate what I've been

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3065992 , @MaskRay wrote: > I looked at the libgcc mechanism at one time. I remember that in most cases > it just uses `PT_GNU_EH_FRAME` and these eh_frame boundary registry functions > are not needed. > Can ORC just

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel created this revision. housel added a reviewer: cfe-commits. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. housel requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits.