[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp added a comment. Hi @MaskRay, could you please take a look at @nemanjai's suggestion? > ... > So I would prefer that we handle this in the CMake files if @MaskRay doesn't > object. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6cc5ddc9478: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448036. quinnp added a comment. Adding lit config to mark tests as unsupported for non PPC targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf565444b486d: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448016. quinnp marked 5 inline comments as done. quinnp added a comment. Addressing review comments: fixing test cases and improving test case clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 447336. quinnp marked 3 inline comments as done. quinnp added a comment. Adressing review comments. Moving tests into `function-sections.c`, using `%s` instead of creating a new file with `touch`, and modifying some `CHECK` lines to simplify checks.

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:579 + else if (Args.hasArg(options::OPT_fno_data_sections)) +CmdArgs.push_back("-plugin-opt=-data-sections=0"); MaskRay wrote: > Is -plugin-opt=-data-sections=0 a problem

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446597. quinnp marked 3 inline comments as done. quinnp added a comment. Adressed review comments. - Modified how `llvm-lto` test-cases check the `llvm-objdump -t` output. - Renamed `gold-lto-sections.c` to `forwarding-sections-liblto.c` and modified the

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp added a comment. In D129401#3666238 , @MaskRay wrote: > Mostly looks good, with a nit in the test and some suggestion to the summary. > > In D129401#3662857 , @quinnp wrote: > >>> If this is for the legacy

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446228. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Changing test cases to use `llvm-objdump -t` instead of `obj2yaml`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446147. quinnp marked 6 inline comments as done. quinnp added a comment. Addressing review comments. Fixing the forwarding for -fno-function-sectons and removing the ObjectFormatType check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445839. quinnp added a comment. Modifying a test to fix check lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files:

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp added a comment. > If this is for the legacy LTO interface, please state so. `lld/*/LTO.cpp` > sets `c.Options.DataSections = true;` to enable data sections by default. Hey @MaskRay, I'm not sure what is considered the legacy LTO interface, but this change is to make the `libLTO`

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445835. quinnp marked an inline comment as done. quinnp added a comment. Fixing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files:

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp added a comment. In D129855#3657006 , @MaskRay wrote: > This is not right as using `ld.lld` as the default linker isn't the majority > case. If you want to change the default for your distribution, set > `-DCLANG_DEFAULT_LINKER=lld`. >

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445634. quinnp added a comment. Addressing review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445631. quinnp added a comment. Updating patch to forward `-data-sections=1` to `libLTO`/`gold` instead of just `-data-sections` when `-fdata-sections` is explicitly specified in `clang`. This is to be more explicit since `-data-sections=0` is now being

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

quinnp updated this revision to Diff 445628. quinnp added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Updating patch with a `clang` change to properly forward `-data-sections=0` to `libLTO`/`gold` when `-fno-data-sections` is explicitly specified.

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

quinnp created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch changes the default linker for `clang`

[PATCH] D128288: [PowerPC] Fix signatures for vec_replace_unaligned builtin

quinnp accepted this revision. quinnp added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128288/new/ https://reviews.llvm.org/D128288

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35aaf548237a: [clang][driver] fix to correctly set devtoolset on RHEL (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp added a comment. Thanks @tbaeder, @MaskRay, and @nemanjai. > I did not remove that on purpose, so adding it back makes sense to me. I've updated the patch to remove the path without the `/root/usr` suffix and exclusively add the path with the `root/usr` suffix. > This change also needs

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435914. quinnp added a comment. Herald added a subscriber: ormris. Addressing review comments. Removing path without `/root/usr` prefix and changing unit test to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp marked 2 inline comments as done. quinnp added a comment. Thank you @nemanjai! I've updated the patch based on your suggestion and tested it for both the existing testcase and the RHEL buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435239. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch correctly sets the devtoolset on RHEL. Repository: rG LLVM Github Monorepo

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

This revision was automatically updated to reflect the committed changes. Closed by commit rG0386213352ec: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/ (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch rewords a comment to replace Whitelist with

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp reopened this revision. quinnp added a comment. This revision is now accepted and ready to land. Re-opening the revision so that I can update it with a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added a comment. In D121637#3437371 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/55893/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for finding this, not sure

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aae5b1fac38: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421303. quinnp added a comment. Fixing a set of builtins added by the rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files:

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421286. quinnp added a comment. Rebasing with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Value *Y = +Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3)); return Builder.CreateOr(X, Y); nemanjai wrote: > Nit: I understand that we

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421279. quinnp marked an inline comment as done. quinnp added a comment. Fixing some testcases that broke due to re-ordering IR in my last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) -

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 419126. quinnp added a comment. Moving testcases that require code generation from `clang/test/Sema/ppc-pair-mma-types.c` to `clang/test/CodeGen/PowerPC/ppc-mma-types.c` and `clang/test/CodeGen/PowerPC/builtins-ppc-pair-mma-types.c`. This is because some

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15208 - for (unsigned i = 0, e = E->getNumArgs(); i != e; i++) { -if (E->getArg(i)->getType()->isArrayType()) - Ops.push_back(EmitArrayToPointerDecay(E->getArg(i)).getPointer());

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 416917. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 415412. quinnp added a comment. Minor formatting update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors `EmitPPCBuiltinExpr` in `CGBuiltin.cpp` to remove

[PATCH] D112073: [PowerPC] Emit warning when SP is clobbered by asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a028296fe62: [PowerPC] Emit warning when SP is clobbered by asm (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112073: [PowerPC] Emit warning when SP is clobbered by asm

quinnp updated this revision to Diff 395687. quinnp added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adressing review comments. Added register alias "sp" for the register "r1". Added a front end testcase to test the location information and all of the

[PATCH] D114090: [NFC] Inclusive language: rename master flag to main flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGb11c66accfb1: [NFC] Inclusive language: rename master flag to main flag (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114090/new/

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

quinnp accepted this revision. quinnp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114029/new/ https://reviews.llvm.org/D114029

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3dc6b081da6: [NFC][clang-tools-extra] Inclusive language: replace master with main (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp added a comment. @sammccall could you take a look at the other changes when you have time? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114100/new/ https://reviews.llvm.org/D114100 ___

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad501054f1b5: [NFC][clang] Inclusive language: rename master variable to controller in debug… (authored by quinnp). Repository: rG LLVM Github

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info-block-helper.m

quinnp updated this revision to Diff 388511. quinnp added a comment. Changing master to controller in another testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114108/new/ https://reviews.llvm.org/D114108 Files:

[PATCH] D113505: [NFC][clang] Inclusive language: replace masterPort with mainPort

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a14244cc645: [NFC][clang] Inclusive language: replace masterPort with mainPort (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp updated this revision to Diff 387990. quinnp marked an inline comment as done. quinnp added a comment. Addressing review comments. Reverting change to `Protocol.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114100/new/

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:141 /// the server can send `null` to indicate that the version is known and the - /// content on disk is the master (as speced with document content

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info-block-helper.m

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch replaces master with controller in `debug-info-block-helper.m`.

[PATCH] D114100: [NFC][clang-tools-extra] Inclusive language: replace master with main

quinnp created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. quinnp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch

[PATCH] D114090: [NFC] Inclusive language: rename master flag to main flag

quinnp created this revision. Herald added subscribers: pengfei, hiraditya. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch renames

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed404a4abd3: [NFC][clang] Inclusive language: Rename myMaster in testcase (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113942: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4b28a0fe685: [NFC][clang] Inclusive language: replace master with main in convert_arm_neon.py (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113942: [NFC] Inclusive language: replace master with main in convert_arm_neon.py

quinnp created this revision. Herald added a subscriber: kristof.beyls. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project and to match the renamed master branch, this

[PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b15b71ce00: [NFC] Inclusive Language: change master to main for .chm files (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113299/new/

[PATCH] D113505: [NFC] Inclusive language: replace masterPort with mainPort

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] This patch replaces `masterPort` with `mainPort` in these testcases. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113505

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch replaces `_myMaster` with `_myLeader` in these testcases. Repository: rG

[PATCH] D113186: [NFC] Inclusive language: Remove instances of master in URLs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc71fbdd87b35: [NFC] Inclusive language: Remove instances of master in URLs (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113299: [NFC] Inclusive Language: change master to main for .chm files

quinnp created this revision. Herald added a reviewer: bollu. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen,

[PATCH] D113186: [NFC] Inclusive language: Remove instances of master in URLs

quinnp created this revision. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, usaxena95,

[PATCH] D110934: [NFC] Update return type of vec_popcnt to vector unsigned.

quinnp added a comment. I think the commit message needs to be updated. > This patch updates the vec_popcnt builtins to take a signed int as the second > parameter... Should be: This patch updates the return type of the vec_popcnt builtins to vector unsigned... Other than that, lgtm.

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

quinnp added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/ https://reviews.llvm.org/D110935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67a3d1e27551: [PowerPC] swdiv builtins for XL compatibility (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375912. quinnp added a comment. Fixing failing test case after rebasing with https://reviews.llvm.org/D110213. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files:

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70391b3468b8: [PowerPC] FP compare and test XL compat builtins. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added a comment. In D106959#3021069 , @NeHuang wrote: > Do we already have a backend test case for `fdiv` emitting a software > estimate when `-Ofast` is used? I've added a testcase in `llvm/test/CodeGen/PowerPC/fdiv.ll` which goes from `fdiv

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 375285. quinnp added a comment. Added a backend testcase which goes from `fdiv fast` to software estimate. Added a runline in the front end testcase that sets the fast math flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374891. quinnp added a comment. Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374888. quinnp added a comment. Addressing nit in SemaChecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0240e6c89d: [PowerPC] Add range check for vec_genpcvm builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp updated this revision to Diff 374854. quinnp added a comment. Rebased with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv_MERGE efriedma wrote:

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 374847. quinnp marked 7 inline comments as done. quinnp added a comment. Updatign the patch to emit a fdiv for each of the builtins without any fast math flags. This will be safe and will still emit a software estimate when `-Ofast` is used. Repository:

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374610. quinnp added a comment. Addressing review comment about ISelLowering of `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files:

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374605. quinnp added a comment. Addressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9912fe4eac9: [PowerPC] Add range checks for P10 Vector Builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374563. quinnp added a comment. Word change. valid -> expected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374561. quinnp added a comment. Added a comment to the out-of-range argument test case to describe the behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374312. quinnp added a comment. Moving the semachecking of `test_data_class` from the function to the switch case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374064. quinnp added a comment. Separating the switch case in ISelLowering into two switch cases. One for `compare_exp_` and another for `test_data_class`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 374000. quinnp added a comment. Adding a testcase where the second parameter of vec_splati_ins is out of the range 0,1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG57939309501c: [PowerPC] Fix signature of lxvp and stxvp builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the signature of the load and store vector pair builtins to match their

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372541. quinnp added a comment. Removing an extra space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins. Range checking is done in

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372479. quinnp added a comment. Fixing failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds range checking for some Power10 altivec builtins and changes the signature of a

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 372243. quinnp added a comment. Adding SemaChecking for the first argument of __builitn_ppc_test_data_class so the llvm_unreachable in CGBuiltin is actually unreachable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch is in a series of patches to provide builtins for

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 363189. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 362400. quinnp added a comment. Fixing a failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility]

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, mgorny, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch is in a series of patches to provide builtins for

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp added a comment. In D103986#2893177 , @DavidSpickett wrote: > You missed a REQUIRES for the llvm test, I added one in: > https://reviews.llvm.org/rG2404834c206a8930b0c420d94f4941b31c355de5 > > So if you see Arm-AArch64 quick bot failures, that

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe002d251dd34: [PowerPC] Floating Point Builtins for XL Compat. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 360408. quinnp added a comment. Rebasing to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def

  1   2   >