[libcxx] r329167 - [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

Author: sdardis Date: Wed Apr 4 04:05:03 2018 New Revision: 329167 URL: http://llvm.org/viewvc/llvm-project?rev=329167=rev Log: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring When libcxx is built in tree for a host which requires libatomic, LLVM's

[clang-tools-extra] r329053 - [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

Author: sdardis Date: Tue Apr 3 02:40:07 2018 New Revision: 329053 URL: http://llvm.org/viewvc/llvm-project?rev=329053=rev Log: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics This addresses a persistent failure on clang-cmake-mips buildbot. Reviewers:

RE: [llvm] r325653 - [mips] Spectre variant two mitigation for MIPSR2

Apoloiges all, I spoke too soon. Some tests fail due to mir changes, and one which a slight different version of the memset intrinsic. Attached is a patch which resolves the failures. Thanks, Simon From: llvm-commits [llvm-commits-boun...@lists.llvm.org]

RE: [llvm] r325653 - [mips] Spectre variant two mitigation for MIPSR2

Hi, Any downstream users should be able to apply this, the corresponding clang patch (r325651) and the LLD patch (r325657, and r325713) cleanly to the release sources of LLVM 6.0, should they require it. Thanks, Simon Author: sdardis Date: Tue Feb 20 16:06:53 2018 New Revision: 325653 URL:

r325651 - [mips] Spectre variant two mitigation for MIPSR2

Author: sdardis Date: Tue Feb 20 16:05:05 2018 New Revision: 325651 URL: http://llvm.org/viewvc/llvm-project?rev=325651=rev Log: [mips] Spectre variant two mitigation for MIPSR2 This patch provides mitigation for CVE-2017-5715, Spectre variant two, which affects the P5600 and P6600. It provides

r323412 - [Driver] Add support for mips32 and scudo

Author: sdardis Date: Thu Jan 25 02:09:33 2018 New Revision: 323412 URL: http://llvm.org/viewvc/llvm-project?rev=323412=rev Log: [Driver] Add support for mips32 and scudo r317337 missed that scudo is supported on MIPS32, so permit that option for MIPS32. Reviewers: cryptoad, atanasyan

r314213 - [mips] Accept but ignore -m(no-)branch-likely

Author: sdardis Date: Tue Sep 26 08:01:21 2017 New Revision: 314213 URL: http://llvm.org/viewvc/llvm-project?rev=314213=rev Log: [mips] Accept but ignore -m(no-)branch-likely -mbranch-likely and -mno-branch-likely are used in some build systems for some MIPS targets. Accept these options but

r310715 - [mips] Add missing mips-registered-target to mips test.

Author: sdardis Date: Fri Aug 11 08:23:23 2017 New Revision: 310715 URL: http://llvm.org/viewvc/llvm-project?rev=310715=rev Log: [mips] Add missing mips-registered-target to mips test. Modified: cfe/trunk/test/Driver/mips-abi.c Modified: cfe/trunk/test/Driver/mips-abi.c URL:

r310714 - [mips] Support implicit gpopt with N64 when using -fno-pic

Author: sdardis Date: Fri Aug 11 08:01:34 2017 New Revision: 310714 URL: http://llvm.org/viewvc/llvm-project?rev=310714=rev Log: [mips] Support implicit gpopt with N64 when using -fno-pic As clang defaults to -mno-abicalls when using -fno-pic for N64, implicitly use -mgpopt in that case.

RE: r308619 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

> -Original Message- > From: Simon Atanasyan [mailto:si...@atanasyan.com] > Sent: 04 August 2017 11:29 > To: Simon Dardis > Cc: Clang Commits > Subject: Re: r308619 - Reland "[mips] Teach the driver to accept -m(no- > )gpopt." > > On Thu, Jul 20,

r309978 - [mips] Revert r309942 & r309940

Author: sdardis Date: Thu Aug 3 12:39:51 2017 New Revision: 309978 URL: http://llvm.org/viewvc/llvm-project?rev=309978=rev Log: [mips] Revert r309942 & r309940 This reverts commit r309942 & commit r309940. A revert was requested following post commit review. Removed:

RE: r309940 - [mips] Implement -muninit-const-in-rodata

> From: Joerg Sonnenberger [mailto:jo...@bec.de] > Sent: 03 August 2017 15:12 > To: cfe-commits@lists.llvm.org > Cc: Simon Dardis > Subject: Re: r309940 - [mips] Implement -muninit-const-in-rodata > > On Thu, Aug 03, 2017 at 02:01:17PM -0000, Simon Dardis via cfe-commit

r309942 - [mips] Fixup r309940.

Author: sdardis Date: Thu Aug 3 07:35:06 2017 New Revision: 309942 URL: http://llvm.org/viewvc/llvm-project?rev=309942=rev Log: [mips] Fixup r309940. Needed a // REQUIRES: mips-registered-target Modified: cfe/trunk/test/CodeGen/mips-uninit-const-in-ro.c Modified:

r309940 - [mips] Implement -muninit-const-in-rodata

Author: sdardis Date: Thu Aug 3 07:01:17 2017 New Revision: 309940 URL: http://llvm.org/viewvc/llvm-project?rev=309940=rev Log: [mips] Implement -muninit-const-in-rodata This option when combined with -mgpopt and -membedded-data places all uninitialized constant variables in the read-only

r309935 - [mips] Add support -m(no-)embedded-data option

Author: sdardis Date: Thu Aug 3 06:04:29 2017 New Revision: 309935 URL: http://llvm.org/viewvc/llvm-project?rev=309935=rev Log: [mips] Add support -m(no-)embedded-data option Add support for the -membedded-data option which places constant data in the .rodata section, rather than the .sdata

r308879 - [mips] Add support for -m(no-)extern-data.

Author: sdardis Date: Mon Jul 24 07:02:09 2017 New Revision: 308879 URL: http://llvm.org/viewvc/llvm-project?rev=308879=rev Log: [mips] Add support for -m(no-)extern-data. Add support for -m(no-)extern-data when using -mgpopt in the driver. It is enabled by default in the backend. Reviewers:

r308683 - [mips] Add support for -m(no-)local-sdata

Author: sdardis Date: Thu Jul 20 15:23:21 2017 New Revision: 308683 URL: http://llvm.org/viewvc/llvm-project?rev=308683=rev Log: [mips] Add support for -m(no-)local-sdata Teach the driver to support -mlocal-sdata. The backend already matches GCC's default behaviour. Reviewers: atanasyan,

r308619 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

Author: sdardis Date: Thu Jul 20 07:04:12 2017 New Revision: 308619 URL: http://llvm.org/viewvc/llvm-project?rev=308619=rev Log: Reland "[mips] Teach the driver to accept -m(no-)gpopt." This patch teaches the driver to pass -mgpopt by default to the backend when it is supported, i.e. we are

r308459 - Revert "Reland "[mips] Teach the driver to accept -m(no-)gpopt.""

Author: sdardis Date: Wed Jul 19 06:34:08 2017 New Revision: 308459 URL: http://llvm.org/viewvc/llvm-project?rev=308459=rev Log: Revert "Reland "[mips] Teach the driver to accept -m(no-)gpopt."" This reverts r308458. Investigating further buildbot breakage. Removed:

r308458 - Reland "[mips] Teach the driver to accept -m(no-)gpopt."

Author: sdardis Date: Wed Jul 19 06:12:37 2017 New Revision: 308458 URL: http://llvm.org/viewvc/llvm-project?rev=308458=rev Log: Reland "[mips] Teach the driver to accept -m(no-)gpopt." This patch teaches the driver to pass -mgpopt by default to the backend when it is supported, i.e. we are

r308436 - Revert "[mips] Teach the driver to accept -m(no-)gpopt."

Author: sdardis Date: Wed Jul 19 04:11:02 2017 New Revision: 308436 URL: http://llvm.org/viewvc/llvm-project?rev=308436=rev Log: Revert "[mips] Teach the driver to accept -m(no-)gpopt." Revert r308431 and r308432, these caused broke some buildbots. Removed:

r308432 - [mips] Add warning test for -mgpopt option.

Author: sdardis Date: Wed Jul 19 03:39:15 2017 New Revision: 308432 URL: http://llvm.org/viewvc/llvm-project?rev=308432=rev Log: [mips] Add warning test for -mgpopt option. Added: cfe/trunk/test/Driver/mips-gpopt-warning.c Added: cfe/trunk/test/Driver/mips-gpopt-warning.c URL:

r308431 - [mips] Teach the driver to accept -m(no-)gpopt.

Author: sdardis Date: Wed Jul 19 03:38:03 2017 New Revision: 308431 URL: http://llvm.org/viewvc/llvm-project?rev=308431=rev Log: [mips] Teach the driver to accept -m(no-)gpopt. This patch teaches the driver to pass -mgpopt by default to the backend when it is supported, i.e. we are using

r307847 - [mips][mt][7/7] Add driver option for the MIPS MT ASE.

Author: sdardis Date: Wed Jul 12 14:13:05 2017 New Revision: 307847 URL: http://llvm.org/viewvc/llvm-project?rev=307847=rev Log: [mips][mt][7/7] Add driver option for the MIPS MT ASE. Reviewers: atanasyan, slthakur Differential Revision: https://reviews.llvm.org/D35254 Modified:

RE: r304935 - Revert r304929 [mips] Add runtime options to enable/disable madd/sub.fmt

Appears to be fixed, r304936. I'll keep an eye on the buildbots. Thanks, Simon From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of Evgenii Stepanov via cfe-commits [cfe-commits@lists.llvm.org] Sent: 07 June 2017 20:53 To: Petar Jovanovic

r304936 - Finish revert of "r304929, [mips] Add runtime options to enable/disable madd/sub.fmt"

Author: sdardis Date: Wed Jun 7 15:02:24 2017 New Revision: 304936 URL: http://llvm.org/viewvc/llvm-project?rev=304936=rev Log: Finish revert of "r304929, [mips] Add runtime options to enable/disable madd/sub.fmt" The r304935 missed deleting the test case. Removed:

RE: r302935 - [Sema] Support implicit scalar to vector conversions

*, true>&, clang::ActionResult<clang::Expr*, true>&, clang::SourceLocation, clang::BinaryOperatorKind, bool) /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/lib/Sema/SemaExpr.cpp:9495:12 On Fri, May 12, 2017 at 12:24 PM Simon Dardis via cfe-commits

r302941 - [Sema] Silence buildbot failures introduced by r302935

Author: sdardis Date: Fri May 12 14:55:32 2017 New Revision: 302941 URL: http://llvm.org/viewvc/llvm-project?rev=302941=rev Log: [Sema] Silence buildbot failures introduced by r302935 Attempt to silence buildbot failures by pinning the test to a given triple rather than the host's triple.

r302935 - [Sema] Support implicit scalar to vector conversions

Author: sdardis Date: Fri May 12 14:11:06 2017 New Revision: 302935 URL: http://llvm.org/viewvc/llvm-project?rev=302935=rev Log: [Sema] Support implicit scalar to vector conversions This patch teaches clang to perform implicit scalar to vector conversions when one of the operands of a binary

r299643 - [Sema] Retarget test to a specific platform for consistent datasizes

Author: sdardis Date: Thu Apr 6 06:12:14 2017 New Revision: 299643 URL: http://llvm.org/viewvc/llvm-project?rev=299643=rev Log: [Sema] Retarget test to a specific platform for consistent datasizes Attempt to satisfy llvm-clang-x86_64-expensive-checks-win by targeting x86_64-apple-darwin10 for

r299641 - [Sema] Extend GetSignedVectorType to deal with non ExtVector types

Author: sdardis Date: Thu Apr 6 05:38:03 2017 New Revision: 299641 URL: http://llvm.org/viewvc/llvm-project?rev=299641=rev Log: [Sema] Extend GetSignedVectorType to deal with non ExtVector types This improves some error messages which would otherwise refer to ext_vector_type types in contexts

r295728 - [mips] Define macros related to -mabicalls in the preprocessor

Author: sdardis Date: Tue Feb 21 10:01:00 2017 New Revision: 295728 URL: http://llvm.org/viewvc/llvm-project?rev=295728=rev Log: [mips] Define macros related to -mabicalls in the preprocessor Summary: Historically, NetBSD, FreeBSD and OpenBSD have defined the macro ABICALLS in the preprocessor

r293285 - [mips] Add support for static model on N64

Author: sdardis Date: Fri Jan 27 09:05:25 2017 New Revision: 293285 URL: http://llvm.org/viewvc/llvm-project?rev=293285=rev Log: [mips] Add support for static model on N64 The patch teaches the Clang driver how to handle the N64 static relocation model properly. It enforces the correct target

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 78531. sdardis marked 4 inline comments as done. sdardis added a comment. Addressed review comments. https://reviews.llvm.org/D25866 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8064 + ScalarCast = CK_FloatingCast; +} else if (ScalarTy->isIntegralType(S.Context)) { + // Determine if the integer constant can be expressed as a floating point bruno wrote: > I

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added a comment. Ping. https://reviews.llvm.org/D25866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis updated this revision to Diff 76824. sdardis added a comment. Rebase and ping https://reviews.llvm.org/D21072 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp

[PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis updated this revision to Diff 76823. sdardis added a comment. Rebase and ping. https://reviews.llvm.org/D21070 Files: lib/Basic/Targets.cpp lib/Driver/ToolChains.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvocation.cpp tools/driver/cc1as_main.cpp Index:

[PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

sdardis added a comment. Ping. https://reviews.llvm.org/D24448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated the summary for this revision. sdardis updated this revision to Diff 76385. sdardis added a comment. Split out a variant of tryVectorConvertAndSplat called tryGCCVectorConvertAndSplat. This variant checks the types more strictly than tryVectorConvertAndSplat and handles implicit

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 75708. sdardis marked an inline comment as done. sdardis added a comment. Extra testing for cases where the operand on the left of an operation is a vector. Removed two spurious checks for vector types. https://reviews.llvm.org/D25866 Files:

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis created this revision. sdardis added subscribers: rnk, bruno, ahatanak, cfe-commits. Herald added a reviewer: vkalintiris. This patch teaches clang to perform implicit scalar to vector conversions when one of the operands to a binary vector expression is a scalar like GCC. The scalar is

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

sdardis added a comment. Thanks. Repository: rL LLVM https://reviews.llvm.org/D25017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

This revision was automatically updated to reflect the committed changes. Closed by commit rL284620: [mips][msa] Range check MSA intrinsics with immediates (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D25017?vs=74499=75173#toc Repository: rL LLVM

r284620 - [mips][msa] Range check MSA intrinsics with immediates

Author: sdardis Date: Wed Oct 19 12:50:52 2016 New Revision: 284620 URL: http://llvm.org/viewvc/llvm-project?rev=284620=rev Log: [mips][msa] Range check MSA intrinsics with immediates This patch teaches clang to range check immediates for MIPS MSA instrinsics. This checking is done strictly in

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

sdardis updated this revision to Diff 74499. sdardis added a comment. Update ld / st to respect their range and multiple of 16 constraint. https://reviews.llvm.org/D25017 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp

[PATCH] D25017: [mips][msa] Range check MSA intrinsics with immediates

sdardis created this revision. sdardis added reviewers: vkalintiris, zoran.jovanovic. sdardis added a subscriber: cfe-commits. Herald added a subscriber: sdardis. This patch teaches clang to range check immediates for MIPS MSA instrincs. This checking is done strictly in comparison to some

Re: [PATCH] D24798: [mips] Fix msa builtins test

sdardis abandoned this revision. sdardis added a comment. I'm abandoning this revision. This test is riddled with errors such as out of range immediates and type errors that aren't warned about. I'll post a more substantial patch to address the handling of those cases + update this test and

[PATCH] D24798: [mips] Fix msa builtins test

sdardis created this revision. sdardis added reviewers: vkalintiris, zoran.jovanovic. sdardis added a subscriber: cfe-commits. Herald added a subscriber: sdardis. This test was using the wrong types in several places. https://reviews.llvm.org/D24798 Files: test/CodeGen/builtins-mips-msa.c

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis added a comment. Checking the generated IR for the incorrect uses of v8f16 shows that clang is silently generating bitcasts from <8 x i16> to <4 x float>. There are some other cases where the type of the operands is incorrect w.r.t. the builtin used. I'm not familiar with the type

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis closed this revision. sdardis added a comment. As stated I'll do a follow-up patch to fix the test. Committed as r281975. Thanks, Simon https://reviews.llvm.org/D24674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24674: [mips] MSA intrinsics header file

sdardis added a comment. @mpf I'll correct the incorrect uses in a followup patch. Thanks, Simon https://reviews.llvm.org/D24674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

sdardis updated this revision to Diff 71507. sdardis added a comment. Update comment and test for atomic expansion. https://reviews.llvm.org/D24448 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

sdardis closed this revision. sdardis added a comment. Committed as https://reviews.llvm.org/rL281610. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r281610 - [mips][ias] Enable IAS by default for N64 on Debian mips64el.

Author: sdardis Date: Thu Sep 15 09:01:55 2016 New Revision: 281610 URL: http://llvm.org/viewvc/llvm-project?rev=281610=rev Log: [mips][ias] Enable IAS by default for N64 on Debian mips64el. Unfortunately we can't enable it for all N64 because it is not yet possible to distinguish N32 from N64

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis added a comment. Ping. https://reviews.llvm.org/D21070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

sdardis created this revision. sdardis added a subscriber: cfe-commits. Herald added a reviewer: vkalintiris. Herald added a subscriber: aemerson. Targets typically support atomics that are word sized (e.g. 32 or 64 bit) or half word sized (e.g. 32 bit on 64 bit systems). For larger sizes, some

Re: [PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis updated this revision to Diff 68993. sdardis added a comment. Rebase + ping. https://reviews.llvm.org/D21072 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp

Re: [PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis commandeered this revision. sdardis added a reviewer: dsanders. sdardis added a comment. Herald added a reviewer: vkalintiris. Taking over this patch series. https://reviews.llvm.org/D21072 ___ cfe-commits mailing list

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis added a subscriber: sdardis. sdardis commandeered this revision. sdardis added a reviewer: dsanders. sdardis added a comment. Herald added a reviewer: vkalintiris. Taking over this patch series. https://reviews.llvm.org/D21070 ___

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

sdardis added a comment. Actually, seeing your reply on the related patch, keep the comment as it reflects trunk. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

sdardis added a comment. Yes, I think you should also reflect mpf's comment here too. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22679: [mips][ias] Enable IAS by default for N64 on Debian mips64el.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D22679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20729: [mips] Compact branch policy setting

sdardis added a comment. Thanks for the review. Repository: rL LLVM http://reviews.llvm.org/D20729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271000 - [mips] Compact branch policy setting.

Author: sdardis Date: Fri May 27 10:13:31 2016 New Revision: 271000 URL: http://llvm.org/viewvc/llvm-project?rev=271000=rev Log: [mips] Compact branch policy setting. This patch adds the commandline option -mcompact-branches={never,optimal,always), which controls how LLVM generates compact

[PATCH] D20729: [mips] Compact branch policy setting

sdardis created this revision. sdardis added reviewers: dsanders, atanasyan. sdardis added a subscriber: cfe-commits. Herald added a reviewer: vkalintiris. Herald added a subscriber: sdardis. This patch adds the commandline option -mcompact-branches={never,optimal,always), which controls how

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 41283. sdardis added a comment. Nit addressed. Daniel or Aaron, can one of you commit on my behalf? Thanks. Aaron, thanks for the review. http://reviews.llvm.org/D10802 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 41041. sdardis added a comment. Updated text of return type/parameters warning to Aaron's suggestion. Dropped '\' escape characters from warning/error text. Removed mips16/nomips16 check. Tweak of comment in handleMipsInterruptAttr.

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 40782. sdardis marked 4 inline comments as done. sdardis added a comment. Updated comments, used cast as suggested, added mutual exclusion check for mips16+interrupt combination. Extended mips16/nomips16 attribute handlers for mutual exclusion, add to

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 40382. sdardis marked 12 inline comments as done. sdardis added a comment. Updated documentation text. Switched the various hard failures to semantic warnings/failures. Strangely, the 'interrupt' attribute on a non-function defaults to a warning. Thanks.

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated this revision to Diff 38533. sdardis added a comment. Updated tests along the lines of what vkalintiris did for llvm. http://reviews.llvm.org/D10802 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

Re: [PATCH] D10802: [mips] Interrupt attribute support.

sdardis updated the summary for this revision. sdardis updated this revision to Diff 38102. sdardis marked 3 inline comments as done. sdardis added a comment. Nits addressed and XFAIL tests added for functions having arguments and the interrupt attribute. Test added to cover semantic warnings.