[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.c:675-676 +// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm" +// CHECK-LD32-SHARED-EXPORTS-NOT: "-X" +// CHECK-LD32-SHARED-EXPORTS-NOT: "32" +// CHECK-LD32-SHARED-EXPORTS: "{{.*}}ld{{(.exe)?}}"

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM other than some nits. Comment at: clang/lib/Driver/Job.cpp:361 + + if (!RedirectFiles.empty()) { +std::vector> RedirectFilesOptional;

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

stevewan added a comment. I don't think the redirect files portion of this patch is well-described in the description, could you please add it? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList ) { + for (size_t i =

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG245b8e5691ed: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX (authored by stevewan). Repository: rG LLVM Github

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404951. stevewan added a comment. Add the flag to all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Analysis/padding_c.c

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404947. stevewan added a comment. Use "-Wno-aix-compat" so that we don't lose coverage on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files:

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These tests emit unexpected diagnostics on AIX because the byval alignment warning is emitted too aggressively. https://reviews.llvm.org/D118350 is

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG760e69223d83: [NFC][AIX]Disable new pcm tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same as D114481 , the PCH reader looks for a `__clangast` section in the precompiled module file, which isn't

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

stevewan added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp Jake-Egan wrote: > jansvoboda11

[PATCH] D114454: [analyzer]Skip unstable CSA tests failing on several platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4d194f44c4: [analyzer]Skip unstable CSA tests failing on several platforms (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. > but we could pick a couple of esoteric targets where integrals differ > significantly from what we have on x86_64 Turns out `wasm` and `darwin` also have a similar problem, I added them to the skip list for now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 391120. stevewan added a comment. Herald added subscribers: luke957, s.egerton, simoncook, fedor.sergeev, aheejin. Add targets we are interested in testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. Finally had some time to get back to this. Thanks @steakhal for your suggestion, the sample code in `ASTMatchersNodeTest.cpp` was helpful. I was actually looking for a good way of querying the target triple as I do agree that it is an better way of fixing this.

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 390795. stevewan added a comment. Herald added a subscriber: mgorny. Pin target triple before analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 Files:

[PATCH] D114615: [NFC][clang]Increase the number of driver diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c32c568844c: [NFC][clang]Increase the number of driver diagnostics (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG23dc88622630: [NFC][AIX]Disable unsupported hip test on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114484/new/

[PATCH] D114615: Increase the number of driver diagnostics

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're close to hitting the limited number of driver diagnostics, increase `DIAG_SIZE_DRIVER` to accommodate more. Repository: rG LLVM Github

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06d4a76309cd: [NFC][AIX]Disable precompiled module file tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan updated this revision to Diff 389535. stevewan added a comment. Explain the rationale Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114481/new/ https://reviews.llvm.org/D114481 Files:

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

stevewan created this revision. Herald added a subscriber: yaxunl. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX doesn't support GPU. There is no point testing HIP on it. Repository: rG LLVM Github Monorepo

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The PCH reader looks for `__clangast` section in the precompiled module file, which is not present in the file on AIX, and we don't support writing

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSA uses bitwidth to infer the integer value type. In the ILP32 model, for example 32-bit AIX, any 32-bit integer type will be considerred as `int`,

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114381/new/ https://reviews.llvm.org/D114381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#3139684 , @martong wrote: > In D104550#3139239 , @stevewan > wrote: > >> In D104550#2849582 , @vsavchenko >> wrote: >> >>> In

[PATCH] D104550: [analyzer] Implement getType for SVal

stevewan added a comment. In D104550#2849582 , @vsavchenko wrote: > In D104550#2849561 , @DavidSpickett > wrote: > >> @vsavchenko One of the added tests is failing on our 32 bit Armv7 Thumb bot: >>

[PATCH] D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42102bce98e5: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113614: Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following interpreter tests failed on AIX because 64-bit XCOFF object files are currently not supported on AIX. This patch disables the tests on

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG806ff3c4a42c: [AIX] Check for typedef properly when getting preferred type align (authored by stevewan). Repository: rG LLVM Github Monorepo

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan updated this revision to Diff 371418. stevewan added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D109387: [NFC][AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987843 , @rjmccall wrote: > Oh, no, I don't think this is NFC. It seems very likely that there's some > case where the behavior is distinguishable. Maybe a typedef of a record with > an alignment attribute? > >

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987780 , @rjmccall wrote: > LGTM, except it's missing tests. Thanks. This is an NFC patch, the tests added in https://reviews.llvm.org/D107598 should still suffice IMHO. Repository: rG LLVM Github Monorepo

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current check for typedef is naive and doesn't deal with any convoluted cases. This patch makes use of the new 'AlignRequirement' enum field from

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b170ccf36e: [AIX] aligned attribute does not decrease alignment (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369319. stevewan added a comment. Rename lambda and add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369293. stevewan added a comment. Adapt to new TypeInfo design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D108858: TypeInfo records more information about align requirement

This revision was automatically updated to reflect the committed changes. Closed by commit rG73733ae526a5: TypeInfo records more information about align requirement (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369258. stevewan added a comment. Add RequiredByEnum case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369240. stevewan added a comment. Fix enum usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369235. stevewan added a comment. Oops missed one flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added a comment. In D107394#2970326 , @rjmccall wrote: > Please add me to the review for the other patch and I'll approve it pretty > quickly, and then we can get back to this one. Sorry for the delay. Posted https://reviews.llvm.org/D108858,

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the information preserved in `TypeInfo` by replacing the `AlignIsRequired` bool flag with a three-valued enum, the enum also indicates where

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369177. stevewan added a comment. Fix missing "&&" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369164. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369163. stevewan marked an inline comment as done. stevewan added a comment. Cleanup the condition check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1984 +auto checkTypeIsTypedef = [](auto &, + const auto Ty) -> bool { + bool isTypedef = false;

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369157. stevewan added a comment. Make TypeInfo carry more information about "aligned" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368716. stevewan marked an inline comment as done. stevewan added a comment. Avoid unannotated fall-through between cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: >

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368702. stevewan added a comment. Herald added a subscriber: jfb. Add recursive check for typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367942. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367875. stevewan added a comment. De-Morgan-ize if condition for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > Okay, so first off, the comment and variable

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367833. stevewan added a comment. Address comments about the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367312. stevewan added a comment. Fields marked attribute "aligned" and "packed" don't need to go through alignment upgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 366051. stevewan added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan planned changes to this revision. stevewan added a comment. The query portion has been split out as https://reviews.llvm.org/D107598, which needs to be cleaned out from this patch. The record layout part also needs update as we uncover more problems with the current implementation.

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa91916500d67: [AIX] aligned attribute should not decrease type alignment returned by… (authored by stevewan). Repository: rG LLVM Github Monorepo

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan updated this revision to Diff 364630. stevewan added a comment. Add third test case as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan added a comment. This is a split of the query portion from https://reviews.llvm.org/D107394. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107598/new/ https://reviews.llvm.org/D107598 ___

[PATCH] D107598: [AIX] "aligned" attribute should not decrease type alignment returned by __alignof__

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "__alignof__()" operator, when used on a type, always returns the `ABIAlign` if the type is marked `__attribute__((aligned()))`. However, the

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364359. stevewan added a comment. Add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364350. stevewan marked an inline comment as done. stevewan added a comment. Fix the same problem in field layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:11 + +// CHECK: @c = global %struct.C zeroinitializer, align 2 sfertile wrote: > Minor nit: I think the other test can

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 364186. stevewan added a comment. Merge tests into one file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 ___ cfe-commits mailing list

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 363870. stevewan added a comment. Fix incomplete diff, please discard last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 363860. stevewan added a comment. Attr 'packed' is already taken into account in ABIAlign/PreferredAlign Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "aligned" attribute can only increase the alignment of a struct, or struct member, unless it's used together with the "packed" attribute, or used

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783 +if (FieldPacked) { + FieldAlign = UnpackedFieldAlign = 1; +} else if (!MaxFieldAlignment.isZero()) { `UnpackedFieldAlign` is used to check if the packed

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() && !FieldSize) -FieldAlign = std::min(FieldAlign, MaxFieldAlignmentInBits); sfertile

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() &&

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

This revision was automatically updated to reflect the committed changes. Closed by commit rG798fe3c774a1: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105635/new/

[PATCH] D103587: [AIX] Define __TOS_AIX__ predefined macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG045872f42203: [AIX] Define __TOS_AIX__ predefined macro (authored by Jake-Egan, committed by stevewan). Changed prior to commit: https://reviews.llvm.org/D103587?vs=349913=356783#toc Repository: rG

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. In D105112#2858702 , @thakis wrote: > Hi, you have to bump clang/include/clang/Serialization/ASTBitCodes.h's > VERSION_MAJOR after adding a LangOption, else builds with > LLVM_APPEND_VC_REV=NO won't invalidate their module

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9964b0ef828b: [clang] Add -fdump-record-layouts-canonical option (authored by daltenty, committed by stevewan). Repository: rG LLVM Github

[PATCH] D105185: [AIX] Add _AIX73 version macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52f34673ead3: [AIX] Add _AIX73 version macro (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. I'm not familiar with `getCanonicalType()`, can you confirm whether it sees through nested typedef's? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bc644aeca8f: Revert [AIX] Avoid structor alias; die before bad alias codegen (authored by Jake-Egan, committed by stevewan). Repository: rG LLVM

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

stevewan added a comment. Might be a dumb question, but I see this is a revert to rGb116ded , do we also want to revert the changes added to `llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp`? Comment at:

[PATCH] D97823: [AIX] Update default arch on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b274ed49960: [AIX] Update default arch on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327825. stevewan added a comment. Reflect varible is unused in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files:

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); jsji wrote: > `micro` unsed. Sorry I missed this comment. I agree

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327803. stevewan added a comment. Improve handling different AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files:

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327798. stevewan added a comment. Address comments with regard to handling older AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files:

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji

[PATCH] D97823: Update default arch on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, the default arch level should match the minimum supported arch level of the OS version Repository: rG LLVM Github Monorepo

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. This LGTM, but since I'm not most familiar with the type 1 failure in description, let's see if other reviewers have further comments. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. In D79842#2138857 , @DavidSpickett wrote: > Right, I see the issue. > > The code that gets the default triple name > (https://reviews.llvm.org/D13340?id=36227#inline-108606) looks up the one you > have in cmake, not the actual

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. Yes, this issue was hit with the reland applied. When given a `--` format LLVM_DEFAULT_TARGET_TRIPLE, Clang would expand the target triple to `---`, and therefore causes the name mismatch between what the driver searches for and what the test case creates as the

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. The test was failing on Linux if I set LLVM_DEFAULT_TARGET_TRIPLE. For example if I set it to`powerpc64le-linux-gnu` clang actually uses "powerpc64le-unknown-linux-gnu". Would you be able to provide a fix to this? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan accepted this revision. stevewan added a comment. LGTM with minor nit. I took a look at the failed tests in premerge checks, they didn't seem to be related, but please double check before you commit. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:195 + // Return

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList , +ArgStringList ) const { stevewan wrote: > I

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList , +ArgStringList ) const { I don't think this is the revision you intended to post.

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG61cd264068ee: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81115: [PowerPC] Do not special case Darwin on PowerPC in target cpu handling

stevewan added a comment. The unit test failure (`instrprof-gcov-multithread_fork.test`) in pre merge checks is caused by another commit. See http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80966: [codeview] Put !heapallocsite on calls to operator new

stevewan added a comment. Looks like this has broken the build bot? (see http://lab.llvm.org:8011/builders/llvm-avr-linux/builds/2205) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80966/new/ https://reviews.llvm.org/D80966

  1   2   >