vitalybuka wrote:
Internally ::allocate uses sided new:
```
void*
allocate(size_t __bytes, size_t __alignment = _S_max_align)
__attribute__((__returns_nonnull__,__alloc_size__(2),__alloc_align__(3)))
{ return ::operator new(__bytes, do_allocate(__bytes, __alignment)); }
```
vitalybuka wrote:
> > > Based on my rough understanding, this is expected?
> >
> >
> > What do you mean?
> > Isn't this test needs to be updated or disabled?
>
> I think this ASAN failure is not caused by this PR because these memorys are
> allocated/deallocated by
100% sure by this PR
vitalybuka wrote:
> Based on my rough understanding, this is expected?
What do you mean?
Isn't this test needs to be updated or disabled?
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
This one is broken https://lab.llvm.org/buildbot/#/builders/168/builds/20461
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Vitaly Buka
Date: 2024-05-19T06:21:40-07:00
New Revision: c587483da0b50efa04146fde205da1d16731e12e
URL:
https://github.com/llvm/llvm-project/commit/c587483da0b50efa04146fde205da1d16731e12e
DIFF:
https://github.com/llvm/llvm-project/commit/c587483da0b50efa04146fde205da1d16731e12e.diff
Author: Vitaly Buka
Date: 2024-05-19T05:44:40-07:00
New Revision: 6447abe067c8088a5cc093fe872719374e174068
URL:
https://github.com/llvm/llvm-project/commit/6447abe067c8088a5cc093fe872719374e174068
DIFF:
https://github.com/llvm/llvm-project/commit/6447abe067c8088a5cc093fe872719374e174068.diff
Author: Vitaly Buka
Date: 2024-05-19T05:44:40-07:00
New Revision: ed9007d0d219726db01f211e9c9ab72fbfe4ecb1
URL:
https://github.com/llvm/llvm-project/commit/ed9007d0d219726db01f211e9c9ab72fbfe4ecb1
DIFF:
https://github.com/llvm/llvm-project/commit/ed9007d0d219726db01f211e9c9ab72fbfe4ecb1.diff
https://github.com/vitalybuka commented:
LGTM
https://github.com/llvm/llvm-project/pull/91032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Greetings and hello from the UK!
>
> it looks as though this commit caused a test failure on the following build
> bot, is anyone able to take a look see?
>
> https://lab.llvm.org/buildbot/#/builders/139/builds/65066
>
> Will give it an hour for a reply before looking at
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/91141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/91141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Yes, its there
but it's too late
we can't cast to enum invalid values
it should be like:
```
unsigned MapType = getOpenMPSimpleClauseType(
OMPC_map, PP.getSpelling(Tok), P.getLangOpts());
if (MapType == OMPC_MAP_to || MapType == OMPC_MAP_from ||
MapType ==
vitalybuka wrote:
```
diff --git a/clang/lib/Parse/ParseOpenMP.cpp b/clang/lib/Parse/ParseOpenMP.cpp
index 53d89ce2fa3e..1a4442f38f6d 100644
--- a/clang/lib/Parse/ParseOpenMP.cpp
+++ b/clang/lib/Parse/ParseOpenMP.cpp
@@ -4326,6 +4326,7 @@ static OpenMPMapClauseKind isMapType(Parser ) {
vitalybuka wrote:
> > 7c28408
>
> good point, maybe not, I scheduled it as with, without rebase. Let's try
> again.
Still fails after rebase https://lab.llvm.org/buildbot/#/builders/5/builds/43115
https://github.com/llvm/llvm-project/pull/90935
___
vitalybuka wrote:
> > BTW, Hi @vitalybuka, do you know how to reproduce the problem with
> > sanitizer build? Thanks.
>
> There is a basic instruction, should work with Linux
> https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild I guess
> this issue should be detectable with
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH] Revert "Revert "[OpenMP][TR12] change property of map-type
vitalybuka wrote:
> 7c28408
good point, maybe not, I scheduled it as with, without rebase.
Let's try again.
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
> Looks broken
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
This is special build from this PR see `git status` here
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
https://github.com/vitalybuka requested changes to this pull request.
Looks broken
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
vitalybuka wrote:
Please include this fix into re-land.
https://github.com/llvm/llvm-project/pull/90800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> BTW, Hi @vitalybuka, do you know how to reproduce the problem with sanitizer
> build? Thanks.
There is a basic instruction, should work with Linux
https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
I guess this issue should be detectable with appropriate
vitalybuka wrote:
Oh, it's not landed. I looked at wrong PR. Lets revert if it can't be landed
soon.
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
> How long do you need?
Looks like it's landed.
Thanks!
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> I already has patch in #90800 waiting for test to finish.
Fix forward is good for something < 1H, but looks like you started 19H ago.
Such cases must be reverted and then fixed.
How long do you need?
https://github.com/llvm/llvm-project/pull/90885
vitalybuka wrote:
I am not sure what should be a correct fix, so I'll revert?
https://github.com/llvm/llvm-project/pull/90499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/90885
Breaks
https://lab.llvm.org/buildbot/#/builders/5/builds/43086/steps/9/logs/stdio
Reverts llvm/llvm-project#90499
>From a6ca95f5e2991fb7f857f70436148a6abdecec00 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
vitalybuka wrote:
Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/43086
https://github.com/llvm/llvm-project/pull/90499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Thanks a lot, that was quick! There is another AddressSanitizer issue that
> may possibly be fixed by #90292. cc @vitalybuka
Yes, please wait for #90292.
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing
https://github.com/vitalybuka demilestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka milestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Lets revert #90299 to recover bots before the weekend.
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/90299
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
This reverts commit cf5a8b489464d09dfdd7a48ce7c8b41d3c9bf819.
>From b4c0a3f4835a686a15a3ed90a4058f353f844f26 Mon Sep 17 00:00:00 2001
From: Vitaly
vitalybuka wrote:
It's LGTM, but it's going to be annoying to merge.
I bet this patch has several reasons to be reverted, and will be reverted
multiple times.
It would be nice to try to split into smaller parts.
https://github.com/llvm/llvm-project/pull/81677
@@ -35,6 +35,9 @@
// RUN: %p/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc
\
// RUN: | grep -e "INTERFACE_\(WEAK_\)\?FUNCTION"
\
// RUN: | grep -v "__sanitizer_weak_hook"
\
+//
vitalybuka wrote:
Delete uses __get_long_cap()
```
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void
__set_long_cap(size_type __s) _NOEXCEPT {
__r_.first().__l.__cap_ = __s / __endian_factor;
__r_.first().__l.__is_long_ = true;
}
_LIBCPP_HIDE_FROM_ABI
vitalybuka wrote:
@ldionne looks like a bug in std::string
```
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -1123,7 +1123,7 @@ public:
inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() {
__annotate_delete();
if (__is_long())
-
vitalybuka wrote:
This is causing new/delete mismatch
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
```
=
==2164144==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x503035b0
in thread T0:
object passed to
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/87568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/89006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> I would not run clang-format on the revert
Done. Reverted to github generated 1d59298
https://github.com/llvm/llvm-project/pull/89006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/89006
>From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 16 Apr 2024 17:23:47 -0700
Subject: [PATCH 1/2] Revert "Improve stack usage to increase recursive
@@ -1163,12 +1136,7 @@ class Sema;
ConversionSequenceList
allocateConversionSequences(unsigned NumConversions) {
ImplicitConversionSequence *Conversions =
- slabAllocate(NumConversions);
-
- // Construct the new objects.
- for (unsigned I = 0;
vitalybuka wrote:
have ideas about leak, but not sure what to do with perf regression and #88330
Proposing revert https://github.com/llvm/llvm-project/pull/89006
https://github.com/llvm/llvm-project/pull/88546
___
cfe-commits mailing list
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/89006
Reverts llvm/llvm-project#88546
Leak and performance regression.
Details in #88546
>From 1d59298cd9ed21e1ac860d64f965514a577f45bb Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 16 Apr 2024 17:23:47
vitalybuka wrote:
A new memory leak https://lab.llvm.org/buildbot/#/builders/5/builds/42694
https://github.com/llvm/llvm-project/pull/88546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -3233,6 +3233,17 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl,
unsigned BuiltinID,
if (BuiltinCountZeroBitsGeneric(*this, TheCall))
return ExprError();
break;
+
+ case Builtin::BI__builtin_allow_runtime_check: {
+Expr *Arg = TheCall->getArg(0);
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/87568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/87568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3464,6 +3464,34 @@ Query for this feature with
``__has_builtin(__builtin_trap)``.
``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and
then to ``brk #payload``.
+``__builtin_allow_runtime_check``
vitalybuka wrote:
Similar
@@ -3464,6 +3464,34 @@ Query for this feature with
``__has_builtin(__builtin_trap)``.
``__builtin_arm_trap`` is lowered to the ``llvm.aarch64.break`` builtin, and
then to ``brk #payload``.
+``__builtin_allow_runtime_check``
vitalybuka wrote:
Not sure how
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/87568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/88116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
ok
please paste here what ever looks like real failure from the patch
buildbot does not sent me, as I am not on the blame list
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I'll land after presubmit checks
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka commented:
Fail i386
```
UBSan-AddressSanitizer-i386 ::
TestCases/ImplicitConversion/bitfield-conversion.c
UBSan-Standalone-i386 :: TestCases/ImplicitConversion/bitfield-conversion.c
```
https://github.com/llvm/llvm-project/pull/87761
vitalybuka wrote:
This is fixed version of https://github.com/llvm/llvm-project/pull/75481 ?
https://github.com/llvm/llvm-project/pull/87761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/83470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
abandoning
https://github.com/llvm/llvm-project/pull/83470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I changed my design, so I don't need that change as is.
Given https://godbolt.org/z/4KfEKq7zb, I can revert your patch, or just leave
it as is. I have no preference.
https://github.com/llvm/llvm-project/pull/83470
___
cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/87436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I will land, and address followup comments, if any.
It does not change behavior without -mllvm flags.
https://github.com/llvm/llvm-project/pull/87436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84853
>From d98585586148f2084e36d06996d6c9190cec57d7 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 11 Mar 2024 16:32:06 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3805,6 +3812,12 @@ void CodeGenFunction::EmitTrapCheck(llvm::Value *Checked,
SanitizerHandler CheckHandlerID) {
llvm::BasicBlock *Cont = createBasicBlock("cont");
+ if (ClSanitizeExpHot) {
+Checked =
+
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84858
>From 014644897f25ed88a1e17192531cf92110758470 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 11 Mar 2024 16:58:15 -0700
Subject: [PATCH] [clang][ubsan] Switch UBSAN optimization to
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/87436
>From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 2 Apr 2024 17:18:58 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
Author: Vitaly Buka
Date: 2024-04-04T15:54:54-07:00
New Revision: 96a99a5e2f62475f13d7ba18b15acad733909e7f
URL:
https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f
DIFF:
https://github.com/llvm/llvm-project/commit/96a99a5e2f62475f13d7ba18b15acad733909e7f.diff
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/87436
>From eec9a27ff0451b923d8ca7d4ff23eb6b8dffa56c Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Tue, 2 Apr 2024 17:18:58 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
Author: Vitaly Buka
Date: 2024-04-03T17:48:25-07:00
New Revision: abd05eb4a53e6c7760496620da417733f52d4bf9
URL:
https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9
DIFF:
https://github.com/llvm/llvm-project/commit/abd05eb4a53e6c7760496620da417733f52d4bf9.diff
Author: Vitaly Buka
Date: 2024-04-02T15:47:04-07:00
New Revision: 633bc3bfda71c55bc38d5a3bfdb426bab61ff101
URL:
https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101
DIFF:
https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101.diff
vitalybuka wrote:
This failure is caused by the patch
https://lab.llvm.org/buildbot/#/builders/239/builds/6363/steps/10/logs/stdio
cc @hctim
https://github.com/llvm/llvm-project/pull/65742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
This failure is caused by the patch
https://lab.llvm.org/buildbot/#/builders/239/builds/6363/steps/10/logs/stdio
https://github.com/llvm/llvm-project/pull/87238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Vitaly Buka
Date: 2024-04-01T13:37:42-07:00
New Revision: e93b5f5a4776ffea12d03652559dfdf8d421184c
URL:
https://github.com/llvm/llvm-project/commit/e93b5f5a4776ffea12d03652559dfdf8d421184c
DIFF:
https://github.com/llvm/llvm-project/commit/e93b5f5a4776ffea12d03652559dfdf8d421184c.diff
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/87213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/87213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/87213
`RHS` can be shorter than `LHS`.
Reported by asan after #83440.
>From a6d57814761cb74de98b40a4cc3acdd9b262e854 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Sun, 31 Mar 2024 18:42:25 -0700
Subject:
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/86772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/86772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> ah I see. I feel like this should be a more principled approach that other
> sanitizers also share, as you've mentioned as an alternative. do people not
> care about other sanitizers in production?
Actually Asan should not exhibit this behavior, by some lack it does not
https://github.com/vitalybuka converted_to_draft
https://github.com/llvm/llvm-project/pull/86739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Looked into IR and HWASAN instrument stuff which it should not
https://godbolt.org/z/MnYs75Meq
Should be easy to fix.
https://github.com/llvm/llvm-project/pull/86739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
vitalybuka wrote:
> I think I'm still confused on exactly what the use case is and why we can't
> just ask the user to not specify hwasan in the PGO instrumented build. Just
> for user convenience? Or does clang change the emitted IR when hwasan is
> enabled? And that's what will lead to
vitalybuka wrote:
Alternative is we need a new clang fronted flag to control this behavior.
Assuming that this is rather strange use case, I'd prefer to land the patch and
introduce new flag only when we have request for that case.
https://github.com/llvm/llvm-project/pull/86739
vitalybuka wrote:
We already have similar stuff:
```
if (PGOOpt && Phase != ThinOrFullLTOPhase::ThinLTOPostLink &&
!PGOOpt->MemoryProfile.empty())
MPM.addPass(MemProfUsePass(PGOOpt->MemoryProfile, PGOOpt->FS));
```
https://github.com/llvm/llvm-project/pull/86739
vitalybuka wrote:
> > > why can't hwasan and PGO instrumentation coexist?
> >
> >
> > They can, but binary is like 5x times slower, on top of 10x slowdown of PGO
> > instrumentation. (don't quote me on these numbers, they are from large but
> > single benchmark, still it's very slow)
>
> If
vitalybuka wrote:
> why can't hwasan and PGO instrumentation coexist?
They can, but binary is like 5x times slower, on top of 10x slowdown of PGO
instrumentation.
>
> and this seems like it should be an error at the clang driver level, instead
> of silently turning off one of the requested
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/86739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 669 matches
Mail list logo
