[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362161. stephan.yichao.zhao added a comment. typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files: clang/docs/DataFlowSanitizerDesign.rst

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362159. stephan.yichao.zhao added a comment. tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files: clang/docs/DataFlowSanitizerDesign.rst

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao updated this revision to Diff 362158. stephan.yichao.zhao added a comment. explained what a trace and a chain are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106903/new/ https://reviews.llvm.org/D106903 Files:

[PATCH] D106903: [dfsan][NFC] Describe how origin trace tracking works

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106903 Files:

[PATCH] D106895: [dfsan][NFC] Update API interfaces

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106895 Files:

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

stephan.yichao.zhao updated this revision to Diff 361859. stephan.yichao.zhao marked 2 inline comments as done. stephan.yichao.zhao retitled this revision from " [dfsan][NFC] Add compile flags and environment variables to doc" to "[dfsan][NFC] Add compile flags and environment variables to doc".

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106833 Files:

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao added a comment. In D105378#2861914 , @morehouse wrote: > We may also want to consider creating a frontend flag like MSan's origin > tracking (`-fsanitize-memory-track-origins`). I will follow up this in a separate change.

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao updated this revision to Diff 357004. stephan.yichao.zhao marked an inline comment as done. stephan.yichao.zhao retitled this revision from " [dfsan][NFC] Add Origin Tracking into doc" to "[dfsan][NFC] Add Origin Tracking into doc". stephan.yichao.zhao added a comment. clang

[PATCH] D105378: [dfsan][NFC] Add Origin Tracking into doc

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: morehouse. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105378 Files:

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added a comment. Thank you for making this work! Comment at: compiler-rt/lib/dfsan/dfsan.cpp:871 + +static void CheckMemoryLayoutSanity() { + uptr prev_end = 0; Please add a comment about that these CheckMemoryLayoutSanity, ... and

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:169 +// TODO(browneee): Removed this after testing and not hit. +CHECK(MEM_IS_SHADOW(s)); +// if (!MEM_IS_SHADOW(s)) { Based on the recent issue about using a

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

stephan.yichao.zhao added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm); Based on

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added a comment. How did we fix that alignment error from compiler-rt/test/dfsan/origin_ldst.c? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103745/new/ https://reviews.llvm.org/D103745

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added inline comments. Comment at: clang/docs/DataFlowSanitizer.rst:172-178 assert(ij_label == 3); // Verifies all of the above +// Or, equivalently: +assert(dfsan_has_label(ij_label, i_label)); +assert(dfsan_has_label(ij_label, j_label));

[PATCH] D103745: [dfsan] Add full fast8 support

stephan.yichao.zhao added a comment. The failed test cases from x64 debian > libFuzzer.libFuzzer::* seem related. They still use -dfsan-fast-16-labels. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103745/new/ https://reviews.llvm.org/D103745