This revision was automatically updated to reflect the committed changes.
mizvekov marked an inline comment as done.
Closed by commit rG0c7cd4a87313: [clang] NFC: refactor multiple implementations
of… (authored by mizvekov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaronpuchert accepted this revision.
aaronpuchert added a comment.
This revision is now accepted and ready to land.
It is a good name!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100713/new/
https://reviews.llvm.org/D100713
mizvekov marked 2 inline comments as done.
mizvekov added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:5845
+ if (!To->isRValue()) {
+QualType T = Self.Context.getDecltypeForParenthesizedExpr(To);
InitializedEntity Entity =
mizvekov updated this revision to Diff 362257.
mizvekov added a comment.
- rename to getReferenceQualifiedType.
- Move the null expression special case out of the function, back to the
original user.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rsmith added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:5461
+QualType ASTContext::getDecltypeForParenthesizedExpr(const Expr *e) const {
+ if (!e)
+return VoidTy;
This check doesn't seem like it belongs here.
Comment at:
