[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a comment. @effective-light just FYI, if you are interested in improving fast-math flags handling during matrix lowering on the LLVM side, there's https://bugs.llvm.org/show_bug.cgi?id=49738 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe2277fbf233: [Matrix] Support #pragma clang fp (authored by effective-light, committed by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn accepted this revision. fhahn added a comment. LGTM, thanks! I'll commit the patch shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 ___

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light added a comment. In D100834#2704330 , @fhahn wrote: > In D100834#2702550 , @kpn wrote: > >> I don't know the matrix implementation so I can't swear this hits every >> place needed, but the uses

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 339325. effective-light added a comment. Add a test for compound operations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files:

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a comment. In D100834#2702550 , @kpn wrote: > I don't know the matrix implementation so I can't swear this hits every place > needed, but the uses of CGFPOptionsRAII in this patch look correct at least. Other parts of the extension include

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 339048. effective-light added a comment. Use the correct clang command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files:

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 339012. effective-light added a comment. Fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

kpn added a comment. I don't know the matrix implementation so I can't swear this hits every place needed, but the uses of CGFPOptionsRAII in this patch look correct at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 338941. effective-light added a comment. Whoops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files: clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

mibintc added a comment. The diff appears to be 2 separate commits, so on first glance this is only patching the test files. Usually if I am working on a patch and have responded to comments, I compress the patch+updates into a single commit (git rebase -i) before creating a diff to upload to

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light updated this revision to Diff 338812. effective-light added a comment. Remove the unnecessary flags and add another test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100834/new/ https://reviews.llvm.org/D100834 Files:

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

fhahn added a reviewer: mibintc. fhahn added a subscriber: mibintc. fhahn added a comment. Awesome, thanks for the patch! I'm also adding @mibintc who I think was working on adding support for the pragma & co. Could you add a brief description to the patch and also reference the bug report on

[PATCH] D100834: Bug 49739 - [Matrix] Support #pragma clang fp

effective-light created this revision. Herald added a subscriber: tschuett. effective-light requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100834 Files: