[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-10-13 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan abandoned this revision. urnathan added a comment. Implemented as part of D102645 , thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102650/new/ https://reviews.llvm.org/D102650

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-10-13 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan commandeered this revision. urnathan edited reviewers, added: rsmith; removed: urnathan. urnathan added a comment. Taking control to close it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102650/new/ https://reviews.llvm.org/D102650

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-25 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: MaskRay, mehdi_amini. dblaikie added a comment. In D102650#2779193 , @urnathan wrote: > dblaikie, do you know if there's a way to do it outside of arc? (for reasons, > I've not got arc to work from inside work). I tried not

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-25 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan added a comment. dblaikie, do you know if there's a way to do it outside of arc? (for reasons, I've not got arc to work from inside work). I tried not setting a reviewer, but then that got autofilled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-24 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. FWIW, there's some way to post reviews in draft form (I think via arc --draft or something like that) - which would ensure that emails for the review aren't sent to the -commits mailing list for something you don't want folks on the -commits list to review just yet,

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

2021-05-17 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: urnathan. Herald added a subscriber: jfb. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102650 Files: