[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

ssarda added a comment. Herald added a project: All. This patch is causing issue mentioned in https://discourse.llvm.org/t/sema-section-type-conflict/66000 @chill can you check once? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

mstorsjo added a comment. I ran into a regression caused by this change, see https://bugs.llvm.org/show_bug.cgi?id=51442. This breaks building Qt tests with LLVM 13. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21aa107eb79f: Reland Do not create LLVM IR `constant`s for objects with dynamic… (authored by chill). Repository: rG LLVM Github Monorepo

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

chill updated this revision to Diff 347631. chill added a comment. This revision is now accepted and ready to land. Updated a test to run for `x86_64-linux` instead of `%itanium_abi_triple`, to avoid having invalid syntax for MACH-O sections. The patch itself does not care about section

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

chill added a comment. Thanks, I'll have a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

thakis added a comment. reverted in d881319cc5606baa7668405a296d0960a83a1e4c for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/ https://reviews.llvm.org/D102693

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

haowei added a comment. This CL breaks our mac builders as well. Could you either fix the test or revert the change please? Error message: TEST 'Clang :: CodeGenCXX/const-dynamic-init.cpp' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/10125/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102693/new/

[PATCH] D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation

This revision was automatically updated to reflect the committed changes. Closed by commit rG13dd65b3a1a3: Do not create LLVM IR `constant`s for objects with dynamic initialisation (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM