[PATCH] D103048: [IR] make -stack-alignment= into a module attr

bgamari added a comment. Herald added a project: All. @nickdesaulniers, this appears to be missing the corresponding documentation in the LLVM language reference. As someone who maintains GHC 's LLVM backend, this documentation is invaluable. Repository: rG LLVM

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

ro added a comment. One test `FAILs` on Solaris/sparcv9: LLVM :: CodeGen/Generic/ForceStackAlign.ll with LLVM ERROR: Function "g" required stack re-alignment, but LLVM couldn't handle it (probably because it has a dynamic alloca). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3787ee457173: reland [IR] make -stack-alignment= into a module attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. I've retested with all backends enabled; all green now. Changes added to: - llvm/lib/Target/Mips/MipsCallLowering.cpp - llvm/lib/Target/Mips/MipsTargetMachine.cpp - llvm/test/CodeGen/Mips/stack-alignment.ll Planning to recommit now. Repository: rG LLVM

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers updated this revision to Diff 350660. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added subscribers: atanasyan, sdardis. - fixes for MIPS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG433c8d950cb3: [IR] make -stack-alignment= into a module attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. Thanks for the review! Notified downstream dependents: - https://github.com/llvm-hs/llvm-hs/issues/345 - https://github.com/halide/Halide/issues/6079 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/test/Linker/stack-alignment.ll:11 +;--- main.ll +; NONE: error: linking module flags 'override-stack-alignment': IDs have conflicting values +;

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers updated this revision to Diff 350443. nickdesaulniers added a comment. - remove test for module without module attr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/ https://reviews.llvm.org/D103048 Files:

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added inline comments. Comment at: llvm/test/Linker/stack-alignment.ll:11 +;--- main.ll +; NONE: error: linking module flags 'override-stack-alignment': IDs have conflicting values +; CHECK-16: error: linking module flags 'override-stack-alignment': IDs have

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. In D103048#2795456 , @tejohnson wrote: >> Curiously, using ModFlagBehavior::Error doesn't error if one of two modules >> being linked together doesn't have such a module level attribute. > > Yeah, there's a Require

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

tejohnson added a comment. Herald added a subscriber: ormris. > Curiously, using ModFlagBehavior::Error doesn't error if one of two modules > being linked together doesn't have such a module level attribute. Yeah, there's a Require behavior, but that only allows you to specify what the value

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers added a comment. bumping for review (or suggestions of additional reviewers) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103048/new/ https://reviews.llvm.org/D103048 ___ cfe-commits

[PATCH] D103048: [IR] make -stack-alignment= into a module attr

nickdesaulniers created this revision. nickdesaulniers added reviewers: tejohnson, craig.topper, RKSimon. Herald added subscribers: dexonsmith, pengfei, hiraditya, qcolombet. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: