[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd54e7b731e66: [OpenCL] Add memory_scope_all_devices (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Considering that this patch doesn't add anything new to the design, I suggest we go ahead. But we should continue the discussion around -cl-ext etc elsewhere and then

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348309. svenvh added a comment. Restrict feature macro definition to SPIR target only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348245. svenvh edited the summary of this revision. svenvh added a comment. Update change to be header-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30)

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the `memory_scope_all_devices` enum value, which is