sammccall added a comment.
We discussed this a bit offline, and IIUC the plan is not to push this through
at least for now. Notes:
- path to a file is more accurate/informative than spelling, since it really is
the file rather than the name that is restricted
- however in practice the spelling
kadircet added a comment.
It is the absolute path of the header. e.g:
`module TestTU does not depend on a module exporting
'/work/llvm/clang-tools-extra/clangd/AST.h'`
rather than
`module TestTU does not depend on a module exporting 'AST.h'`
Repository:
rG LLVM Github Monorepo
CHANGES
sammccall added a subscriber: rsmith.
sammccall added a comment.
This seems sensible to me but hard to know if it's going to be an improvement
in practice. Can you paste a realistic example?
@rsmith any opinion about this diag?
Comment at:
kadircet updated this revision to Diff 350288.
kadircet added a comment.
- handle windows paths in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103797/new/
https://reviews.llvm.org/D103797
Files:
clang/lib/Lex/ModuleMap.cpp
kadircet created this revision.
kadircet requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A header spelling in a source file could potentially mean multiple
sources, especially in projects with multiple include search paths. We
try to
