This revision was automatically updated to reflect the committed changes.
Closed by commit rG4b219051a331: Fix undeduced type assert (authored by
serge-sans-paille).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
serge-sans-paille added a comment.
@rsmith : gentle ping ;-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103849/new/
https://reviews.llvm.org/D103849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM as far as the fix seems like an improvement, though I'm not 100%
certain that the fix is in the right place. Please give a few more days for
@rsmith to consider the
serge-sans-paille added a comment.
@rsmith : any opinion on that one?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103849/new/
https://reviews.llvm.org/D103849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
I think this is reasonable, but I'd like to hear from @rsmith before landing
this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103849/new/
https://reviews.llvm.org/D103849
___
cfe-commits mailing list
serge-sans-paille updated this revision to Diff 351191.
serge-sans-paille added a comment.
Added test + fix suggested by @aaron.ballman
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103849/new/
https://reviews.llvm.org/D103849
Files:
clang/lib/AST/Expr.cpp
aaron.ballman edited subscribers, added: cfe-commits; removed: rsmith.
aaron.ballman added a comment.
Adding the mailing lists to the review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103849/new/
https://reviews.llvm.org/D103849
___
