[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. serge-sans-paille marked 2 inline comments as done. Closed by commit rGa0d05ed84899: Handle interactions between reserved identifier and user-defined suffixes

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

aaron.ballman added a comment. > Does that look good to you? That fix-it looks correct to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2639 // or a ud-suffix from the string literal. +const bool isUDSuffix = !Literal.getUDSuffix().empty(); IdentifierInfo *II = nullptr; Minor style nits

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352938. serge-sans-paille added a comment. Reviews taken into account, I'm just not 100% sure of the fixit part. The out is the following: a.cpp:4:16: warning: identifier '_Bye' is reserved because it starts with '_' followed by a capital

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good. Just some minor comments. Comment at: clang/include/clang/Sema/Sema.h:4132 + bool checkLiteralOperatorId(const CXXScopeSpec , const UnqualifiedId , +

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352423. serge-sans-paille added a comment. Tried another not-so-intrusive approach. @rsmith? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Sema/Sema.h

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

rsmith added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:125 + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1; + This is per-declaration state; I don't think

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:124 - // 28 bits left in a 64-bit word. + // True if this identifier is a literal operator without whitespace. + unsigned IsLiteralOperatorWithoutWhitespace : 1;

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille updated this revision to Diff 352146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104299/new/ https://reviews.llvm.org/D104299 Files: clang/include/clang/Basic/IdentifierTable.h clang/lib/Basic/IdentifierTable.cpp clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. Herald added a subscriber: dexonsmith. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a