[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-23 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D104342#2836222 , @aaron.ballman wrote: > In D104342#2834240 , @dblaikie > wrote: > >> In D104342#2834119 , >> @nickdesaulniers wrote: >>

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D104342#2834240 , @dblaikie wrote: > In D104342#2834119 , > @nickdesaulniers wrote: > >> I would think >>

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-22 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. In D104342#2834119 , @nickdesaulniers wrote: > In D104342#2831738 , @dblaikie > wrote: > >>> In D104342#2831717

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-22 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D104342#2831738 , @dblaikie wrote: >> In D104342#2831717 , @dblaikie >> wrote: >> >>> Probably worth at least writing up the risk/instability in the docs for the >>> warning

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D104342#2831733 , @nickdesaulniers wrote: > In D104342#2831717 , @dblaikie > wrote: > >> I don't know that there's a good answer (in more extreme cases - like >> different

[PATCH] D104342: [IR] convert warn-stack-size from module flag to fn attr

2021-06-21 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 353499. nickdesaulniers marked 2 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - fix langref, delete inline and linker tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST