This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG186f2ac612ad: [HIP] Add support functions for C++
polymorphic types (authored by yaxunl).
Changed prior to commit:
scchan updated this revision to Diff 353041.
scchan added a comment.
Minor clean up in the hip-header.hip test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104392/new/
https://reviews.llvm.org/D104392
Files:
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks! pls remove the extra line when committing.
Comment at: clang/test/Headers/hip-header.hip:88
}
+
extrac line
Repository:
rG LLVM Github
scchan updated this revision to Diff 353035.
scchan added a comment.
Adding test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104392/new/
https://reviews.llvm.org/D104392
Files:
clang/lib/Headers/__clang_hip_runtime_wrapper.h
yaxunl added a comment.
can you add a test to
https://github.com/llvm/llvm-project/blob/main/clang/test/Headers/hip-header.hip
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104392/new/
https://reviews.llvm.org/D104392
scchan created this revision.
scchan added a reviewer: yaxunl.
scchan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add runtime functions to detect invalid calls to pure or deleted virtual
functions
Repository:
rG LLVM Github