[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

2021-06-22 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf53d791520d8: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in… (authored by MaskRay). Repository: rG LLVM Github

[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

2021-06-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 353510. MaskRay added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104667/new/ https://reviews.llvm.org/D104667 Files: clang/test/Misc/backend-resource-limit-diagnostics.cl

[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

2021-06-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Misc/backend-resource-limit-diagnostics.cl:4 -// CHECK: error: local memory limit exceeded (48) in use_huge_lds +// CHECK: error: local memory (48) exceeds limit in function 'use_huge_lds' kernel void

[PATCH] D104667: Improve the diagnostic of DiagnosticInfoResourceLimit (and warn-stack-size in particular)

2021-06-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 353497. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. stack size -> stack frame size The former is ambiguous (it could mean the full stack size). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST