[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

2021-07-27 Thread Sid Manning via Phabricator via cfe-commits
sidneym added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); bcain wrote: > MaskRay wrote: > > To match Linux.cpp, this code block

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

2021-07-26 Thread Brian Cain via Phabricator via cfe-commits
bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); MaskRay wrote: > To match Linux.cpp, this code block should be

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

2021-07-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch. This makes the behavior closer to Linux.cpp . Request changes to clear my queue before a test is added... Comment at:

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

2021-07-23 Thread Brian Cain via Phabricator via cfe-commits
bcain added a comment. This patch is so far just for discussion, still needs tests, etc. The motivation for this patch is to be able to include the intrinsic header files installed in the resource dir. I've taken inspiration from `ToolChains/Linux.cpp` here. Repository: rG LLVM Github

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

2021-07-23 Thread Brian Cain via Phabricator via cfe-commits
bcain created this revision. bcain added reviewers: sidneym, MaskRay. bcain requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106737 Files: clang/lib/Driver/ToolChains/Hexagon.cpp Index: