[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen closed this revision. steffenlarsen marked an inline comment as done. steffenlarsen added a comment. In D107054#3141285 , @tra wrote: > I think this patch has been obsoleted by https://reviews.llvm.org/D113249 > which has already landed. >

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I think this patch has been obsoleted by https://reviews.llvm.org/D113249 which has already landed. My apologies for letting the patch slip through the cracks. CHANGES SINCE LAST ACTION

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

bader added a comment. Herald added subscribers: carlosgalvezp, asavonic. @tra, ping. @steffenlarsen, does it make sense to add support for recently released 11.5 as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107054/new/ https://reviews.llvm.org/D107054

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen marked an inline comment as done. steffenlarsen added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:821 #pragma pop_macro("PTX71") #pragma pop_macro("PTX72") tra wrote: > You need to pop new macros here. My bad! It has

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen updated this revision to Diff 362986. steffenlarsen added a comment. Made sure the PTX73 and PTX74 macros are popped correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107054/new/ https://reviews.llvm.org/D107054 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:821 #pragma pop_macro("PTX71") #pragma pop_macro("PTX72") You need to pop new macros here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions

steffenlarsen created this revision. steffenlarsen added a reviewer: tra. Herald added subscribers: dexonsmith, hiraditya, yaxunl, jholewinski. steffenlarsen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adds missing