[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3066853 , @jansvoboda11 wrote: > This seems to be breaking the macOS bot, can you take a look? > https://green.lab.llvm.org/green/job/clang-stage1-RA/24735/ Will do. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

jansvoboda11 added a comment. This seems to be breaking the macOS bot, can you take a look? https://green.lab.llvm.org/green/job/clang-stage1-RA/24735/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97809c828f8e: [AArch64]Enabling Cortex-A510 Support (authored by mubashar_, committed by lenary). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added inline comments. Comment at: clang/docs/ReleaseNotes.rst:86 +- Support has been added for the following processors (command-line identifiers in parentheses): + - Arm Cortex-A510 (cortex-a510) dmgreen wrote: > dmgreen wrote: > > Can you add an

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks for the changes. Nice working pulling this into shape. LGTM Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:149 + (AArch64::AEK_BF16

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ marked an inline comment as done. mubashar_ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:86 +- Support has been added for the following processors (command-line identifiers in parentheses): + - Arm Cortex-A510 (cortex-a510)

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379717. mubashar_ marked an inline comment as done. mubashar_ added a comment. Corrected PAUTH duplication mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379713. mubashar_ marked 2 inline comments as done. mubashar_ added a comment. Added crypto and no-crypto tests for -mcpu and added new section for Arm and AArch64 support in release notes. CHANGES SINCE LAST ACTION

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen added a comment. In D109825#3060796 , @mubashar_ wrote: > Added crypto and non-crypto related tests for mcpu in aarch64-cpus.c Thanks, but did this change miss being updated in the review? Comment at:

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 379321. mubashar_ added a comment. Added crypto and non-crypto related tests for mcpu in aarch64-cpus.c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen added a comment. Thanks for the updates. In D109825#3055264 , @lenary wrote: > In D109825#3055142 , @xgupta wrote: > >> It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases >> changes,

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. oh thanks for the clarification, I am not aware of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3055142 , @xgupta wrote: > It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases > changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). I'm not convinced this is required -

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 378645. mubashar_ added a comment. Added files that were missing from previous diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ added a comment. @xgupta I followed the request review via web interface section of that page. Let me look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Yeah, those changes are in history, But we need them in the present to commit :) The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ added a comment. @xgupta those would be under the history tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Where are the other patches? Or diff is not uploaded correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 378216. mubashar_ marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: llvm/include/llvm/Support/AArch64TargetParser.def

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM added a comment. In D109825#3001622 , @dmgreen wrote: >> As I did the downstream work for this, I'm happy with it to go in in this >> form. > > This doesn't seem.. wise. Please make sure the reviews you do are at a > sufficient quality,

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ updated this revision to Diff 372698. mubashar_ added a comment. Updated release notes to solve a merge conflict. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 Files: clang/docs/ReleaseNotes.rst

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

dmgreen requested changes to this revision. dmgreen added a comment. This revision now requires changes to proceed. > As I did the downstream work for this, I'm happy with it to go in in this > form. This doesn't seem.. wise. Please make sure the reviews you do are at a sufficient quality, and

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. As I did the downstream work for this, I'm happy with it to go in in this form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

mubashar_ created this revision. mubashar_ added a reviewer: MarkMurrayARM. Herald added subscribers: hiraditya, kristof.beyls. mubashar_ requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch enables support for