This revision was automatically updated to reflect the committed changes.
Closed by commit rGecef0359538c: [Driver][NetBSD] Use Triple reference instead
of ToolChain.getTriple(). (authored by fcambus).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
fcambus marked an inline comment as done.
fcambus added a comment.
Yes, I rebuilt everything with the updated diff and ran `check-clang-driver`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111805/new/
https://reviews.llvm.org/D111805
___
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
LGTM (I'm presuming you've tested it and not testing it myself ;-)).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111805/new/
https://reviews.llvm.org/D111805
fcambus marked an inline comment as done.
fcambus added inline comments.
Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:35
const Driver = ToolChain.getDriver();
+ const llvm::Triple = ToolChain.getTriple();
mgorny wrote:
> Is there a specific reason
fcambus updated this revision to Diff 379934.
fcambus added a comment.
Use 'Triple' instead of 'T'.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111805/new/
https://reviews.llvm.org/D111805
Files:
clang/lib/Driver/ToolChains/NetBSD.cpp
Index:
mgorny added inline comments.
Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:35
const Driver = ToolChain.getDriver();
+ const llvm::Triple = ToolChain.getTriple();
Is there a specific reason to choose the name `T`? FWICS different drivers use
fcambus created this revision.
fcambus added reviewers: krytarowski, mgorny.
Herald added a subscriber: fedor.sergeev.
fcambus requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
