This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a8c7946fc3a: [clang] Allocate 2 bits to store the constexpr
specifier kind when serializing (authored by nridge).
Repository:
rG LLVM Github
adamcz accepted this revision.
adamcz added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111971/new/
https://reviews.llvm.org/D111971
nridge requested review of this revision.
nridge added a comment.
Sorry for the delay here.
@adamcz could you kindly have another look to make sure the test changes look
ok?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111971/new/
nridge updated this revision to Diff 387057.
nridge added a comment.
Reworked test to use the framework in clang/test/AST
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111971/new/
https://reviews.llvm.org/D111971
Files:
adamcz accepted this revision.
adamcz added a comment.
This revision is now accepted and ready to land.
Fix LGTM
As for the test, I suggest putting it in clang/test/AST/, maybe in
ast-dump-constant-expr? You can write a CHECK-NEXT: thingy to verify that
consteval is preserved. The test already
nridge added a comment.
Not sure if clangd is the best place to test this. I'm open to other
suggestions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111971/new/
https://reviews.llvm.org/D111971
___
nridge created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
nridge requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
Now that consteval and constinit are possible values, 1 bit
is no longer
