This revision was automatically updated to reflect the committed changes.
Closed by commit rGa075d6722283: [Sema] fix nondeterminism in
ASTContext::getDeducedTemplateSpecializationType (authored by weiwang).
Changed prior to commit:
https://reviews.llvm.org/D112481?vs=382375=388616#toc
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
This is good to go, sorry for the delay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
sugak added a comment.
ping @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
weiwang added a comment.
This issue has been blocking our internal module re-enablement for some time
now, and we really appreciate any feedback. We also wonder if only
`DeducedTemplateSpecializationType` is affected or it could also happen to
other types.
Repository:
rG LLVM Github
sugak updated this revision to Diff 382375.
sugak added a comment.
Updated following @bruno's suggestion, and fixed tests (thanks @weiwang)!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
Files:
sugak added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:5640
+ DeducedTemplateSpecializationType::Profile(
+ ID, Template, DeducedType, IsDependent || Template.isDependent());
if (DeducedTemplateSpecializationType *DTST =
bruno wrote:
>
bruno added a reviewer: bruno.
bruno added a comment.
Nice catch, thanks for working on this!
Comment at: clang/lib/AST/ASTContext.cpp:5640
+ DeducedTemplateSpecializationType::Profile(
+ ID, Template, DeducedType, IsDependent || Template.isDependent());
if
sugak updated this revision to Diff 382109.
sugak added a comment.
apply clang-format suggestion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112481/new/
https://reviews.llvm.org/D112481
Files:
clang/lib/AST/ASTContext.cpp
Index:
sugak created this revision.
sugak added a reviewer: rsmith.
Herald added a subscriber: mgrang.
sugak requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`DeducedTemplateSpecializationTypes` is a
`llvm::FoldingSet` [1], where
