[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:1251-1260 + const IncludedFilesSet *getNullSubmoduleIncludes() const { +auto It = IncludedFilesPerSubmodule.find(nullptr); +return It == IncludedFilesPerSubmodule.end() ? nullptr :

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 403263. jansvoboda11 added a comment. Rebase, update unnecessary `auto`, run `clang-format` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added a comment. Can you please rebase this change after D114095 lands? Overall looks good but I want to take one final look and triggering the pre-merge checks will be useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 added a comment. In D112915#3141417 , @vsapsai wrote: > I think AST format for `IncludedFiles` was discussed here, so I'll continue > here though the bulk of implementation is in D114095 > now. Have you

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388409. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: clang/include/clang/Lex/ExternalPreprocessorSource.h

[PATCH] D112915: [clang][modules] Track included files per submodule

vsapsai added a comment. I think AST format for `IncludedFiles` was discussed here, so I'll continue here though the bulk of implementation is in D114095 now. Have you compared the size of resulting .pcm files when you are using a bitvector compared to a list

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388253. jansvoboda11 added a comment. Add missed newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388251. jansvoboda11 added a comment. Apply part of Volodymyr's cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D112915: [clang][modules] Track included files per submodule

jansvoboda11 updated this revision to Diff 388242. jansvoboda11 added a comment. Rebase, add type alias, improve map allocation in `ASTReader`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files: