[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm closed this revision. arsenm added a comment. Committed as 6c27d389c8a00040aad998fe959f38ba709a8750 , recommitted as 2f0a5714184cca9325004506a22a2a3193c825aa

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > JonChesterfield

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > JonChesterfield wrote: > > Here, we

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9288 + + const bool IsOpenMP = M.getLangOpts().OpenMP && !FD; + if ((IsOpenCLKernel || IsHIPKernel || IsOpenMP) && JonChesterfield wrote: > Here, we do the

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added a subscriber: estewart08. JonChesterfield added a comment. Is the behaviour change in the above comments intentional? Pointed out by @estewart08 Comment at: clang/lib/CodeGen/TargetInfo.cpp:9208 - FD->hasAttr(); - if

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Apologies, I thought I had already accepted this. Thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm updated this revision to Diff 386137. arsenm added a comment. Also test non-kernel CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm added a comment. In D113538#3121062 , @JonChesterfield wrote: > That seems important. What was the symptom of failing to set these? We may > now be redundantly setting some, e.g. > I think convergent is set somewhere else before this patch. A

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

JonChesterfield added reviewers: tianshilei1992, ye-luo, jhuber6. JonChesterfield added a comment. That seems important. What was the symptom of failing to set these? We may now be redundantly setting some, e.g. I think convergent is set somewhere else before this patch. Added a few people who

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm created this revision. arsenm added reviewers: jdoerfert, JonChesterfield, ronlieb, gregrodgers. Herald added subscribers: guansong, yaxunl, jvesely. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. This wasn't setting any of the attributes the target