[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

galapoz1996 added a comment. Herald added subscribers: steakhal, MaskRay. Herald added a reviewer: NoQ. Herald added a project: All. I used to think that therapy was only for people with "real" problems, but I couldn't have been more wrong. Seeking help for my anxiety and depression has been

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3162140 , @rjmccall wrote: > Those all look good, thanks. Committed here Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

rjmccall added a comment. Those all look good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall These are the proposed changes which address some of your comments. I am planning on waiting for further clarification on some of the others. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall thanks for having a look, I will clarify the comments with your suggestions. In D114025#3152900 , @tstellar wrote: > @ZarkoCA If you are planning to do a lot of this, it might be good to write a > script (or a

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

tstellar added a comment. @ZarkoCA If you are planning to do a lot of this, it might be good to write a script (or a clang-tidy check even) that we can add to CI, so these terms don't get re-introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

rjmccall added subscribers: rsmith, rjmccall. rjmccall added a comment. If you aren't sure what a comment means, please feel free to CC Richard or me, and we might be able to help. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

gandhi21299 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5536 +// GCC does not enforce these rules for GNU atomics, but we do, because if +// we didn't it would be very confusing. FIXME: For whom? How so? auto IsAllowedValueType = [&](QualType

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e5a0c42bd8: [clang][NFC] Inclusive terms: replace some uses of sanity in clang (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D114025?vs=388550=388587#toc Repository: rG

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Thanks @aaron.ballman and @Quuxplusone for the constructive reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validation

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388550. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. - Address latest round of comments - Fix unrelated formatting to stop distracting clang-format linter complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added a comment. (Re repeated thanks: You're welcome. :) For the record, I personally see nothing wrong with the phrase "sanity-check" either; but given that it's gonna happen, and we're re-wording comments on by definition the subtlest and most confusing parts of the code, I'm

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388494. ZarkoCA added a comment. - Add FIXME to comments and fix grammar on one comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. In D114025#3142565 , @aaron.ballman wrote: > In D114025#3141414 , @keryell wrote: > >> In D114025#3140192

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. In D114025#3141414 , @keryell wrote: > In D114025#3140192 , @Quuxplusone > wrote: > >> I think "sanity-check" could be reasonably replaced

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

keryell added a comment. In D114025#3140192 , @Quuxplusone wrote: > I think "sanity-check" could be reasonably replaced with "smoke-test," but > (1) this PR doesn't do that, and (2) the phrase "smoke-test" is probably > //harder// to understand, It

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 13 inline comments as done. ZarkoCA added a comment. @Quuxplusone Thanks for thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388332. ZarkoCA added a comment. - Address review comments - Also rename some variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone added inline comments. Comment at: clang/include/clang/AST/Redeclarable.h:261 assert(Current && "Advancing while iterator has reached end"); - // Sanity check to avoid infinite loop on invalid redecl chain. + // Validation check to avoid infinite

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140192 , @Quuxplusone wrote: > Peanut gallery says: I'd recommend //not// taking this particular patch; it > seems much less "obvious" than the whitelist/inclusionlist type of patch. > Whereas "whitelist" is just a

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388207. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Reword comments based on suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity`

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

lebedev.ri added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` ->

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

Quuxplusone requested changes to this revision. Quuxplusone added a comment. This revision now requires changes to proceed. Peanut gallery says: I'd recommend //not// taking this particular patch; it seems much less "obvious" than the whitelist/inclusionlist type of patch. Whereas "whitelist"

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> >

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

martong added a comment. Do we have a comprehensive list of non-inclusive terms and their inclusive correspondent somewhere available? I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> `validation`, ... I'd assume that we go through that list, and that could give me a

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, dcoughlin, quinnp. ZarkoCA added a project: clang. Herald added subscribers: dexonsmith, martong. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Rewording of comments to avoid using `sanity