[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc added a comment. Thanks for the detailed comments. I moved the patch into the clangd callsite. I also added a couple ObjC tests for CallHierarchy (I basically parameterized two of the existing tests). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388101. sheldonneuberger-sc added a comment. - fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388100. sheldonneuberger-sc added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc updated this revision to Diff 388099. sheldonneuberger-sc added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. - move change to clangd callsite - add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

kadircet added a comment. I agree with Nathan on this one. It's unclear why there are two functions that does the same thing in different ways and some usages in sema looks suspicious enough to require caution (there are subtle checks for shadowing and whatnot and I don't know how these rules

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

nridge added a comment. Thanks for the patch. Could you add a test exercising call hierarchy for obj-c methods to CallHierarchyTests.cpp please? In terms of the actual change, this function has some other callers

[PATCH] D114058: [clang] Add ObjC decls to Decl::isFunctionOrFunctionTemplate

sheldonneuberger-sc created this revision. sheldonneuberger-sc added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet. sheldonneuberger-sc added a reviewer: erichkeane. sheldonneuberger-sc edited the summary of this revision. sheldonneuberger-sc published this revision for review.