This revision was automatically updated to reflect the committed changes.
thakis marked an inline comment as done.
Closed by commit rG3950e1be8d6e: [clang] Remove CLANG_ROUND_TRIP_CC1_ARGS and
always roundtrip in +assert builds (authored by thakis).
Herald added a project: clang.
Changed prior
thakis marked an inline comment as done.
thakis added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:615
// May perform round-trip of command line arguments. By default, the round-trip
// is enabled if CLANG_ROUND_TRIP_CC1_ARGS was defined during build.
jansvoboda11 added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:615
// May perform round-trip of command line arguments. By default, the round-trip
// is enabled if CLANG_ROUND_TRIP_CC1_ARGS was defined during build. This can
be
// overwritten at
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114120/new/
https://reviews.llvm.org/D114120
___
cfe-commits
dexonsmith added a comment.
SGTM; I'll let @jansvoboda11 confirm though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114120/new/
https://reviews.llvm.org/D114120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thakis created this revision.
thakis added reviewers: dexonsmith, jansvoboda11.
Herald added a subscriber: mgorny.
thakis requested review of this revision.
This removes the ability to disable roundtripping in assert builds.
(Roundtripping happens by default in assert builds both before and after
