[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-27 Thread Bradley Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa83aa33d1bf9: [IR] Move vector.insert/vector.extract out of experimental namespace (authored by bsmith). Changed prior to commit:

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-23 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: llvm/docs/LangRef.rst:17282 + declare @llvm.vector.insert.nxv4f32.v4f32( %vec, <4 x float> %subvec, i64 %idx) + declare @llvm.vector.insert.nxv2f64.v2f64( %vec, <2 x double>

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-22 Thread Bradley Smith via Phabricator via cfe-commits
bsmith updated this revision to Diff 438975. bsmith added a comment. - Further improve clarity on usable types in LangRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 Files:

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-21 Thread Javier Setoain via Phabricator via cfe-commits
jsetoain added inline comments. Comment at: llvm/docs/LangRef.rst:17292-17294 +``llvm.vector.insert`` can be used to insert a fixed-width vector into a +scalable vector, but not the other way around. To answer Craig's point, I don't think it was clear before

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/docs/LangRef.rst:17289 insert into. Conceptually, this can be used to build a scalable vector out of -non-scalable vectors. +non-scalable vectors, however this intrinsic can also be used on purely fixed +types.

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-21 Thread Bradley Smith via Phabricator via cfe-commits
bsmith updated this revision to Diff 438718. bsmith added a comment. - Clarify LangRef slightly to make it clearer that fixed types can be used - Rebase on top of recent test changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-17 Thread Diego Caballero via Phabricator via cfe-commits
dcaballe added subscribers: jsetoain, dcaballe. dcaballe added a comment. Hey Bradley! Thanks for pinging us about this upcoming change! Something that my colleague @jsetoain mentioned is that these vector insert/extract intrinsics can also work on fixed-length only vectors. However, the

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-16 Thread Bradley Smith via Phabricator via cfe-commits
bsmith updated this revision to Diff 437557. bsmith added a comment. - Add info to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-16 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Maybe a line in the Release Notes of LLVM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 ___ cfe-commits mailing list

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

2022-06-16 Thread Bradley Smith via Phabricator via cfe-commits
bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, c-rhodes, sdesmalen. Herald added subscribers: ctetreau, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,