[PATCH] D131298: [clang-doc] Read docstrings for record members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99baa10f8f01: [clang-doc] Read docstrings for record members (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451882. brettw marked 2 inline comments as done. brettw added a comment. New patch up with requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:166 + ExpectedE.Members.emplace_back("int", "value", AccessSpecifier::AS_public); + //ExpectedE.Members.back().Description.push_back(MakeOneLineCommentInfo(" Some docs"));

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth added a comment. Thanks. Can we get the small changes to the assert + the TODO in Serialize.cpp? I'll be happy to land this for you after that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451632. brettw added a comment. New patch up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth added a comment. LGTM, modulo the small fixes I've left inline Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + assert(D); + ASTContext& Context = D->getASTContext();

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451299. brettw marked an inline comment as done. brettw added a comment. I updated the comment test that's not currently working with a TODO. There are some open questions in the code review about some bigger questions about this tool. Since this has been

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw marked 2 inline comments as done. brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment =

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451001. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment = Context.getRawCommentForDeclNoCache(D);

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added a comment. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:354 +template <> llvm::Expected getCommentInfo(MemberTypeInfo *I) { + I->Description.emplace_back(); + return >Description.back(); paulkirth wrote: > So, I see that this uses

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450967. brettw added a comment. Herald added subscribers: usaxena95, arphaman. Added some tests (with one open question). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

paulkirth requested changes to this revision. paulkirth added a comment. This revision now requires changes to proceed. I agree w/ @phosek on unit testing. Additionally, while we don't have many of them in clang-doc, an end-to-end test would also be welcome. In this case, it will also probably

[PATCH] D131298: [clang-doc] Read docstrings for record members

phosek added a comment. Would it be possible to extend the existing unit tests to cover this: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw created this revision. brettw added a reviewer: phosek. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Struct/class data members did not have the comments associated with them. This