This revision was automatically updated to reflect the committed changes.
Closed by commit rGe191086bfcb7: [clang-doc] Support default args for
functions. (authored by brettw, committed by paulkirth).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
Lgtm
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133732/new/
https://reviews.llvm.org/D133732
___
cfe-commits mailing list
brettw updated this revision to Diff 460538.
brettw marked 4 inline comments as done.
brettw added a comment.
There is no usage change for this. It just adds another field to the YAML.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133732/new/
https://reviews.llvm.org/D133732
Files:
paulkirth added a comment.
Thanks for the patch. This is mostly LGTM modulo a few nits.
My one question is regarding documentation. Do you think this needs to be
described in the clang-tools-extra/doc/clang-doc.rst? And are there any changes
in workflow or tool usage that we should document? I
brettw created this revision.
brettw added a reviewer: paulkirth.
brettw added a project: clang-tools-extra.
Herald added a project: All.
brettw requested review of this revision.
Herald added a subscriber: cfe-commits.
Adds support for default arguments in the internal representation and reads
