This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeaa7b324d5a2: [clang-doc] Add support for explicitly typed
enums (authored by brettw, committed by paulkirth).
Repository:
rG LLVM Github
brettw updated this revision to Diff 461366.
brettw added a comment.
Clang-formatted
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134055/new/
https://reviews.llvm.org/D134055
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeWriter.cpp
paulkirth added a comment.
Sorry, it looks like a pre-submit formatting check failed. can you `git
clang-format HEAD~` and re-upload? I can land your change after that.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134055/new/
https://reviews.llvm.org/D134055
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134055/new/
https://reviews.llvm.org/D134055
___
cfe-commits mailing list
brettw added inline comments.
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53
+llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef
Blob) {
+ auto ByteWidth = R[0];
paulkirth wrote:
> brettw wrote:
> > paulkirth wrote:
> > > do
brettw updated this revision to Diff 461259.
brettw marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134055/new/
https://reviews.llvm.org/D134055
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeWriter.cpp