[PATCH] D134055: [clang-doc] Export enum type and value information.

2022-09-16 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. I think maybe you made the title the first line of the summary instead of the other way around. I was looking for this as the title: `[clang-doc] Add support for explicitly typed enums` Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:71

[PATCH] D134055: [clang-doc] Export enum type and value information.

2022-09-16 Thread Brett Wilson via Phabricator via cfe-commits
brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > do you need to do all of this? APSInt

[PATCH] D134055: [clang-doc] Export enum type and value information.

2022-09-16 Thread Brett Wilson via Phabricator via cfe-commits
brettw updated this revision to Diff 460882. brettw marked 2 inline comments as done. brettw retitled this revision from "[clang-doc] Export more enum information" to "[clang-doc] Export enum type and value information.". brettw edited the summary of this revision. Repository: rG LLVM Github