This revision was automatically updated to reflect the committed changes.
Closed by commit rG4df84ac377df: [clang-doc] Centralize TypeInfo creation.
(authored by brettw, committed by paulkirth).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
brettw updated this revision to Diff 461397.
brettw marked an inline comment as done.
brettw added a comment.
Comment addressed
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134225/new/
https://reviews.llvm.org/D134225
Files:
clang-tools-extra/clang-doc/Representation.h
paulkirth added a comment.
Also, can you take a look at the premerge check failure? it looks like it had
trouble applying your patch, so you may need to rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134225/new/
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
Thanks for the code cleanup. The patch is LGTM, with some small nits.
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:240
+TypeInfo getTypeInfoForType(const
brettw created this revision.
brettw added a reviewer: paulkirth.
brettw added a project: clang-tools-extra.
Herald added a project: All.
brettw requested review of this revision.
Herald added a subscriber: cfe-commits.
Several different places in the code had similar computations for the
