[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fb70c6ab3b: [clang-doc] Add typedef/using information. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467894. brettw added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth added a comment. The premerge check is failing, because it can't apply the patch. Often this just means you need to rebase, so can you try rebasing your change and reuploading? Also, do you have commit access? you've made enough changes that its appropriate to request, which should

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw reopened this revision. brettw added a comment. This revision is now accepted and ready to land. New patch up to fix warnings that caused the revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 466858. brettw added a comment. Fixed -Wall issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134371: [clang-doc] Add typedef/using information.

haowei added a comment. In D134371#3819605 , @nemanjai wrote: > This causes failures with `-Werror` such as: > https://lab.llvm.org/buildbot/#/builders/57/builds/22322 > Please fix or revert. Thanks for reporting this. I reverted this change.

[PATCH] D134371: [clang-doc] Add typedef/using information.

nemanjai added a comment. This causes failures with `-Werror` such as: https://lab.llvm.org/buildbot/#/builders/57/builds/22322 Please fix or revert. Comment at: clang-tools-extra/clang-doc/Representation.h:45 + IT_enum, + IT_typedef }; There are at least

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rGeed22583fd78: [clang-doc] Add typedef/using information. (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth accepted this revision. paulkirth added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { brettw wrote: >

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { paulkirth wrote: > nit: can we avoid unrelated changes to whitespace here and elsewhere in the > patch?

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 462313. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth added a comment. Can we also add support for some of these changes to the other backends? I'm fine w/ us delaying that a bit, and tackling those in separate patches, but we shouldn't let one backend get wildly ahead of the others. Comment at:

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Read typedef and "using" type alias