This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7231c9966e52: [clang-doc] Fix typedef/using output.
(authored by brettw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397
+template <> llvm::Expected getCommentInfo(TypedefInfo *I) {
+ I->Description.emplace_back();
brettw updated this revision to Diff 470598.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136638/new/
https://reviews.llvm.org/D136638
Files:
clang-tools-extra/clang-doc/BitcodeReader.cpp
clang-tools-extra/clang-doc/BitcodeWriter.cpp
clang-tools-extra/clang-doc/Representation.h
paulkirth added a comment.
Can you add a test that checks the `IsUsing == false` case? Otherwise LGTM
modulo one small nit.
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397
+template <> llvm::Expected getCommentInfo(TypedefInfo *I) {
+
brettw created this revision.
brettw added a reviewer: paulkirth.
brettw added a project: clang-tools-extra.
Herald added a project: All.
brettw requested review of this revision.
Herald added a subscriber: cfe-commits.
Provides an initializer for the TypedefInfo.IsUsing member. Previously this
