[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b8c7e02122a: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 478683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth reopened this revision. paulkirth added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-doc/single-file-public.cpp:9 +// for a name with a 40-char USR name. +// RUN: find %t -regex

[PATCH] D138073: [clang-doc] Move file layout to the generators.

thakis added a comment. In D138073#3944730 , @paulkirth wrote: > @thakis thanks for the report. I've reverted for now. @brettw can you take a > look? I'm a bit surprised that passed on the Linux and windows bot, but > failed on Mac. Probably a BSD

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. @thakis thanks for the report. I've reverted for now. @brettw can you take a look? I'm a bit surprised that passed on the Linux and windows bot, but failed on Mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138073: [clang-doc] Move file layout to the generators.

thakis added a comment. This breaks tests on mac: http://45.33.8.238/macm1/49211/step_8.txt (and possibly win; that's still cycling.) Please take a look and revert for now if it takes a while to fix. (Also,  Mr W!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a469fc5727: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476955. brettw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. This is mostly LGTM, modulo the small change to the test that I've suggested. Assuming the presubmit tests still pass with that small edit, you're good on my end.

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476612. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and ,

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476183. brettw marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added a comment. Can you document the new directory structure with a small example? It would also be good to document in the code that some of these changes were driven by file corruption, and if possible point to a bug on github. Comment at:

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 475869. brettw added a comment. Updated the lit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added a comment. If you're curious, you can see the simplification the YAML output format change makes in the consuming code: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/760570/2/tools/cppdocgen/clangdoc/clangdoc.go Since it allows us to remove some special-casing code for

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Previously file