Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

I've updated the change. Would you mind checking it in? I'll look into switching the implementations shortly. On Tue, Feb 9, 2016 at 11:02 AM, Sterling Augustine wrote: > saugustine updated this revision to Diff 47343. > saugustine added a comment. > > - Cleanup dyn_cast

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith closed this revision. rsmith added a comment. In r260278. http://reviews.llvm.org/D15861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 47343. saugustine added a comment. - Cleanup dyn_cast usage inside QualTypeNames. http://reviews.llvm.org/D15861 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 47267. saugustine added a comment. - Privatize all functions but getFullyQualifiedName. http://reviews.llvm.org/D15861 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/CMakeLists.txt lib/Tooling/Core/QualTypeNames.cpp

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, let's go ahead with this approach for now; we can investigate replacing the implementation with a `PrintingPolicy` flag later. Comment at:

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

Richard, Please take another look when you get a chance. Thanks. On Tue, Feb 2, 2016 at 11:14 AM, Sterling Augustine wrote: > saugustine updated this revision to Diff 46680. > saugustine marked 19 inline comments as done. > saugustine added a comment. > > - Update docs.

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 46680. saugustine marked 19 inline comments as done. saugustine added a comment. - Update docs. Handle keywords and anonymous namespaces. - Address code review issues. Cleanup many http://reviews.llvm.org/D15861 Files:

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

cisions for these interfaces, so that we know what possible results are / are not correct. Extending this to support other clients (which want to know how to name an entity from a specified context) is secondary, and can be postponed until someone wants to put in the work to make it happen. Cheers, >

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith added a comment. I think this functionality can be provided more simply by adding another flag to `PrintingPolicy` to request fully-qualified names always be produced. It already usually provides fully-qualified names; the only notable exception I can see is that if a qualifier was

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine added a comment. Thanks for the reviews. Please take another look when you get a chance. Comment at: include/clang/Tooling/Core/QualTypeNames.h:32-33 @@ +31,4 @@ +namespace TypeName { +///\brief Convert the type into one with fully qualified template +/// arguments.

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

:: (i.e. ::std::tuple<::A::X> which would always be safe no matter which context you use it). Cheers, Philippe. Forwarded Message Subject:

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

saugustine updated this revision to Diff 44245. saugustine marked 4 inline comments as done. saugustine added a comment. - Update docs. Handle keywords and anonymous namespaces. http://reviews.llvm.org/D15861 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/CMakeLists.txt

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

nlewycky added a subscriber: nlewycky. nlewycky added a comment. (I'm not doing a full review, I just happened to notice a couple things when skimming.) Comment at: lib/Tooling/Core/QualTypeNames.cpp:250 @@ +249,3 @@ +// There are probably other cases ... +if (const

Re: [PATCH] D15861: Support fully-qualified names for all QualTypes

rsmith added inline comments. Comment at: include/clang/Tooling/Core/QualTypeNames.h:32 @@ +31,3 @@ +namespace TypeName { +///\brief Convert the type into one with fully qualified template +/// arguments. Please ensure there's a space between each `/// ` and the