Anastasia added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:1386
@@ -1385,1 +1385,3 @@
+ if (Quals.hasAddressSpace()) {
+// Address space extension:
I was just wondering since this code appears to be a repetition from
ItaniumMangler.cpp,
ichesnokov added a comment.
Please review the last version of patch.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Ping.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
Ping.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
I noticed that MicrosoftMangler already has many extension functions. I.e. this
MicrosoftMangler.cpp change is Ok.
Please review and accept/commit.
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
ichesnokov updated the summary for this revision.
ichesnokov updated this revision to Diff 46772.
ichesnokov added a comment.
This diff adds mangling check test cases for Itanium and Microsoft manglers
http://reviews.llvm.org/D16539
Files:
lib/AST/ItaniumMangle.cpp
ichesnokov added a comment.
Please support discussion about MicrosoftMangle+CL at
https://llvm.org/bugs/show_bug.cgi?id=26194
Comment at: tools/driver/driver.cpp:367
@@ -367,1 +366,3 @@
+int Result = ExecuteCC1Tool(argv, argv[1] + 4);
+return Result; // Useful for
pxli168 added inline comments.
Comment at: test/CodeGenOpenCL/generic_mangling.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 -ffake-address-space-map -emit-llvm -ffp-contract=off -x cl
-cl-std=CL2.0 -o - %s | FileCheck %s
+
Is this enough for the new added
ichesnokov removed rL LLVM as the repository for this revision.
ichesnokov updated this revision to Diff 46532.
ichesnokov added a comment.
Added generic variable support and checking address space to Microsoft mangler.
Test case updated.
http://reviews.llvm.org/D16539
Files:
ichesnokov added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:1799
@@ -1798,2 +1798,3 @@
case LangAS::opencl_constant: ASString = "CLconstant"; break;
+ case LangAS::opencl_generic: ASString = "CLgeneric"; break;
// ::= "CU" [ "device" |
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=26194
Repository:
rL LLVM
http://reviews.llvm.org/D16539
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
11 matches
Mail list logo