majnemer added a subscriber: majnemer.
Comment at: include/clang/Basic/TargetInfo.h:206
@@ +205,3 @@
+ /// \brief Whether explicit bit field alignment attributes are honored.
+ unsigned int UseExplicitBitFieldAlignment : 1;
+
I'd use `unsigned` to match the
Sunil_Srivastava updated this revision to Diff 47026.
Sunil_Srivastava added a comment.
Changed the patch based of feedback from John McCall.
There is new bit UseExplicitBitFieldAlignment, which is set for everything
except for PS4. The r257462 change has been made conditional on this bit.
rjmccall added a comment.
Yes, thank you, this looks great. I agree with David's review, but otherwise
this LGTM.
http://reviews.llvm.org/D16788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
probinson added inline comments.
Comment at: include/clang/Basic/TargetCXXABI.h:118
@@ -115,1 +117,3 @@
+/// in LLVM 3.2.
+PS4
};
rjmccall wrote:
> I'm not sure why you added a new C++ ABI kind here. The bug fix you're
> opting out of is not at all
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetCXXABI.h:118
@@ -115,1 +117,3 @@
+/// in LLVM 3.2.
+PS4
};
probinson wrote:
> rjmccall wrote:
> > I'm not sure why you added a new C++ ABI kind here. The bug fix you're
> > opting
rsmith added inline comments.
Comment at: lib/AST/RecordLayoutBuilder.cpp:1598-1599
@@ -1597,1 +1597,4 @@
+// PS4 remains compatible to pre r257462 behavior.
+bool isPS4ABI = (Context.getTargetInfo().getCXXABI().getKind() ==
TargetCXXABI::PS4);
+
Sunil_Srivastava created this revision.
Sunil_Srivastava added reviewers: rjmccall, DmitryPolukhin, rsmith, probinson.
Sunil_Srivastava added a subscriber: cfe-commits.
This is the round 2 of the PS4 ABI. In this round:
1) A new value PS4 has been added to TargetCXXABI::Kind. It is being used
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetCXXABI.h:118
@@ -115,1 +117,3 @@
+/// in LLVM 3.2.
+PS4
};
I'm not sure why you added a new C++ ABI kind here. The bug fix you're opting
out of is not at all specific to C++, and
