Eugene.Zelenko added a comment.
In http://reviews.llvm.org/D16794#343652, @LegalizeAdulthood wrote:
> Again, isn't this already assigned to me in the bug tracker?
>
> In general, my assumption in bug trackers is that if someone has assigned the
> bug to themselves, then they are working on it.
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D16794#341552, @aaron.ballman wrote:
> Missing a test case for this functionality. The isExpansionInMainFile() was
> used to silence the diagnostic in macros, but it was pointed out during
> review that this should be fixed and it
LegalizeAdulthood added a comment.
Again, isn't this already assigned to me in the bug tracker?
In general, my assumption in bug trackers is that if someone has assigned the
bug to themselves, then they are working on it.
Repository:
rL LLVM
http://reviews.llvm.org/D16794
Eugene.Zelenko added a comment.
I think proper solution will be to create tests for included files ot the fly,
bu renaming main test to .h and creating dummy source file. But this is task
for scripts wizards :-)
Repository:
rL LLVM
http://reviews.llvm.org/D16794
Eugene.Zelenko added a comment.
I didn't notice test cases for included files for other checkers. So it's hard
to tell for should special test case introduced for this specific problem or
not.
Repository:
rL LLVM
http://reviews.llvm.org/D16794
aaron.ballman added a comment.
Missing a test case for this functionality. The isExpansionInMainFile() was
used to silence the diagnostic in macros, but it was pointed out during review
that this should be fixed and it seems to have fallen through the cracks. Can
you also add tests for macros
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This fix for PR26332. I checked it on my work code base.
Build and
